Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 22 Jan 2019 20:29:16 +0100
From:   Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To:     Paul Burton <paul.burton@mips.com>
Cc:     Aaro Koskinen <aaro.koskinen@iki.fi>,
        Ralf Baechle <ralf@linux-mips.org>,
        James Hogan <jhogan@kernel.org>,
        John Crispin <john@phrozen.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-mips@vger.kernel.org" <linux-mips@vger.kernel.org>
Subject: Re: [PATCH 1/5] mips: cavium: no need to check return value of
 debugfs_create functions
Message-ID: <20190122192916.GB5676@kroah.com>
References: <20190122145742.11292-1-gregkh@linuxfoundation.org>
 <20190122145742.11292-2-gregkh@linuxfoundation.org>
 <20190122184855.GB2792@darkstar.musicnaut.iki.fi>
 <20190122192255.tjkmwgx25wvcp6y6@pburton-laptop>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190122192255.tjkmwgx25wvcp6y6@pburton-laptop>
User-Agent: Mutt/1.11.2 (2019-01-07)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 22, 2019 at 07:22:57PM +0000, Paul Burton wrote:
> Hello,
> 
> On Tue, Jan 22, 2019 at 08:48:56PM +0200, Aaro Koskinen wrote:
> > On Tue, Jan 22, 2019 at 03:57:38PM +0100, Greg Kroah-Hartman wrote:
> > > -static int init_debufs(void)
> > > +static void init_debugfs(void)
> > >  {
> > > -	struct dentry *show_dentry;
> > >  	dir = debugfs_create_dir("oct_ilm", 0);
> > > -	if (!dir) {
> > > -		pr_err("oct_ilm: failed to create debugfs entry oct_ilm\n");
> > > -		return -1;
> > > -	}
> > > -
> > > -	show_dentry = debugfs_create_file("statistics", 0222, dir, NULL,
> > > -					  &oct_ilm_ops);
> > > -	if (!show_dentry) {
> > > -		pr_err("oct_ilm: failed to create debugfs entry oct_ilm/statistics\n");
> > > -		return -1;
> > > -	}
> > > -
> > > -	show_dentry = debugfs_create_file("reset", 0222, dir, NULL,
> > > -					  &reset_statistics_ops);
> > > -	if (!show_dentry) {
> > > -		pr_err("oct_ilm: failed to create debugfs entry oct_ilm/reset\n");
> > > -		return -1;
> > > -	}
> > > -
> > > +	debugfs_create_file("statistics", 0222, dir, NULL, &oct_ilm_ops);
> > > +	debugfs_create_file("reset", 0222, dir, NULL, &reset_statistics_ops);
> > >  	return 0;
> > 
> > The return needs to be deleted now that the function is void.
> 
> Well spotted - I'm happy to fix this up whilst applying the patch.

The fact that 0-day didn't catch this makes me worried, is this
platform/driver not being built there?

Thanks for catching this, sorry for the mistake.

greg k-h