Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp183925imu;
        Tue, 22 Jan 2019 16:33:09 -0800 (PST)
X-Google-Smtp-Source: ALg8bN4lL2W5OdrDwaD3frJKa2UnRAFfweIuAf4M5JL2HmIjUIdlohXuDf+WIvungI6uL0lKnQqk
X-Received: by 2002:a63:5b1f:: with SMTP id p31mr111253pgb.56.1548203589241;
        Tue, 22 Jan 2019 16:33:09 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1548203589; cv=none;
        d=google.com; s=arc-20160816;
        b=jv3pkfBr+vJxnb9p02vO7/JO6rMcFVJ1j91VlQGjEge1kcYEFF1U08Q4wStoayvUXj
         +yyN9++YXnEC6UK4+knAcFHmPGU8DRot0JLsFSDrBwIaSCMbcrsqdI4ri2LjwhJ1ElH3
         78DKx/XFFlZc3I/0p5OUieYnne/xo2G0UxIFuYEAsaI07yz8fRtO92HUUC+8bcOIg5tp
         Z7noqEaxMN1phFWL+NzxUSAeyAnRtKRa3idYf422dffoe/dcm7Wfuit/oancdBU1BFee
         1Zmm8lwCssne+ynrbo/S4sX2rNNBRQ8QaDjAmgBfMJnjCGXibS9LpyYP7QB6/3e10B2Z
         +Sdw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:cc:to:subject:message-id:date:from
         :in-reply-to:references:mime-version:dkim-signature;
        bh=3HfIhBZ63WOqBXt9BLrMwC7nB16ZBOfkry+Iv0A9qmo=;
        b=mVw8P5hAdwLljADqYJBYu22Sj8C9plWg/+dOxUeKw+i2FSO7eOZ8DvAt1bho6pTYh/
         VqJjtb9ahHUY4i33nf0YhwGoRU2jrMUiJNt+8bNMcyNjjw5qx14Y8GkvOagwsdHyZ3Yr
         8dl7Qj73/O/2Z8iiPfoepyPQa6ct3uwxCoDLvneiXFEnuDsYSEOEM3jBybdgUDkmBMEY
         YoFEq0Xa0xozzXh88iWjQhUyvC6rB/vqrBPRPG40zIbgRYcALzwRx4NGkxQUAK4gLRaM
         Cssqxi7lsSSbNlcs69nwaQBBw418FNdZJm9GmAqWnp9RZ0Qp9DnlmK3/Fk4YEFKudmNr
         gjqw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@noserose-net.20150623.gappssmtp.com header.s=20150623 header.b=gQ4Nl7vy;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 12si16592833pfx.102.2019.01.22.16.32.53;
        Tue, 22 Jan 2019 16:33:09 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@noserose-net.20150623.gappssmtp.com header.s=20150623 header.b=gQ4Nl7vy;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726914AbfAWAba (ORCPT <rfc822;chauncqc@gmail.com> + 99 others);
        Tue, 22 Jan 2019 19:31:30 -0500
Received: from mail-it1-f194.google.com ([209.85.166.194]:51625 "EHLO
        mail-it1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726207AbfAWAb3 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 22 Jan 2019 19:31:29 -0500
Received: by mail-it1-f194.google.com with SMTP id w18so807438ite.1;
        Tue, 22 Jan 2019 16:31:29 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=noserose-net.20150623.gappssmtp.com; s=20150623;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=3HfIhBZ63WOqBXt9BLrMwC7nB16ZBOfkry+Iv0A9qmo=;
        b=gQ4Nl7vyjttTrvcX6VZn8G3Kn6YNA/7Y/H+CSaJVd8ONY/p+mV2NoMCHnAFXEUOn8t
         4yfv18oWpnRDyPbgaXv7I7DCk4o5YRcvBGjxlsw3MdUhZ2+l3XOMkcTp9+GkTcpRpj4v
         t3BHbZAYRlcqHuYwFeL+gU+rEM9KwP9Nyfjk96ojaaecoFZNfqTeUSpn0gWaD8A2WK08
         9PcYBKXi2PryF2ySioqEPizFehcz2yIjGhE+V8YzwzztCL6LTcbW0Ao2YPfdR2v1Vsjg
         hGcOuGG8+OAk1uJXqab75CnYhYKutn/d6+UcmlqC79Pr4wZekh/YXG0TuCo4Hn8OQmen
         4ytw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=3HfIhBZ63WOqBXt9BLrMwC7nB16ZBOfkry+Iv0A9qmo=;
        b=kgs00JRPbmJD054ALrMpM/meo9lFPRtcCAcAm8hrOZHhxFSDSi+M2ztPn+3ZPomq/W
         4HPeKcdrnXpzbut6mnR8XOwBzn13FKh8tdwzw7e8UZokmt7QxQPY3XoE2GIqT7GT4+nO
         fGizt0rtL0nObnkPrdyUdEnYw+DwjI+6oWn2IHS0lG/GR18oxclEa/UfSjSGfPC+/cDu
         yEhjfOT74jEBV7s8YnKe2aL7OCqUBhXlVWpMm4Y65kutJo0QnONO8cr4m5gPPmPCdwxs
         9zgVkr8wCbV7l6kP9TQ8d4Vz0TJjUPS3IlpTN90Jrxkq0Rh9yQ6/9XxfZ4jLov9i4umR
         qiHA==
X-Gm-Message-State: AJcUukec+M7X29kbO97Hyf0fFWqpjBY/iMnYnl+/tGNvm3dpiXIb0xnl
        mmfo+NS1w7FEsG5UK2MED/l2QWpLWPPB2fGAMkbLKihb
X-Received: by 2002:a24:4d87:: with SMTP id l129mr444767itb.37.1548203488683;
 Tue, 22 Jan 2019 16:31:28 -0800 (PST)
MIME-Version: 1.0
References: <20190122152151.16139-5-gregkh@linuxfoundation.org> <20190122232933.GC5884@vader>
In-Reply-To: <20190122232933.GC5884@vader>
From:   Ed Cashin <ecashin@noserose.net>
Date:   Tue, 22 Jan 2019 19:31:17 -0500
Message-ID: <CADvA-dmmZOUCDpr0QJu6zcrD0ZU_HAGT=UmguHWWnUcm0S0X6w@mail.gmail.com>
Subject: Re: [PATCH] block: aoe: no need to check return value of
 debugfs_create functions
To:     Omar Sandoval <osandov@osandov.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, "Ed L. Cashin" <ed.cashin@acm.org>,
        Jens Axboe <axboe@kernel.dk>, linux-block@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 22, 2019 at 6:29 PM Omar Sandoval <osandov@osandov.com> wrote:
...
> Now entry is uninitialized here when we assign it to d->debugfs.

Thanks for noticing that.