Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261202AbUCBXEa (ORCPT ); Tue, 2 Mar 2004 18:04:30 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261788AbUCBXE3 (ORCPT ); Tue, 2 Mar 2004 18:04:29 -0500 Received: from gate.crashing.org ([63.228.1.57]:56003 "EHLO gate.crashing.org") by vger.kernel.org with ESMTP id S261202AbUCBXEY (ORCPT ); Tue, 2 Mar 2004 18:04:24 -0500 Subject: Re: [PATCH] ppc32: macserial.c missing variable declaration From: Benjamin Herrenschmidt To: Linus Torvalds Cc: "Wojciech 'Sas' Cieciwa" , Linux Kernel list , Andrew Morton In-Reply-To: References: <1078263053.21573.176.camel@gaston> Content-Type: text/plain Message-Id: <1078267984.28288.204.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 Date: Wed, 03 Mar 2004 09:53:04 +1100 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 24 > This can't be right. Those variables are never initialized anywhere. > > The usage of 'cmd' should either be removed entirely, or it should be > passed in as an argument, it looks like. In the meantime, it's better to > have code that doesn't compile than code that compiles but can't possibly > do anything sane. macserial is obsolete on 2.6. it should be removed. pmac_zilog is the replacement. I still haven't found the bug with pmac_zilog that caused the occasional crash on boot on the G5 though (it seems to be a subtle race, I haven't found anything wrong with pmac_zilog itself), but then, I've been quite busy with other things latey. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/