Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp457761imu; Tue, 22 Jan 2019 23:07:16 -0800 (PST) X-Google-Smtp-Source: ALg8bN7Ne40WN/BPkyiMIJEJ33z4CmpnU6TapUQrLItBHCGjoE4pQWRLxtwzA0Fy0/2/w1lZtGDF X-Received: by 2002:a17:902:2bc5:: with SMTP id l63mr1141023plb.107.1548227236716; Tue, 22 Jan 2019 23:07:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548227236; cv=none; d=google.com; s=arc-20160816; b=WBZikeszsTheToXV2ox1eEK/umMai/u26x42W3brTUGWzqSGtmlu8GodnyaQNlho/Z +c2VnUkw/tnb2HwTY2f8m2aNx1VoNNkm8lhQ8+68a7zC9uTldDqq49uFqx9vZd2QIpHh GzwoW4mZ0ArN4NWnBVKEYFqq7+5Ger9TiOZIzdy9Ypymih6gBojk+KRffEI4wr7MjiR3 2TLyKSrMto9PasFfNeDlgtIwmbQ0Nm0+gsPCvmk4fmrBPRkFQWreogsF8CfyPeCwm0rh motnZiOvunHyifvu017i7IKG78RGMW0M2n5dwFjKji8eHUPcwr4+NnubevdzupITiHpM LMoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :spamdiagnosticmetadata:spamdiagnosticoutput:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature; bh=LmPp7AtSAc2SmN1pZyzyaGS0c89juhQVNR3mGpKx5HU=; b=u7CDuzZMrfyWALSSimjAD/4Qu2M1fH/YfNkCCHYpACrT4NPP5S+D0xkzeKLPsSwdaN 0JqPrRHkrw9ofqf30CXOs+TSCzCBNYMT1P51P980hB08oDdhM6MEN2YytMvSrvEeViT8 h2y+r0itm5TzigZ412q0mYexFRu8fQmppE86npWhNKAK6cUn4KhmdicdQnm/a74az58e RAIfzzzonxBzSJnnuskcRH83YAh964FimudyoQuvYTAFXnYaslRCi3x0WNfsDOSmwgYp AtI+l5Xry7C8vrhmCEhWfq6DDtBnahQ1DHfcTBOMgep5Km/ZwGP56Ptsl7CpuAEeVJ0R o5wQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=ZY6a9CQP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l61si4562668plb.6.2019.01.22.23.07.01; Tue, 22 Jan 2019 23:07:16 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nxp.com header.s=selector1 header.b=ZY6a9CQP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726906AbfAWHFo (ORCPT + 99 others); Wed, 23 Jan 2019 02:05:44 -0500 Received: from mail-eopbgr30042.outbound.protection.outlook.com ([40.107.3.42]:26475 "EHLO EUR03-AM5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725995AbfAWHFm (ORCPT ); Wed, 23 Jan 2019 02:05:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LmPp7AtSAc2SmN1pZyzyaGS0c89juhQVNR3mGpKx5HU=; b=ZY6a9CQP7SSRTkcpVks2gM3G1Fsd8b9BBlj+KPGFFdGuI2kDLyEsqgfMDDzm7KZc0wUxiptLQEUe90LDtHcWNpc5G4rPqggsq3qW240HbCebdNPYvLZsa/KM5atJdWD9mGIqB5iNNHJmiKw/vs16nico4r+fhEuR1eYif5jGZTA= Received: from VI1PR04MB4158.eurprd04.prod.outlook.com (52.133.15.33) by VI1PR04MB5102.eurprd04.prod.outlook.com (20.177.50.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1537.26; Wed, 23 Jan 2019 07:05:36 +0000 Received: from VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::257e:f28a:1a8c:c9c4]) by VI1PR04MB4158.eurprd04.prod.outlook.com ([fe80::257e:f28a:1a8c:c9c4%2]) with mapi id 15.20.1537.031; Wed, 23 Jan 2019 07:05:36 +0000 From: Yinbo Zhu To: Alan Stern CC: Yinbo Zhu , Xiaobo Xie , Jerry Huang , Ran Wang , Greg Kroah-Hartman , Ramneek Mehresh , Nikhil Badola , Suresh Gupta , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH v3 3/5] usb: host: Stops USB controller init if PLL fails to lock Thread-Topic: [PATCH v3 3/5] usb: host: Stops USB controller init if PLL fails to lock Thread-Index: AQHUsuoKKdpWHwy+YEKqIOJMYFenYg== Date: Wed, 23 Jan 2019 07:05:36 +0000 Message-ID: <20190123070615.14462-3-yinbo.zhu@nxp.com> References: <20190123070615.14462-1-yinbo.zhu@nxp.com> In-Reply-To: <20190123070615.14462-1-yinbo.zhu@nxp.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: HK2PR0302CA0022.apcprd03.prod.outlook.com (2603:1096:202::32) To VI1PR04MB4158.eurprd04.prod.outlook.com (2603:10a6:803:46::33) authentication-results: spf=none (sender IP is ) smtp.mailfrom=yinbo.zhu@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.17.1 x-originating-ip: [119.31.174.73] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR04MB5102;6:Bl03ocoV0aRKdUF9LTkY8dgioNRkWbwJVhvzVCbiCZjUo9f9Gf54uLRXk53u+SIKqtrqvBOQSrsiyaGm75e8/yV1AZb7EFjVvEdreP8inbgDxQSBQZDadv/HQcPP5KBLgXLThhfsSBNQlS5mCwbvrEOKg0JNLrWMzCJBsDaXDuRxIhkbk4qR1VZzxj63JgyBlQ8d1grp1y7chr9iKxZt/KBR5mgzCR21EfJiQoF/vOe11nwv0WxdabGhM6JAVdsWy0Chm5SiC2Kg+fcz8Vo6vEsqmn5My1d/FI4jmIHMs39r+k4x/Zi77v3hwkNBA5cb6tYRJpIG2fbSGvRR4T10t+MZseJ3km3zsZrEJ5/48bZbW75m1kEyNN2GZIqmwnxTdaBfetfHRir0e73XMfs6S1lGMT9yAi4eEi3Cc3lwUe/tRj8ukrNx/5MtsaOgcZVD+EX82s9bGeOsUF9hCEJ03A==;5:DfqKsNitMI+Vd0cTihcV1nZwmmzbky0m+1TyvH15vSE4J55EZ23rjyBVFWjHk5WwW8XRtLuwPyyz1ao07MX7N8+0EAz09M52HlY99d7OThv1wreAOWyw2BSK0VcUp5iIO0EVVDRvGOvPv6b0YEV3WfLEM1kw6gFy4zLZvTLU/zUlVKY6axeTil2waYp2YUhquPj1ft8Z7iJaHrm9xzibjQ==;7:36bCdUyopxj/vNH3wSF69CB6Qwbx43iemJSlOvHTtUhfGM0hEzObY9E4YbooJKyWE/jq3jMPjzhC7QO6UZyBRSq0ro6ItlVMSjmqBUbUnBx0/C9osNF5kg9v4bXd1st7jb/7sryS1jnY/GIyhDybGg== x-ms-office365-filtering-correlation-id: 0c337b36-dbeb-449a-7325-08d681012c8b x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600110)(711020)(4605077)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:VI1PR04MB5102; x-ms-traffictypediagnostic: VI1PR04MB5102: x-microsoft-antispam-prvs: x-forefront-prvs: 0926B0E013 x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(376002)(346002)(136003)(396003)(39860400002)(199004)(189003)(478600001)(1076003)(2171002)(4326008)(14454004)(53936002)(186003)(44832011)(2616005)(446003)(3846002)(6116002)(11346002)(476003)(68736007)(25786009)(486006)(8676002)(81166006)(6506007)(386003)(81156014)(66066001)(8936002)(26005)(102836004)(86362001)(6916009)(76176011)(54906003)(256004)(14444005)(52116002)(6486002)(36756003)(2906002)(305945005)(105586002)(316002)(71190400001)(71200400001)(50226002)(97736004)(106356001)(7736002)(6436002)(6512007)(99286004);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR04MB5102;H:VI1PR04MB4158.eurprd04.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: s9tFnpnQ286Xeupgjggk8BT6pWKQPdztgW+MVBCa0qIRyCJo9LK//XPxnw1ha6TSevCxzxunaeLJDfomxss1o+/ARmFOlRSEhjaZtPHrNyjiSMyUo2v6MJtopARsBDfEY2lkdfmZcdcYdj22usJD2l/hwPgl2wNokkOd9LBgMIDsDl7eOvrkL3d0zqORfcqJMqw7vnw1qNxHbYqSAlYA0t/1zSh7RsqabEJtEhDI0Rmi47LxUVCNput6L62FhL02EwXINM+3MauGrVhF3nIzAKHXgGBzo1Qj/4mMWFCKaPLAbqLT19uLdXz2zuo8YQs9DKWBXkpfopcbX1LeW6WX5FpGKQyEOr5yYKtpHVabW/9wZlOycEkcY27gR+hMjdREPLbCrNYRQt78gA7kbnBFEPuOOSVG1C2pCCZ2qMPImNo= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0c337b36-dbeb-449a-7325-08d681012c8b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jan 2019 07:05:32.3978 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5102 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ramneek Mehresh USB erratum-A006918 workaround tries to start internal PHY inside uboot (when PLL fails to lock). However, if the workaround also fails, then USB initialization is also stopped inside Linux. Erratum-A006918 workaround failure creates "fsl,erratum_a006918" node in device-tree. Presence of this node in device-tree is used to stop USB controller initialization in Linux Signed-off-by: Ramneek Mehresh Signed-off-by: Suresh Gupta Signed-off-by: Yinbo Zhu --- drivers/usb/host/ehci-fsl.c | 5 +++++ drivers/usb/host/fsl-mph-dr-of.c | 4 ++++ 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index 8b0f3ed..e276067 100644 --- a/drivers/usb/host/ehci-fsl.c +++ b/drivers/usb/host/ehci-fsl.c @@ -236,6 +236,11 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd, portsc |=3D PORT_PTS_PTW; /* fall through */ case FSL_USB2_PHY_UTMI: + if (pdata->has_fsl_erratum_a006918) { + pr_warn("fsl-ehci: USB PHY clock invalid\n"); + return -EINVAL; + } + case FSL_USB2_PHY_UTMI_DUAL: /* PHY_CLK_VALID bit is de-featured from all controller * versions below 2.4 and is to be checked only for diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr= -of.c index 4f8b8a0..bdc8812 100644 --- a/drivers/usb/host/fsl-mph-dr-of.c +++ b/drivers/usb/host/fsl-mph-dr-of.c @@ -230,6 +230,10 @@ static int fsl_usb2_mph_dr_of_probe(struct platform_de= vice *ofdev) else pdata->has_fsl_erratum_14 =3D 0; =20 + if (of_get_property(np, "fsl,erratum_a006918", NULL)) + pdata->has_fsl_erratum_a006918 =3D 1; + else + pdata->has_fsl_erratum_a006918 =3D 0; =20 /* * Determine whether phy_clk_valid needs to be checked --=20 1.7.1