Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp482433imu; Tue, 22 Jan 2019 23:38:43 -0800 (PST) X-Google-Smtp-Source: ALg8bN45kqBShcKSeSRzqDyuNjL3nOWHsH4Eb4+AxjZxzcvpnX+rUmW6SpIN/ufS7k3cIfZzoD/3 X-Received: by 2002:a63:9b11:: with SMTP id r17mr1086032pgd.416.1548229123499; Tue, 22 Jan 2019 23:38:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548229123; cv=none; d=google.com; s=arc-20160816; b=G40LJ3jhqu1FFryhYx+HVgRYETILHVxnQZtgAygmHUOM/0RYnju0xq7A/9HYNuxAn3 U1U4DjrVNNPb3/5G/25LZ7VrCqE49Gr1eXk+zNuuyuwrtQOVb1oh1evwESM/dWzHULFF PeLmkuXfXLCiHwFVZcw7Vkhtmq+cKRLeM8PMhi32bTw9IxcYMyx6CJnQeEHcowS4TD0/ O8ZQ49NjHELXTdOvG9QiZ4tkkl3XZaNWcosBrW1WcQO4LkBE12AkEJTooqC9u2LaKnKm HgdjnjPSBvIyDgZ9JhmdBPqoZ2H87JYGTHg51OezG1MjeZqwygtLlj2YVB8ZUm1HLRvS 0CBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=eCgHxnOHhi3VWZI9RHXgexEMMTULwAK1T8cSZa3qKL0=; b=gWWhtcet+CvnUiuxMauHOKcF1tA9r8fKTQuPMHotozMRvaLjVBVqEWQykRSrA6wxN6 e91SHV4pMF7N393ntbnzxdg0w7rpn74eDliiY8Ufx0BlaH2ccdoQhAYEgqKwE9rx+VUM A3jtryF+gdxb1PFl4Fe05Djhs1Y93xod2vzRzOR5hu/qta0WksffVhbuCRPR9I4dgN1u YHil6LeTMn0+J4Rm5a4PG7/snWKNBUPTUREJq3uRsQpu0emiH54WhXihynGAqaeWNr0n leVOqnohjjBLvLjcN/jt1flDF8KtcO745l5rPw5XUwEyxjvFcSqhCcs+apqW4+0KnLZO PZHA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o13si18208051pgp.540.2019.01.22.23.38.27; Tue, 22 Jan 2019 23:38:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726329AbfAWHhX (ORCPT + 99 others); Wed, 23 Jan 2019 02:37:23 -0500 Received: from bastet.se.axis.com ([195.60.68.11]:38808 "EHLO bastet.se.axis.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726108AbfAWHhW (ORCPT ); Wed, 23 Jan 2019 02:37:22 -0500 Received: from localhost (localhost [127.0.0.1]) by bastet.se.axis.com (Postfix) with ESMTP id 4E681184F0; Wed, 23 Jan 2019 08:37:20 +0100 (CET) X-Axis-User: NO X-Axis-NonUser: YES X-Virus-Scanned: Debian amavisd-new at bastet.se.axis.com Received: from bastet.se.axis.com ([IPv6:::ffff:127.0.0.1]) by localhost (bastet.se.axis.com [::ffff:127.0.0.1]) (amavisd-new, port 10024) with LMTP id NlHpBvvo-gF1; Wed, 23 Jan 2019 08:37:18 +0100 (CET) Received: from boulder03.se.axis.com (boulder03.se.axis.com [10.0.8.17]) by bastet.se.axis.com (Postfix) with ESMTPS id B7936184A3; Wed, 23 Jan 2019 08:37:15 +0100 (CET) Received: from boulder03.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A2E201E077; Wed, 23 Jan 2019 08:37:15 +0100 (CET) Received: from boulder03.se.axis.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 968251E06A; Wed, 23 Jan 2019 08:37:15 +0100 (CET) Received: from thoth.se.axis.com (unknown [10.0.2.173]) by boulder03.se.axis.com (Postfix) with ESMTP; Wed, 23 Jan 2019 08:37:15 +0100 (CET) Received: from XBOX04.axis.com (xbox04.axis.com [10.0.5.18]) by thoth.se.axis.com (Postfix) with ESMTP id 8A5B6202D; Wed, 23 Jan 2019 08:37:15 +0100 (CET) Received: from [10.88.41.2] (10.0.5.60) by XBOX04.axis.com (10.0.5.18) with Microsoft SMTP Server (TLS) id 15.0.1365.1; Wed, 23 Jan 2019 08:37:14 +0100 Subject: Re: [PATCH 3/7] crypto: axis: no need to check return value of debugfs_create functions To: Greg Kroah-Hartman , Herbert Xu , David Miller CC: , , "Jesper Nilsson" , Lars Persson , References: <20190122151422.14204-1-gregkh@linuxfoundation.org> <20190122151422.14204-4-gregkh@linuxfoundation.org> From: Lars Persson Message-ID: Date: Wed, 23 Jan 2019 08:37:06 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190122151422.14204-4-gregkh@linuxfoundation.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: sv Content-Transfer-Encoding: 7bit X-ClientProxiedBy: XBOX01.axis.com (10.0.5.15) To XBOX04.axis.com (10.0.5.18) X-TM-AS-GCONF: 00 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/22/19 4:14 PM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Jesper Nilsson > Cc: Lars Persson > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: linux-arm-kernel@axis.com > Cc: linux-crypto@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > --- > drivers/crypto/axis/artpec6_crypto.c | 9 --------- > 1 file changed, 9 deletions(-) Acked-by: Lars Persson Thanks, Lars