Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 23 Jan 2019 10:52:53 +0100
From:   Boris Brezillon <bbrezillon@kernel.org>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     <robert.jarzmik@free.fr>, <dwmw2@infradead.org>,
        <computersforpeace@gmail.com>, <marek.vasut@gmail.com>,
        <richard@nod.at>, <linux-kernel@vger.kernel.org>,
        <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH -next] mtd: docg3: Fix passing zero to 'PTR_ERR' warning
 in doc_probe_device
Message-ID: <20190123105253.1f4487f2@bbrezillon>
In-Reply-To: <86533285-e800-5cc0-f495-88fff8326b5a@huawei.com>
References: <20190123065827.16748-1-yuehaibing@huawei.com>
        <20190123101253.243add9d@bbrezillon>
        <86533285-e800-5cc0-f495-88fff8326b5a@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 23 Jan 2019 17:43:58 +0800
YueHaibing <yuehaibing@huawei.com> wrote:

> On 2019/1/23 17:12, Boris Brezillon wrote:
> > On Wed, 23 Jan 2019 14:58:27 +0800
> > YueHaibing <yuehaibing@huawei.com> wrote:
> >   
> >> Fix a static code checker warning:
> >> drivers/mtd/devices/docg3.c:1875
> >>  doc_probe_device() warn: passing zero to 'ERR_PTR'
> >>
> >> Fixes: ae9d4934b2d7 ("mtd: docg3: add multiple floor support")
> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> >> ---
> >>  drivers/mtd/devices/docg3.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/mtd/devices/docg3.c b/drivers/mtd/devices/docg3.c
> >> index 4c94fc0..60ddc38 100644
> >> --- a/drivers/mtd/devices/docg3.c
> >> +++ b/drivers/mtd/devices/docg3.c
> >> @@ -1872,7 +1872,7 @@ doc_probe_device(struct docg3_cascade *cascade, int floor, struct device *dev)
> >>  nomem2:
> >>  	kfree(docg3);
> >>  nomem1:
> >> -	return ERR_PTR(ret);
> >> +	return ret ? ERR_PTR(ret) : NULL;
> >>  }
> >>    
> > 
> > This is not the right fix, you should instead set ret to -EINVAL:  
> 
> Thanks , will fix it in v2.
> 
> And seems doc_probe_device cannot return NULL. The NULL check of doc_probe_device
> in docg3_probe also can been removed, right?

Hm, looks like the ret = 0 was intentional (to identify when ID is
invalid). Let's just keep your initial patch.