Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp639878imu; Wed, 23 Jan 2019 03:04:00 -0800 (PST) X-Google-Smtp-Source: ALg8bN724gJ+oNR3yvnGiUTrlbLM26FUtBBuU1R2OfU6Yn6YJFikCtv4QrAD4Vdw/1Q+1WiE2pqe X-Received: by 2002:a63:5761:: with SMTP id h33mr1557300pgm.283.1548241440286; Wed, 23 Jan 2019 03:04:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548241440; cv=none; d=google.com; s=arc-20160816; b=WLrVVgl7VlewIiBBvtGRJpOBLMqb94brihdCyWpdbqMNpVbE8q5KFKPoVl3WYz3mFA heg4Wcy4kiQbNjfZKVvHDFSfWoa+3NNhVfwqFUMQSEWKcpjMk6l3wG0Tcv5XPr/ILg8T P+xxxGH+Prw2+2hLEUd/9cnhMetYl2TXeqQaGS5cWDIMXo//UjbTBpHvNKPVJYHw47D1 JBBL/uQABgItYVDr+uITr2zxFo3P2jnONMHmYgtcqAarg7/jZ8RMGKcJDpHJApAJWH71 sdmqEtLuGH3irCLnYCXAlnziVnGcoeNaa9NuAOsRhd8PRGRotDDOwWlgQrDiEoXpMssK DmTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from; bh=B0mefOxWiA5LRCG99ULN0EmMktTy7PgNVAbitvzaMDM=; b=SvHe2AcYZ00ITnjbDC6o0X2VS+zZNOVe8AmheyQIUZcgRCrtteHMLQ2hOKqRBxuoPt myNhowlqjBMxPWiKF+o0VtpRDPIUz5qk4OdK3thEDIMbwo6O2SjF4P7bDKIy4iKcWcXK wGk1PPhsizASPUmXagjjfGRBlJSG743tw+0mewx4vqApj3+oUQ57MXXi5JOCf5hZ8bXG t4t+MFT0c1+EAPpn0Ge3rua/C2JQ7fdyYrz8Xvuk+Y6wO6MZi3Vg02EFI0Yyb8AlbLsG 6SyYYSllSAUMpYiT0QXfPOlmWStEw5aNQasbmYG118NQZEkoD4Nf8RzA/Y9nuOXlv7uX nfkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s36si19218912pld.46.2019.01.23.03.03.44; Wed, 23 Jan 2019 03:04:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727334AbfAWLBm (ORCPT + 99 others); Wed, 23 Jan 2019 06:01:42 -0500 Received: from smtp2207-205.mail.aliyun.com ([121.197.207.205]:44882 "EHLO smtp2207-205.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726207AbfAWLBl (ORCPT ); Wed, 23 Jan 2019 06:01:41 -0500 X-Alimail-AntiSpam: AC=CONTINUE;BC=0.07436312|-1;CH=green;FP=0|0|0|0|0|-1|-1|-1;HT=e02c03301;MF=liaoweixiong@allwinnertech.com;NM=1;PH=DS;RN=17;RT=17;SR=0;TI=SMTPD_---.Dpcewgu_1548241289; Received: from PC-liaoweixiong.allwinnertech.com(mailfrom:liaoweixiong@allwinnertech.com fp:SMTPD_---.Dpcewgu_1548241289) by smtp.aliyun-inc.com(10.147.42.198); Wed, 23 Jan 2019 19:01:36 +0800 From: liaoweixiong To: Kees Cook , Anton Vorontsov , Colin Cross , Tony Luck , Jonathan Corbet , Rob Herring , Mark Rutland , Mauro Carvalho Chehab , Greg Kroah-Hartman , "David S. Miller" , Andrew Morton , Nicolas Ferre , Arnd Bergmann Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, liaoweixiong Subject: [RFC v6 0/4] pstore/block: new support logger for block devices Date: Wed, 23 Jan 2019 19:00:56 +0800 Message-Id: <1548241260-4679-1-git-send-email-liaoweixiong@allwinnertech.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Why should we need pstore_block? 1. Most embedded intelligent equipment have no persistent ram, which increases costs. We perfer to cheaper solutions, like block devices. In fast, there is already a sample for block device logger in driver MTD (drivers/mtd/mtdoops.c). 2. Do not any equipment have battery, which means that it lost all data on general ram if power failure. Pstore has little to do for these equipments. [PATCH v6] On patch 1: 1. Fix according to email from Kees Cook, including spelling mistakes, explicit overflow test, none of the zeroing etc. 2. Do not recover data but metadata of dmesg when panic. 3. No need to take recovery when do erase. 4. Do not use "blkoops" for blkzone any more because "blkoops" is used for other module now.(rename blkbuf to blkoops) On patch 2: 1. Rename blkbuf to blkoops. 2. Add Kconfig/device tree/module parameters settings for blkoops. 3. Add document for device tree. On patch 3: 1. Blkoops support pmsg. 2. Fix description for new version patch. On patch 4: 1. Fix description for new version patch. [PATCH v5] On patch 1: 1. rename pstore/rom to pstore/blk 2. Do not allocate any memory in the write path of panic. So, use local array instead in function romz_recover_dmesg_meta. 3. Add C header file "linux/fs.h" to fix implicit declaration of function 'filp_open','kernel_read'... On patch 3: 1. If panic, do not recover pmsg but flush if it is dirty. 2. Fix erase pmsg failed. On patch 4: 1. Create a document for pstore/blk [PATCH v4] On patch 1: 1. Fix always true condition '(--i >= 0) => (0-u32max >= 0)' in function romz_init_zones by defining variable i to 'int' rahter than 'unsigned int'. 2. To make codes more easily to read, we use macro READ_NEXT_ZONE for return value of romz_dmesg_read if it need to read next zone. Moveover, we assign READ_NEXT_ZONE -1024 rather than 0. 3. Add 'FLUSH_META' to 'enum romz_flush_mode' and rename 'NOT_FLUSH' to 'FLUSH_NONE' 4. Function romz_zone_write work badly with FLUSH_PART mode as badly address and offset to write. On patch 3: NEW SUPPORT psmg for pstore_rom. [PATCH v3] On patch 1: Fix build as module error for undefined 'vfs_read' and 'vfs_write' Both of 'vfs_read' and 'vfs_write' haven't be exproted yet, so we use 'kernel_read' and 'kernel_write' instead. [PATCH v2] On patch 1: Fix build as module error for redefinition of 'romz_unregister' and 'romz_register' [PATCH v1] On patch 1: Core codes of pstore_rom, which works well on allwinner(sunxi) platform. On patch 2: A sample for pstore_rom, using general ram rather than block device. liaoweixiong (4): pstore/blk: new support logger for block devices pstore/blk: add blkoops for pstore_blk pstore/blk: support pmsg for pstore block Documentation: pstore/blk: create document for pstore_blk Documentation/admin-guide/pstore-block.rst | 227 ++++ .../devicetree/bindings/pstore-block/blkoops.txt | 32 + MAINTAINERS | 4 +- fs/pstore/Kconfig | 128 +++ fs/pstore/Makefile | 5 + fs/pstore/blkoops.c | 250 +++++ fs/pstore/blkzone.c | 1163 ++++++++++++++++++++ include/linux/pstore_blk.h | 62 ++ 8 files changed, 1870 insertions(+), 1 deletion(-) create mode 100644 Documentation/admin-guide/pstore-block.rst create mode 100644 Documentation/devicetree/bindings/pstore-block/blkoops.txt create mode 100644 fs/pstore/blkoops.c create mode 100644 fs/pstore/blkzone.c create mode 100644 include/linux/pstore_blk.h -- 1.9.1