Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] gcov: no need to check return value of debugfs_create
 functions
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org
References: <20190122152151.16139-49-gregkh@linuxfoundation.org>
From:   Peter Oberparleiter <oberpar@linux.ibm.com>
Date:   Wed, 23 Jan 2019 14:22:33 +0100
MIME-Version: 1.0
In-Reply-To: <20190122152151.16139-49-gregkh@linuxfoundation.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Message-Id: <b277b33b-bcc0-c1c5-52d6-9e1580531df3@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 22.01.2019 16:21, Greg Kroah-Hartman wrote:
> When calling debugfs functions, there is no need to ever check the
> return value.  The function can work or not, but the code logic should
> never do something different based on this.
> 
> Also delete the dentry variable as it is never needed.
> 
> Cc: Peter Oberparleiter <oberpar@linux.ibm.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
>  kernel/gcov/fs.c | 22 ++--------------------
>  1 file changed, 2 insertions(+), 20 deletions(-)

Acked-by: Peter Oberparleiter <oberpar@linux.ibm.com>

Compile test was successful, but the patch introduces a compile warning.
Could you merge the attached patch?

8<===
From: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Subject: [PATCH] gcov: Fix compiler warning

Fix compiler warning when compiling with CONFIG_GCOV_KERNEL=y:

  CC      kernel/gcov/fs.o
kernel/gcov/fs.c: In function ‘gcov_fs_init’:
kernel/gcov/fs.c:756:6: warning: unused variable ‘rc’ [-Wunused-variable]
  int rc = -EIO;
      ^~

Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
---
 kernel/gcov/fs.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/gcov/fs.c b/kernel/gcov/fs.c
index aa9a49f72024..e5eb5ea7ea59 100644
--- a/kernel/gcov/fs.c
+++ b/kernel/gcov/fs.c
@@ -753,8 +753,6 @@ void gcov_event(enum gcov_action action, struct gcov_info *info)
 /* Create debugfs entries. */
 static __init int gcov_fs_init(void)
 {
-	int rc = -EIO;
-
 	init_node(&root_node, NULL, NULL, NULL);
 	/*
 	 * /sys/kernel/debug/gcov will be parent for the reset control file
-- 
2.17.0

-- 
Peter Oberparleiter
Linux on Z Development - IBM Germany