Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp836810imu; Wed, 23 Jan 2019 06:34:53 -0800 (PST) X-Google-Smtp-Source: ALg8bN6WQEXetB6vknWxT2Y7uYwzGknnfODHNkFp7RHMsVcyjeQZ0HZ4hdnxYFPipZR+hejHrp2b X-Received: by 2002:a63:f30d:: with SMTP id l13mr2138392pgh.399.1548254093230; Wed, 23 Jan 2019 06:34:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548254093; cv=none; d=google.com; s=arc-20160816; b=WhQ7q34qp8JegdAHIzG5N4U3H3hZsi5aqYCn/LwobWyBGD8B6r5fN0nY87wKkQKDIS AO7tJ0U+uj9cDIiIBw64raZk4AtSZbfeSidkId9e9X+hR49r84jend1ioQheQFoR6SoK fk1N+qXb3/8QhoUTnRuwd1l48W7Jd7XQPscQz+P4PARClATx4N6ol7h4nnU7DgH4HNRl 471GDne/7riQ1xGgAUhmISAgwm2cekPLLXSU8CONMkmm+TvkEEh1k8JfxsrzbUa5eQ1M zPOB+DUeJIyM2nUkBtPJC5G5l74XlJmQzQe3tSVvSBDa+bPHkX8VD3hSbrEL5KueuTlZ vGYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=BirMFQBK4A1zQKNItynvMUQpqqBrS3+mniVqawMRSJA=; b=u5VJURNm+NC1zPuvgi7FkDoZy1tvBNjz8ISjKuIUHToUBbbfJ63VDUzuZ+uX6CLHM6 TYXsaiNQOfCac8AIPUYqTnKvD96tjSvLQnyt30UQ0LCcMgPd9sYT40HaRGrpnSfCr0QJ yEExxEmN6j0c6tm36rJ3BigUPbXLuqvpFNqy5ov1kNnXRR7oRqbPxJtvvsQjOxpaGUss QFba2/tsfhJ57MJQ1MKlpnPfMhELgTvaIqh9Yi0ZbhfL+KdKykWmbOfRuWH8TPolSajE WhFJZmZjEV4C2c9t/P4i3ywiQhlKLQ6pksfz3KvfHuL1hNVHRArdw2e3YzcYPY7Z/JaG f5nQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h20si18954469pgm.366.2019.01.23.06.34.37; Wed, 23 Jan 2019 06:34:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727048AbfAWObr (ORCPT + 99 others); Wed, 23 Jan 2019 09:31:47 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:35178 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726236AbfAWObr (ORCPT ); Wed, 23 Jan 2019 09:31:47 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id E073367EF03EA0CFB764; Wed, 23 Jan 2019 22:31:43 +0800 (CST) Received: from localhost (10.177.31.96) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.408.0; Wed, 23 Jan 2019 22:31:37 +0800 From: YueHaibing To: , , CC: , , YueHaibing Subject: [PATCH -next] usb: gadget: Remove dead branch code Date: Wed, 23 Jan 2019 22:31:36 +0800 Message-ID: <20190123143136.15704-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.177.31.96] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 'num' is a u8 variable, it never greater than 255, So the if branch is dead code and can be removed. Signed-off-by: YueHaibing --- drivers/usb/gadget/function/uvc_configfs.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/usb/gadget/function/uvc_configfs.c b/drivers/usb/gadget/function/uvc_configfs.c index bc1e2af..8fe85cb 100644 --- a/drivers/usb/gadget/function/uvc_configfs.c +++ b/drivers/usb/gadget/function/uvc_configfs.c @@ -1570,10 +1570,6 @@ uvcg_uncompressed_##cname##_store(struct config_item *item, \ if (ret) \ goto end; \ \ - if (num > 255) { \ - ret = -EINVAL; \ - goto end; \ - } \ u->desc.aname = num; \ ret = len; \ end: \ @@ -1767,10 +1763,6 @@ uvcg_mjpeg_##cname##_store(struct config_item *item, \ if (ret) \ goto end; \ \ - if (num > 255) { \ - ret = -EINVAL; \ - goto end; \ - } \ u->desc.aname = num; \ ret = len; \ end: \ -- 2.7.0