Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190123084912.13376-1-yuehaibing@huawei.com> <f1c0c8d3-49de-bf5d-32c1-1717ea238107@ti.com>
In-Reply-To: <f1c0c8d3-49de-bf5d-32c1-1717ea238107@ti.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Wed, 23 Jan 2019 17:12:58 +0100
Message-ID: <CAMpxmJWMMukZ4XPcpb55EGNKoXjmaOFW9SVAT=0SxhHvtkTrzQ@mail.gmail.com>
Subject: Re: [PATCH -next] gpio: davinci: drop pointless static qualifier
To:     Keerthy <j-keerthy@ti.com>
Cc:     YueHaibing <yuehaibing@huawei.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        LKML <linux-kernel@vger.kernel.org>,
        linux-gpio <linux-gpio@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=C5=9Br., 23 sty 2019 o 11:32 Keerthy <j-keerthy@ti.com> napisa=C5=82(a):
>
> On 23/01/19 2:19 PM, YueHaibing wrote:
> > There is no need to have the 'gpio_unbanked' variable static since
> > new value always be assigned before use it.
>
> Acked-by: Keerthy <j-keerthy@ti.com>
>
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >  drivers/gpio/gpio-davinci.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> > index bdb29e5..f250454 100644
> > --- a/drivers/gpio/gpio-davinci.c
> > +++ b/drivers/gpio/gpio-davinci.c
> > @@ -465,7 +465,7 @@ static const struct irq_domain_ops davinci_gpio_irq=
_ops =3D {
> >
> >  static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
> >  {
> > -     static struct irq_chip_type gpio_unbanked;
> > +     struct irq_chip_type gpio_unbanked;
> >
> >       gpio_unbanked =3D *irq_data_get_chip_type(irq_get_irq_data(irq));
> >
> > @@ -474,7 +474,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(u=
nsigned int irq)
> >
> >  static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
> >  {
> > -     static struct irq_chip gpio_unbanked;
> > +     struct irq_chip gpio_unbanked;
> >
> >       gpio_unbanked =3D *irq_get_chip(irq);
> >       return &gpio_unbanked;
> >
>

Good catch! While it would probably never result in a race condition
as it is always called from probe(), it's still wrong so patch
applied.

Thanks,
Bart