Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp973180imu; Wed, 23 Jan 2019 08:45:45 -0800 (PST) X-Google-Smtp-Source: ALg8bN5RXOnOr3D4jcBI/3AIkVA6cLQMep2tnUWMHhsXlK7fMR4QWcQw3c+gS6iYbgLWdafY9c+4 X-Received: by 2002:a63:2b82:: with SMTP id r124mr2542781pgr.300.1548261945288; Wed, 23 Jan 2019 08:45:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548261945; cv=none; d=google.com; s=arc-20160816; b=UMNiHVWJBRq9J3PJZXObfvTKW4RAn1ppbfJanWZnqyx2JyRefsGwERdW2To6pJw1Ug 2DbU4+umKE366v14D425Czirdwoty2+BtdClH4puRncE3gLy7EdDASYeKQGk+6dsnRJn VN2gyI6LHgEusbDismdUc6kSZ7J4PKURMMH3Ngkfxfsj6S6G72y1mi+iPfRD8DUNxWMa c2cOt8NqpzFIzY2LxQl2q8NUQ1b+wS/p8C/hNV/kuWupZizcNXTj9FWzKjRn4F4z7ju0 fJYp308bXOsxZ/eYnT/pbZxJ6sH1+jdvftvLpH03f8LBG3GRgt4PJTAiJXEIlp7oyqBR bWzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=oiAFOjc5FbLfFQXqjJNjUKAKfvNAzajM3LME8VG6cDY=; b=gLU5FUr766I9T/VwxfOszrRyNTVI0Nt/CT3Qd0oaBrIzggML0bp0tl2OjneSV+92X1 eU/Cx8LMVhO8r94Wjg3sTBPMSjU1iCRqalUDG5z5S6Zc2HI96A3+QHa66nE2FKEzS99T Kfn98TQl0GKCK5mEYh8Dq9+VrIbDW4x97Ff3U/PSGZzymZRG4PzJuEUiPLD8PYBJkoM+ yRZjO9EQ9qHY7B16VLmlh+6BsA11xbPW6EoVjLaZ3y/PvWgNrdcecKYSCPewdYoAcjlS Qo00r5xKgDvoV8d7n1gfH5fEWaIWiMLxuS5ZtydaCdHnvFKlROYDZ0LtOzM1zvVWUuaQ cLIg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CvAslK2h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l30si19404197plg.113.2019.01.23.08.45.28; Wed, 23 Jan 2019 08:45:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CvAslK2h; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726256AbfAWQmv (ORCPT + 99 others); Wed, 23 Jan 2019 11:42:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:41850 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726040AbfAWQmu (ORCPT ); Wed, 23 Jan 2019 11:42:50 -0500 Received: from [192.168.1.32] (cpe-70-114-128-244.austin.res.rr.com [70.114.128.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DD4922085A; Wed, 23 Jan 2019 16:42:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548261769; bh=S7vcW3mImUndz9C+WM9M7aDnWhBwkdXrL2f2dI5dlN8=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=CvAslK2hynhSzaujYgQGos2Du51G64NagurakIStgmMcVXcfcOLZIGuc/azOe65ya kHxPuvepep1li+K6REVTRpoHIujZr35qY1PLlfYWGwBDt1X34GZSSOheUSj+P7qcQu jzj0eNBfvGLAHsvi337u4aW3G5acRWwPb+AoUa1I= Subject: Re: [PATCHv1] firmware: intel_stratix10_service: add hardware dependency To: Alan Tull , Greg KH Cc: Richard Gong , linux-kernel , todd.riffel@intel.com, Richard Gong References: <1548258476-16821-1-git-send-email-richard.gong@linux.intel.com> <20190123160019.GB4764@kroah.com> From: Dinh Nguyen Openpgp: preference=signencrypt Autocrypt: addr=dinguyen@kernel.org; prefer-encrypt=mutual; keydata= mQINBFEnvWwBEAC44OQqJjuetSRuOpBMIk3HojL8dY1krl8T8GJjfgc/Gh97CfVbrqhV5yQ3 Sk/MW9mxO9KNvQCbZtthfn62YHmroNwipjZ6wKOMfKdtJR4+8JW/ShIJYnrMfwN8Wki6O+5a yPNNCeENHleV0FLVXw3aACxOcjEzGJHYmg4UC+56rfoxPEhKF6aGBTV5aGKMtQy77ywuqt12 c+hlRXHODmXdIeT2V4/u/AsFNAq6UFUEvHrVj+dMIyv2VhjRvkcESIGnG12ifPdU7v/+wom/ smtfOAGojgTCqpwd0Ay2xFzgGnSCIFRHp0I/OJqhUcwAYEAdgHSBVwiyTQx2jP+eDu3Q0jI3 K/x5qrhZ7lj8MmJPJWQOSYC4fYSse2oVO+2msoMTvMi3+Jy8k+QNH8LhB6agq7wTgF2jodwO yij5BRRIKttp4U62yUgfwbQtEUvatkaBQlG3qSerOzcdjSb4nhRPxasRqNbgkBfs7kqH02qU LOAXJf+y9Y1o6Nk9YCqb5EprDcKCqg2c8hUya8BYqo7y+0NkBU30mpzhaJXncbCMz3CQZYgV 1TR0qEzMv/QtoVuuPtWH9RCC83J5IYw1uFUG4RaoL7Z03fJhxGiXx3/r5Kr/hC9eMl2he6vH 8rrEpGGDm/mwZOEoG5D758WQHLGH4dTAATg0+ZzFHWBbSnNaSQARAQABtCFEaW5oIE5ndXll biA8ZGluZ3V5ZW5Aa2VybmVsLm9yZz6JAjgEEwECACIFAlbG5oQCGwMGCwkIBwMCBhUIAgkK CwQWAgMBAh4BAheAAAoJEBmUBAuBoyj0fIgQAICrZ2ceRWpkZv1UPM/6hBkWwOo3YkzSQwL+ AH15hf9xx0D5mvzEtZ97ZoD0sAuB+aVIFwolet+nw49Q8HA3E/3j0DT7sIAqJpcPx3za+kKT twuQ4NkQTTi4q5WCpA5b6e2qzIynB50b3FA6bCjJinN06PxhdOixJGv1qDDmJ01fq2lA7/PL cny/1PIo6PVMWo9nf77L6iXVy8sK/d30pa1pjhMivfenIleIPYhWN1ZdRAkH39ReDxdqjQXN NHanNtsnoCPFsqeCLmuUwcG+XSTo/gEM6l2sdoMF4qSkD4DdrVf5rsOyN4KJAY9Uqytn4781 n6l1NAQSRr0LPT5r6xdQ3YXIbwUfrBWh2nDPm0tihuHoH0CfyJMrFupSmjrKXF84F3cq0DzC yasTWUKyW/YURbWeGMpQH3ioDLvBn0H3AlVoSloaRzPudQ6mP4O8mY0DZQASGf6leM82V3t0 Gw8MxY9tIiowY7Yl2bHqXCorPlcEYXjzBP32UOxIK7y7AQ1JQkcv6pZ0/6lX6hMshzi9Ydw0 m8USfFRZb48gsp039gODbSMCQ2NfxBEyUPw1O9nertCMbIO/0bHKkP9aiHwg3BPwm3YL1UvM ngbze/8cyjg9pW3Eu1QAzMQHYkT1iiEjJ8fTssqDLjgJyp/I3YHYUuAf3i8SlcZTusIwSqnD uQINBFEnvWwBEADZqma4LI+vMqJYe15fxnX8ANw+ZuDeYHy17VXqQ7dA7n8E827ndnoXoBKB 0n7smz1C0I9StarHQPYTUciMLsaUpedEfpYgqLa7eRLFPvk/cVXxmY8Pk+aO8zHafr8yrFB1 cYHO3Ld8d/DvF2DuC3iqzmgXzaRQhvQZvJ513nveCa2zTPPCj5w4f/Qkq8OgCz9fOrf/CseM xcP3Jssyf8qTZ4CTt1L6McRZPA/oFNTTgS/KA22PMMP9i8E6dF0Nsj0MN0R7261161PqfA9h 5c+BBzKZ6IHvmfwY+Fb0AgbqegOV8H/wQYCltPJHeA5y1kc/rqplw5I5d8Q6B29p0xxXSfaP UQ/qmXUkNQPNhsMnlL3wRoCol60IADiEyDJHVZRIl6U2K54LyYE1vkf14JM670FsUH608Hmk 30FG8bxax9i+8Muda9ok/KR4Z/QPQukmHIN9jVP1r1C/aAEvjQ2PK9aqrlXCKKenQzZ8qbeC rOTXSuJgWmWnPWzDrMxyEyy+e84bm+3/uPhZjjrNiaTzHHSRnF2ffJigu9fDKAwSof6SwbeH eZcIM4a9Dy+Ue0REaAqFacktlfELeu1LVzMRvpIfPua8izTUmACTgz2kltTaeSxAXZwIziwY prPU3cfnAjqxFHO2TwEpaQOMf8SH9BSAaCXArjfurOF+Pi3lKwARAQABiQIfBBgBAgAJBQJR J71sAhsMAAoJEBmUBAuBoyj0MnIQAI+bcNsfTNltf5AbMJptDgzISZJrYCXuzOgv4+d1CubD 83s0k6VJgsiCIEpvELQJsr58xB6l+o3yTBZRo/LViNLk0jF4CmCdXWjTyaQAIceEdlaeeTGH d5GqAud9rv9q1ERHTcvmoEX6pwv3m66ANK/dHdBV97vXacl+BjQ71aRiAiAFySbJXnqj+hZQ K8TCI/6TOtWJ9aicgiKpmh/sGmdeJCwZ90nxISvkxDXLEmJ1prvbGc74FGNVNTW4mmuNqj/p oNr0iHan8hjPNXwoyLNCtj3I5tBmiHZcOiHDUufHDyKQcsKsKI8kqW3pJlDSACeNpKkrjrib 3KLQHSEhTQCt3ZUDf5xNPnFHOnBjQuGkumlmhkgD5RVguki39AP2BQYp/mdk1NCRQxz5PR1B 2w0QaTgPY24chY9PICcMw+VeEgHZJAhuARKglxiYj9szirPd2kv4CFu2w6a5HNMdVT+i5Hov cJEJNezizexE0dVclt9OS2U9Xwb3VOjs1ITMEYUf8T1j83iiCCFuXqH4U3Eji0nDEiEN5Ac0 Jn/EGOBG2qGyKZ4uOec9j5ABF7J6hyO7H6LJaX5bLtp0Z7wUbyVaR4UIGdIOchNgNQk4stfm JiyuXyoFl/1ihREfvUG/e7+VAAoOBnMjitE5/qUERDoEkkuQkMcAHyEyd+XZMyXY Message-ID: Date: Wed, 23 Jan 2019 10:42:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/23/19 10:37 AM, Alan Tull wrote: > On Wed, Jan 23, 2019 at 10:00 AM Greg KH wrote: > > Hi Greg, > >> >> On Wed, Jan 23, 2019 at 09:47:56AM -0600, richard.gong@linux.intel.com wrote: >>> From: Richard Gong >>> >>> Add a Kconfig dependency to ensure Intel Stratix10 service layer driver >>> can be built only on the platform that supports it. >>> >>> Signed-off-by: Richard Gong >>> --- >>> drivers/firmware/Kconfig | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig >>> index f754578..cac16c4 100644 >>> --- a/drivers/firmware/Kconfig >>> +++ b/drivers/firmware/Kconfig >>> @@ -218,7 +218,7 @@ config FW_CFG_SYSFS_CMDLINE >>> >>> config INTEL_STRATIX10_SERVICE >>> tristate "Intel Stratix10 Service Layer" >>> - depends on HAVE_ARM_SMCCC >>> + depends on ARCH_STRATIX10 && HAVE_ARM_SMCCC >> >> That's lame, what about building for testing? > > Do you mean this instead? > > depends on (ARCH_STRATIX10 && HAVE_ARM_SMCCC) || COMPILE_TEST > >> >> And is this needed now, for 5.0-final, or can it wait for 5.1? > > This change will reduce kernel size for most arm64. It can go into > whichever kernel. We can resubmit allowing for COMPILE_TEST. > I don't see how this is true? ARM64 has a single defconfig and ARCH_STRATIX10 is included in that defconfig. I don't see how adding this dependency will reduce the kernel size for most arm64? Dinh