Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 23 Jan 2019 17:43:17 +0100
From:   Greg KH <gregkh@linuxfoundation.org>
To:     Alan Tull <atull@kernel.org>
Cc:     Richard Gong <richard.gong@linux.intel.com>,
        Dinh Nguyen <dinguyen@kernel.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        todd.riffel@intel.com, Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv1] firmware: intel_stratix10_service: add hardware
 dependency
Message-ID: <20190123164317.GA16162@kroah.com>
References: <1548258476-16821-1-git-send-email-richard.gong@linux.intel.com>
 <20190123160019.GB4764@kroah.com>
 <CANk1AXR2K5j6iU1y8GGn_8agOUY6ca8xKXPrFGT5Ht6_La7VrA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANk1AXR2K5j6iU1y8GGn_8agOUY6ca8xKXPrFGT5Ht6_La7VrA@mail.gmail.com>
User-Agent: Mutt/1.11.2 (2019-01-07)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 23, 2019 at 10:37:07AM -0600, Alan Tull wrote:
> On Wed, Jan 23, 2019 at 10:00 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> 
> Hi Greg,
> 
> >
> > On Wed, Jan 23, 2019 at 09:47:56AM -0600, richard.gong@linux.intel.com wrote:
> > > From: Richard Gong <richard.gong@intel.com>
> > >
> > > Add a Kconfig dependency to ensure Intel Stratix10 service layer driver
> > > can be built only on the platform that supports it.
> > >
> > > Signed-off-by: Richard Gong <richard.gong@intel.com>
> > > ---
> > >  drivers/firmware/Kconfig | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> > > index f754578..cac16c4 100644
> > > --- a/drivers/firmware/Kconfig
> > > +++ b/drivers/firmware/Kconfig
> > > @@ -218,7 +218,7 @@ config FW_CFG_SYSFS_CMDLINE
> > >
> > >  config INTEL_STRATIX10_SERVICE
> > >       tristate "Intel Stratix10 Service Layer"
> > > -     depends on HAVE_ARM_SMCCC
> > > +     depends on ARCH_STRATIX10 && HAVE_ARM_SMCCC
> >
> > That's lame, what about building for testing?
> 
> Do you mean this instead?
> 
> depends on (ARCH_STRATIX10 && HAVE_ARM_SMCCC) || COMPILE_TEST

Yes, that would be better, right?

> >
> > And is this needed now, for 5.0-final, or can it wait for 5.1?
> 
> This change will reduce kernel size for most arm64.  It can go into
> whichever kernel.  We can resubmit allowing for COMPILE_TEST.

So it's not fixing a bug, but rather just allowing you to shrink an
image?  If so, then 5.1 is good.

Please resubmit, after making sure it doesn't break the normal builds :)

thanks,

greg k-h