Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp973264imu; Wed, 23 Jan 2019 08:45:51 -0800 (PST) X-Google-Smtp-Source: ALg8bN7ymadV3jznNuiXCgu2RNW4tHZAVKM08ejwR/dBSKCg5v9HeyaMQrxn/Fwa5ff6NWwqMJoO X-Received: by 2002:a62:c21c:: with SMTP id l28mr2634286pfg.74.1548261951449; Wed, 23 Jan 2019 08:45:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548261951; cv=none; d=google.com; s=arc-20160816; b=05soqJR35XJrBjWFoxJnmH/52OUTZWN6nZZdp5ZFp+5HwyQKNSwf7zF65GW2/1IgSo 2T/cxuktEQ6xCuxp0ey2AlMd1krgXIRvOupovLH1sIfC7OaPXozyM7T9KR+PK4H/DUX8 dgDP5GUDBbz0ojPv/oqtCQXBsF77Hi22UBFPn6fJtYlV8cmBHRMxZUynFvNhTQd86kzx lpNh5yBRyXSTQ5sB9CO16Bx20gAXX/CohZZxH2gVhTbgEvZlnWq51T8UyxnNxAaF1IKx 620j6aRKcxPj93PzVMPE6z1oXRDss2zpjGnGH+YNeFcXvOV2NHhKavkqbcrwQnBiTEpR GjgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=2QHY9juKJgLOrA4Z1mVQxM+8XSTJC1Prw1Ptf0wNwDg=; b=I2TzS/KMLyVC27ai84RyTVFhe/nXoZoIIN0asd5l7wAf2hp1wRfxeS+lWqDC9Ki51g qbZD6y/rhH8cMKVwHmqh3JpcHk/EpHVJqGy7ZZ8O7q28w2hgHn2zuPsEHrzdsZ6iJxB7 AJBTtJnxZXauW16/ilrsmZgqq+4pDXEWcnKiD4xLh0sPZ1a+OnSPiWdSY6tCHZVmdURB W08ZL8ALuK20owJpTmmNmq1F6iKijp6soY2Xfr2alYNdQZkM7t0yBStPhkoRJMMeZGpu bIHikax7uOBjuCJ8gOabo3SWPJou/IhGm3ksktsX6QRqdRxTK4+vAdbTPYUiJV8MGVXM j94A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CuMVNilT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x64si17906115pfx.87.2019.01.23.08.45.36; Wed, 23 Jan 2019 08:45:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=CuMVNilT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726311AbfAWQnU (ORCPT + 99 others); Wed, 23 Jan 2019 11:43:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:42250 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfAWQnU (ORCPT ); Wed, 23 Jan 2019 11:43:20 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 935F32085A; Wed, 23 Jan 2019 16:43:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548261800; bh=98pFJQTh12NEcRLdIk+cctLbJ0lwG4xknUep+F6JcLQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CuMVNilTbZjBubpFThrlDSzqmOlo2i0qfTBAmAwfwsri/wDRcqAbI/O3SbdqmyZIi +t7WRb4IEqJfRQAktdRm3xmE7RxPykmI8Hxv0IcPkCq8TW29l7Va2PxlcH/fBpu8Y1 1mbMWlJqcdc52/1X131dA4aDeN9dF7jH4rfOd9VY= Date: Wed, 23 Jan 2019 17:43:17 +0100 From: Greg KH To: Alan Tull Cc: Richard Gong , Dinh Nguyen , linux-kernel , todd.riffel@intel.com, Richard Gong Subject: Re: [PATCHv1] firmware: intel_stratix10_service: add hardware dependency Message-ID: <20190123164317.GA16162@kroah.com> References: <1548258476-16821-1-git-send-email-richard.gong@linux.intel.com> <20190123160019.GB4764@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 23, 2019 at 10:37:07AM -0600, Alan Tull wrote: > On Wed, Jan 23, 2019 at 10:00 AM Greg KH wrote: > > Hi Greg, > > > > > On Wed, Jan 23, 2019 at 09:47:56AM -0600, richard.gong@linux.intel.com wrote: > > > From: Richard Gong > > > > > > Add a Kconfig dependency to ensure Intel Stratix10 service layer driver > > > can be built only on the platform that supports it. > > > > > > Signed-off-by: Richard Gong > > > --- > > > drivers/firmware/Kconfig | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > > > index f754578..cac16c4 100644 > > > --- a/drivers/firmware/Kconfig > > > +++ b/drivers/firmware/Kconfig > > > @@ -218,7 +218,7 @@ config FW_CFG_SYSFS_CMDLINE > > > > > > config INTEL_STRATIX10_SERVICE > > > tristate "Intel Stratix10 Service Layer" > > > - depends on HAVE_ARM_SMCCC > > > + depends on ARCH_STRATIX10 && HAVE_ARM_SMCCC > > > > That's lame, what about building for testing? > > Do you mean this instead? > > depends on (ARCH_STRATIX10 && HAVE_ARM_SMCCC) || COMPILE_TEST Yes, that would be better, right? > > > > And is this needed now, for 5.0-final, or can it wait for 5.1? > > This change will reduce kernel size for most arm64. It can go into > whichever kernel. We can resubmit allowing for COMPILE_TEST. So it's not fixing a bug, but rather just allowing you to shrink an image? If so, then 5.1 is good. Please resubmit, after making sure it doesn't break the normal builds :) thanks, greg k-h