Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net-next] intel: Mark expected switch fall-throughs
To:     jeffrey.t.kirsher@intel.com,
        "David S. Miller" <davem@davemloft.net>
Cc:     intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20190123074849.GA24230@embeddedor>
 <e356e64d3267bbca1cfa0373b7ce965edaf159bd.camel@intel.com>
From:   "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Openpgp: preference=signencrypt
Message-ID: <368769c1-bb6c-b137-14c4-ef0ade488c2e@embeddedor.com>
Date:   Wed, 23 Jan 2019 11:11:39 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <e356e64d3267bbca1cfa0373b7ce965edaf159bd.camel@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Jeffrey,

On 1/23/19 11:04 AM, Jeff Kirsher wrote:
> On Wed, 2019-01-23 at 01:48 -0600, Gustavo A. R. Silva wrote:
>> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>> where we are expecting to fall through.
>>
>> This patch fixes the following warnings:
>>
>> drivers/net/ethernet/intel/igb/e1000_82575.c:636:6: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>> drivers/net/ethernet/intel/igb/igb_main.c:6710:6: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>> drivers/net/ethernet/intel/i40e/i40e_xsk.c:237:3: warning: this
>> statement may fall through [-Wimplicit-fallthrough=]
>>
>> Warning level 3 was used: -Wimplicit-fallthrough=3
>>
>> This patch is part of the ongoing efforts to enabling
>> -Wimplicit-fallthrough.
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>> ---
>>  drivers/net/ethernet/intel/i40e/i40e_xsk.c   | 3 ++-
>>  drivers/net/ethernet/intel/igb/e1000_82575.c | 2 +-
>>  drivers/net/ethernet/intel/igb/igb_main.c    | 2 +-
>>  3 files changed, 4 insertions(+), 3 deletions(-)
> 
> NAK on the igb changes.  There is already a "fall through" code comment
> which is fine, adding a hyphen does not make the comment any more
> readable.
> 

Those comments are not fine. They trigger the warnings I mention in the
commit log. With this patch such warnings are fixed.

Notice that warning level 3 was used: -Wimplicit-fallthrough=3

Thanks
--
Gustavo