Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1049619imu; Wed, 23 Jan 2019 09:56:37 -0800 (PST) X-Google-Smtp-Source: ALg8bN4Wjt1CjxhubEMDCXnpKBcuRhLHO7Ola0LSRjgHZ8V7sWff2Qwblz1ERkZ2aZqO6+aVUDIU X-Received: by 2002:a17:902:5066:: with SMTP id f35mr3187581plh.78.1548266197416; Wed, 23 Jan 2019 09:56:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548266197; cv=none; d=google.com; s=arc-20160816; b=VGY0sv/MczaxDwEGpOzLfTCEE4Koeb+nHpc2ag773rOCeulCupbE8ElkwBgDsj/NMM 4DAwLWpPh7I8FCeaqJ/azDSKHgBykN/t7qv5pp/VMSilbiR8j3yy8tF1f8Q5IUEUUn/v 6nZZS9JH5bsCKu0FWTxi/oWHfF8FSfoRgKOUPFfBGoztJv1CTD3Z5abbKWDQb9+ncCoy bvlMaTFstZ/s6lchf9p5jl224uWyNjhISbyylE8Uk6S77kEu/AoT9Z29kYXdrZcRuJSs P3z+ZOd7r+pjhMTBFZQsRN0p9JDHH2CZZa4Cwb1rsnuTTl5RKeGvNchMRxV1cGrUJEHU nzPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=L+jSxpsRKVFTQSBTm58FgxKg9xBb41vnDraPIuL95QY=; b=ZIUFN/BsrBuYM16lBR677CH1GL9ZiUN9f53hfHvY47+KEdJQkWoeSC9fpKHn0WPI0O UNM8PcI59JdhB0oY5Lcztk83J8oHsy9i+E9ZcRBSCsWjgMxMK7BCPaHgVGpGyInSf/M2 FFdohNjaAcXM6T+kgMqft3VJ3rntzvJlnZ1QjCEETYdulZGTisOFRra5Myy9OJhS0VRa 8UYJd4/WVdyBve3IuE2eNposWb2ZMvGpbPKcUzn4db8rkS9QyXsa+S8RlmakYQr6pG2b 3aoU/LCDzeCJxfoDfDtSSZrxtEdMVvADTtG8pXH6mYx04CN9Nx0729FfTW7pUcWr2zz5 0OWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=NT5prtVz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m11si20717428pla.436.2019.01.23.09.56.22; Wed, 23 Jan 2019 09:56:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=NT5prtVz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726192AbfAWR4Q (ORCPT + 99 others); Wed, 23 Jan 2019 12:56:16 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:43074 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725871AbfAWR4Q (ORCPT ); Wed, 23 Jan 2019 12:56:16 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L+jSxpsRKVFTQSBTm58FgxKg9xBb41vnDraPIuL95QY=; b=NT5prtVziUBY3SF6H8AB6fjZz DytlUdgUBaqJYNumUI0bD/zCAEn190X4hfnsEEbmpbEWZhozD2ojQgwPbU6+MDtpH5U4UbIGe2dp7 Ff04RCEWu6vv1m6/G6wOgmBfq6P+wz0MdYlvRWbSraMJ+kCX1QbuEFYrD9UhSb7vfPdOc=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gmMl1-0006pN-1d; Wed, 23 Jan 2019 17:56:11 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 874FE1127ABA; Wed, 23 Jan 2019 17:56:09 +0000 (GMT) Date: Wed, 23 Jan 2019 17:56:09 +0000 From: Mark Brown To: kernel@martin.sperl.org Cc: Jon Hunter , linux-tegra , Linux Kernel Mailing List , linux-spi@vger.kernel.org Subject: Re: Regression: spi: core: avoid waking pump thread from spi_sync instead run teardown delayed Message-ID: <20190123175609.GG7503@sirena.org.uk> References: <7C4A5EFC-8235-40C8-96E1-E6020529DF72@martin.sperl.org> <20190115192619.GG5522@sirena.org.uk> <5D3256B1-5DAE-4E3F-9099-5425F4BCA304@martin.sperl.org> <20190115212539.GK5522@sirena.org.uk> <20190118191202.GG6260@sirena.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="reI/iBAAp9kzkmX4" Content-Disposition: inline In-Reply-To: X-Cookie: A couch is as good as a chair. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --reI/iBAAp9kzkmX4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sun, Jan 20, 2019 at 12:24:23PM +0100, kernel@martin.sperl.org wrote: > These kind of changes it requires are consuming a bit more time than > I was hoping for. Thanks for trying. > So maybe at this very moment the best is reverting the patch. Yes, I'm just going to do that for now. > As for the root cause of the regression: my guess is that spi-mem is > just not triggering a shutdown any more because of how message_pump works. I'm fairly sure that's what's going on but not been able to get my head around things enough to figure out what's going wrong yet. --reI/iBAAp9kzkmX4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlxIqrgACgkQJNaLcl1U h9Bo+Qf/R2oUsHmOVhx2IGtp1A69vFPJrwFZJXXjknp2y8JDfLjNHRs47+iFmpfJ 82jx8AMcTpYf4r4p3oAixX+huXXWP9sVD3jIx9jg4Wh7Nzjg/hqUhZlv0kPl2C0/ gdFt6vn5gW02ebILvzT8aHQAovButhjV5KObxCKfVJjLC7MSjrrZ66Nu1rIh7HEP 943ED4O4MSfCrkvbICr8QFEe+dNmlqnh/g1sfo8VMMuVQvizAi7axq7nm2keOMH5 owQCS7DkgQGa3q9ra8eYwVGwUCDSAt/gA9ccZ31zXmyX1U4FGkqzndh7t1aC0Ij+ qSH6CmkqaFC5X/Vl2ft/5RTPYJnOVA== =qwRN -----END PGP SIGNATURE----- --reI/iBAAp9kzkmX4--