Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1065280imu; Wed, 23 Jan 2019 10:09:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN7xRhLIm5bBi1C8aONDrXUPcqSrwgzZrhTlIEUxLbxyESvCzBJ3jHVsVBUhVNGr1IE3VywW X-Received: by 2002:a62:a510:: with SMTP id v16mr2962469pfm.18.1548266992321; Wed, 23 Jan 2019 10:09:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548266992; cv=none; d=google.com; s=arc-20160816; b=DOW1mV9waUlYkouQ05TRGSX29cGfyNHA23jvQ5v1lvMTuRrqwvzlDtw9XbvLj6AETv PjcQDgIb0OBiaHJVRnRS5k6zj8ub1dG0tO8ei8UiVvwB4UFSlDOC5wFQgb00XH/lDJi7 xn63JaMpcn19nMLGdeMp6OfvAJMasTlQiIVOe3ChNaY0fbBbKPj5r3EKmmp660ItclGL d+0DdHQtFq75VsmcWcAqxpZM11nvFCJzXYxZzNQeKhbeP6u8zDQ86BT4H5twlz9R4kFW HSQm2+T6jAiA3ijxEbPgWcZaqAZsHBjbsK0M93UrryQki0DUDAXfLbuItOrXoPhDW0Bo mIaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:openpgp:from:references:cc:to:subject; bh=r84SovdpA4iLNRoTO6A6P37F5ppKHCjC/Z2SyCsEY2M=; b=G82tCunNbp/E8JSJV1SbLszWKrzQzhkA4WSdtfFQo0MxlHSrbwix8OPxSk1vbspCx5 S9YT0Bn29RWAUrGPEdX2f87q8a6enF6H5/MEsAtb1QA0B8tY2cAvqbr4FCZEb6Q3EMeP AY0Hg+l6Cl3iaqKJbRmqQwNwxKIcOxC1rqLi/oIh0ZF/sleGMtbEeK6iLHQmRttRxbZV Z+WMHXL9JV1TPbdn/EyiX0qtGzCqs/I0/A9q01w54IEyFN1auMA55ZfdukwamPPSs4Bw +68q10M2lmZNJJjvvPgCDZDZB12CDtUTTR1GYVDl90VA6KvPI8agyuaiRg3rwq3Q9Gnl gsvA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w15si16915947plk.357.2019.01.23.10.09.35; Wed, 23 Jan 2019 10:09:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726364AbfAWSJK (ORCPT + 99 others); Wed, 23 Jan 2019 13:09:10 -0500 Received: from gateway22.websitewelcome.com ([192.185.46.234]:21000 "EHLO gateway22.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726281AbfAWSJJ (ORCPT ); Wed, 23 Jan 2019 13:09:09 -0500 Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway22.websitewelcome.com (Postfix) with ESMTP id B80E4816B for ; Wed, 23 Jan 2019 12:09:08 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id mMxYg9eicYTGMmMxYgs8vA; Wed, 23 Jan 2019 12:09:08 -0600 X-Authority-Reason: nr=8 Received: from [189.250.130.205] (port=50044 helo=[192.168.1.76]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gmMxY-000i3W-C2; Wed, 23 Jan 2019 12:09:08 -0600 Subject: Re: [PATCH net-next] net/mlx4: Mark expected switch fall-through To: David Miller Cc: tariqt@mellanox.com, netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190123080511.GA32528@embeddedor> <20190123.090803.438719975498577995.davem@davemloft.net> From: "Gustavo A. R. Silva" Openpgp: preference=signencrypt Message-ID: Date: Wed, 23 Jan 2019 12:09:07 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190123.090803.438719975498577995.davem@davemloft.net> Content-Type: text/plain; charset=iso-8859-7 Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.130.205 X-Source-L: No X-Exim-ID: 1gmMxY-000i3W-C2 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.76]) [189.250.130.205]:50044 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 11 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/23/19 11:08 AM, David Miller wrote: > From: "Gustavo A. R. Silva" > Date: Wed, 23 Jan 2019 02:05:11 -0600 > >> In preparation to enabling -Wimplicit-fallthrough, mark switch cases >> where we are expecting to fall through. >> >> This patch fixes the following warning: >> >> drivers/net/ethernet/mellanox/mlx4/eq.c: In function ?mlx4_eq_int?: >> drivers/net/ethernet/mellanox/mlx4/mlx4.h:219:5: warning: this statement may fall through [-Wimplicit-fallthrough=] >> if (mlx4_debug_level) \ >> ^ >> drivers/net/ethernet/mellanox/mlx4/eq.c:558:4: note: in expansion of macro ?mlx4_dbg? >> mlx4_dbg(dev, "%s: MLX4_EVENT_TYPE_SRQ_LIMIT. srq_no=0x%x, eq 0x%x\n", >> ^~~~~~~~ >> drivers/net/ethernet/mellanox/mlx4/eq.c:561:3: note: here >> case MLX4_EVENT_TYPE_SRQ_CATAS_ERROR: >> ^~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enabling >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva > > Applied. > Thank you both, Tariq and David. -- Gustavo