Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1548236958-17565-1-git-send-email-clabbe@baylibre.com>
In-Reply-To: <1548236958-17565-1-git-send-email-clabbe@baylibre.com>
From:   Max Filippov <jcmvbkbc@gmail.com>
Date:   Wed, 23 Jan 2019 11:33:36 -0800
Message-ID: <CAMo8BfL=MX3GhggPbaKUFj5sPme5W3crDEMkMU8BgQJARcMjRw@mail.gmail.com>
Subject: Re: [PATCH] xtensa: rename BUILTIN_DTB to BUILTIN_DTB_SOURCE
To:     Corentin Labbe <clabbe@baylibre.com>
Cc:     Chris Zankel <chris@zankel.net>,
        Mark Rutland <mark.rutland@arm.com>,
        Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>,
        linux-xtensa@linux-xtensa.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 23, 2019 at 1:49 AM Corentin Labbe <clabbe@baylibre.com> wrote:
>
> When building some xtensa config, I hit the following warning:
> drivers/staging/mt7621-dts/Kconfig:4:warning: 'BUILTIN_DTB' has wrong type. 'select' only accept arguments of bool and tristate type
>
> It is due to some arch use BUILTIN_DTB as a flag for the need to builtin
> dtb but xtensa use it as a string for which dtb to bulltin.
> But for this (which dtb to build), it is better to use
> BUILTIN_DTB_SOURCE like other arch do.

It's odd that we see a warning from the driver's Kconfig, even though
the driver itself is not selected (it depends on SOC_MT7621 which
is a MIPS-based SoC).

-- 
Thanks.
-- Max