Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 24 Jan 2019 01:21:25 +0100
From:   Nicholas Mc Guire <der.herr@hofr.at>
To:     Miroslav Benes <mbenes@suse.cz>
Cc:     Nicholas Mc Guire <hofrat@osadl.org>,
        Josh Poimboeuf <jpoimboe@redhat.com>,
        Jessica Yu <jeyu@kernel.org>, Jiri Kosina <jikos@kernel.org>,
        Petr Mladek <pmladek@suse.com>, live-patching@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH V3] livepatch: non static warnings fix
Message-ID: <20190124002125.GB16834@osadl.at>
References: <1548226584-20579-1-git-send-email-hofrat@osadl.org>
 <alpine.LSU.2.21.1901231518320.31908@pobox.suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.LSU.2.21.1901231518320.31908@pobox.suse.cz>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 23, 2019 at 03:30:57PM +0100, Miroslav Benes wrote:
> Hi,
> 
> On Wed, 23 Jan 2019, Nicholas Mc Guire wrote:
> 
> > Sparse reported warnings about non-static symbols. For the variables
> > a simple static attribute is fine - for the functions referenced by
> > livepatch via klp_func the symbol-names must be unmodified in the
> > symbol table and the patchable code has to be emitted. The resolution
> > is to attach __used attribute to the shared statically declared functions.
> > 
> > Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
> > Suggested-by: Joe Lawrence <joe.lawrence@redhat.com>
> > Link: https://lkml.org/lkml/2018/12/13/827
> 
> could you reorder the tags and change Link: tag to 
> https://lkml.kernel.org/r/<message_id> as asked for when we reviewed v2?
>

sorry overlooked that - yes will fix that up and resend

thx!
hofrat

 
> With that
> 
> Acked-by: Miroslav Benes <mbenes@suse.cz>
> 
> M