Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 23 Jan 2019 17:00:57 -0800 (PST)
Message-Id: <20190123.170057.1824955058543142908.davem@davemloft.net>
To:     f.fainelli@gmail.com
Cc:     antoine.tenart@bootlin.com, sd@queasysnail.net, andrew@lunn.ch,
        hkallweit1@gmail.com, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com,
        alexandre.belloni@bootlin.com, quentin.schulz@bootlin.com,
        allan.nielsen@microchip.com
Subject: Re: [PATCH net-next 03/10] net: macsec: move some definitions in a
 dedicated header
From:   David Miller <davem@davemloft.net>
In-Reply-To: <955d1bdf-037e-ae26-a9da-8da2a51a7cbd@gmail.com>
References: <20190123155638.13852-1-antoine.tenart@bootlin.com>
        <20190123155638.13852-4-antoine.tenart@bootlin.com>
        <955d1bdf-037e-ae26-a9da-8da2a51a7cbd@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Florian Fainelli <f.fainelli@gmail.com>
Date: Wed, 23 Jan 2019 12:11:37 -0800

> On 1/23/19 7:56 AM, Antoine Tenart wrote:
>> This patch moves some structure, type and identifier definitions into a
>> MACsec specific header. This patch does not modify how the MACsec code
>> is running and only move things around. This is a preparation for the
>> future MACsec hardware offloading support, which will re-use those
>> definitions outside macsec.c.
>> 
>> Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
>> ---
>>  drivers/net/macsec.c | 164 +--------------------------------------
>>  include/net/macsec.h | 178 +++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 179 insertions(+), 163 deletions(-)
>>  create mode 100644 include/net/macsec.h
>> 
>> diff --git a/drivers/net/macsec.c b/drivers/net/macsec.c
>> index 56e354305f76..c3a138dd4386 100644
>> --- a/drivers/net/macsec.c
>> +++ b/drivers/net/macsec.c
>> @@ -17,10 +17,9 @@
>>  #include <net/sock.h>
>>  #include <net/gro_cells.h>
>>  
>> +#include <net/macsec.h>
>>  #include <uapi/linux/if_macsec.h>
> 
> I would probably go with include/linux/if_macsec.h and have
> uapi/linux/if_macsec.h include that file directly. This would be
> consistent with other types of network interfaces: bridge, vlan etc.

Agreed.