Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1526916imu; Wed, 23 Jan 2019 19:41:02 -0800 (PST) X-Google-Smtp-Source: ALg8bN7MmEX0QN4bWUvv9uLXZaNJcsCvqig2Tx9C1naDLQ9b9Fd70aEzEe+8R+PHm5fkeetWy68i X-Received: by 2002:a63:b105:: with SMTP id r5mr4464995pgf.442.1548301262480; Wed, 23 Jan 2019 19:41:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548301262; cv=none; d=google.com; s=arc-20160816; b=SplzZLMiaiiJDQSzcBxmgShdiOVOhu4KMRRJ4x+GWncG6BImHrpofxP4/ftxw5Wyp/ Hy63L+Kx8jOe6xbtM8wlzGdJjnGbcznQHapL7ggjGtdeBP03KHT2yR0F3MDfMHlwahnD I8KugmaPmmTrETYN9K2NKyQXbWvDD7F5Ru3gpdqGgiZ36WLDPw2DwVKfb0WAFi1KJkcd oR9CNPqeyJNbkoLrKcZsozhC3pePkS0PI5lWG2X7C8yUmZvpyDqhkoLjXWnRW1RO14Z1 CtWIcdYv5lH4gjBjL4ynBVg5Mtc83lQ8cbDSBtZpBR7aYjWlPZN7tp7UtZ8NcEwSvJ+q TdKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=jNPY+YDmXP8A0L3iT4YO1hJ87lbKOGNNdFaEnlzfki0=; b=tEIgCBV8FPiPEnW8wtY1yrMuSzU0LAVWLfxyBQTIp1xgqGjPxhrw9Bsivpk/D9JYhD BWqg+k7nEwvH8jJn6zrLLsnx8U1lZL++nqR+CQtRn/zN7ta/VMvtLpiswVIg+kRfwqUX gvfHCjCGq3QakcemoknLZ4OHa25ZF2Ca6WBoCa7pc9k7Zv7ics9rPphsciWJn8TnzheV 7IrVHovlC9x+IJPyBPiBH8f4xI1VYiYDxN8AHUo7NMLCm5EY20ulYt94y5PKHqZlPno+ XDl6lrN5DaPBts+Av/2x6d8E4M3BeWQ17oFo+zPRiJd+n2raZhD2f5SzKuJCMRywkp9N o2sw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l10si21927092pls.162.2019.01.23.19.40.47; Wed, 23 Jan 2019 19:41:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727409AbfAXDk2 (ORCPT + 99 others); Wed, 23 Jan 2019 22:40:28 -0500 Received: from ozlabs.org ([203.11.71.1]:38599 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727326AbfAXDkW (ORCPT ); Wed, 23 Jan 2019 22:40:22 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 43lSbR6CTJz9s55; Thu, 24 Jan 2019 14:40:19 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 00def7130af8b3fad1bdef98429c94a67dbbd896 X-Patchwork-Hint: ignore In-Reply-To: <20190108183720.GA14238@embeddedor> To: "Gustavo A. R. Silva" , Jeremy Kerr , Arnd Bergmann , Benjamin Herrenschmidt , Paul Mackerras From: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Subject: Re: powerpc/spufs: use struct_size() in kmalloc() Message-Id: <43lSbR6CTJz9s55@ozlabs.org> Date: Thu, 24 Jan 2019 14:40:19 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2019-01-08 at 18:37:20 UTC, "Gustavo A. R. Silva" wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct foo { > int stuff; > void *entry[]; > }; > > instance = kmalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can > now use the new struct_size() helper: > > instance = kmalloc(struct_size(instance, entry, count), GFP_KERNEL); > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/00def7130af8b3fad1bdef98429c94a6 cheers