Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262396AbUCCFs7 (ORCPT ); Wed, 3 Mar 2004 00:48:59 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262397AbUCCFs7 (ORCPT ); Wed, 3 Mar 2004 00:48:59 -0500 Received: from mx1.redhat.com ([66.187.233.31]:59825 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S262396AbUCCFs4 (ORCPT ); Wed, 3 Mar 2004 00:48:56 -0500 Date: Wed, 3 Mar 2004 00:49:27 -0500 (EST) From: James Morris X-X-Sender: jmorris@thoron.boston.redhat.com To: Glen Nakamura cc: linux-kernel@vger.kernel.org, Marcelo Tosatti Subject: Re: Mysterious string truncation in 2.4.25 kernel In-Reply-To: <20040303053547.GA3160@modulo.internal> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 653 Lines: 27 On Tue, 2 Mar 2004, Glen Nakamura wrote: > Of course, perhaps 0 should passed instead of "" for data_page? > > - err = do_mount ("none", "/dev", "devfs", 0, ""); > + err = do_mount ("none", "/dev", "devfs", 0, 0); > > Comments? Yes, the devfs fix above is needed if the data_page patch has been applied. This is the case in 2.6, but not 2.4.25. - James -- James Morris - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/