Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1739249imu; Thu, 24 Jan 2019 00:43:22 -0800 (PST) X-Google-Smtp-Source: ALg8bN7rFuyCwatD0vmH0qqYDM45cZxVnpzHC1sKBTgKE4fOnzaM9Q5RKoakahRrR8SrHyKMjBxj X-Received: by 2002:a63:2ac9:: with SMTP id q192mr5150654pgq.58.1548319402046; Thu, 24 Jan 2019 00:43:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548319402; cv=none; d=google.com; s=arc-20160816; b=zzy7/7nqh7/v3RElJlXuDFi9lf0g4nWl01J9YGegyEqxV8ZeCLl66HLi7931Vm3kYY oZSiayzN/qpnE8+DjStpTDG8iAOzF891UxWfqgNqBvMCOPmbsVtogQVHjIQ4p5GSikGs lm9mIjCywCQtRKsh1mh1UWWDbQAkyCz/AnKUCaUOGLrK1vbTcsOdbzKTtNLWnwI21QqI OiYYo2TW5I6lVt8X7BbkBbKc6KOTIgpIcZBmCBb7p7AVa9yHAWNmjABHJA4NNBi0JP0t tcIoR3ajFx2VwgqGZAvfG3ZTHqw/C78qOLNIBitJvao76+c/yk/QNSo1fVQqPfFic/fa O+hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:cc:references:to:subject:reply-to; bh=85lpMngeIyilpN/Xmkgw8WtmhPfCpWcQ6HD4252sgbQ=; b=EWeV4JIN2tsJb/7/sbOVJYEEKp4HKESm371StXOYuqAK+Myo/NuxYdjISScY9xe9pe Zw2SfLz5IB2MqtI3t8L9jNeExJrpirZd3WCxlBs+AYtMek8Rm/SVz6dYoWQycjMe/Zr2 NMW7f5/Se/rhBu4PwHDBa46Cw1QSYcwPc7QimpqR7b89olQ4EYdpWgOaOCSLbLr4e2RK Vz3sws+j1jRbsvvyf/RtnpTb92A/B+DKC10rsU3/Zn55FOIbkxstoFMtwIVc2DSfjjxt SWaDKJbYyeAjtGu6nc4cXvoO9ksymlVHEwmV0BId4jYuMRQJs6OeXSfNRdOluv4NdTLb 5aIg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o14si7039428pgi.134.2019.01.24.00.43.06; Thu, 24 Jan 2019 00:43:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727491AbfAXIla (ORCPT + 99 others); Thu, 24 Jan 2019 03:41:30 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:34765 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725939AbfAXIl3 (ORCPT ); Thu, 24 Jan 2019 03:41:29 -0500 Received: by mail-lf1-f68.google.com with SMTP id p6so3708919lfc.1; Thu, 24 Jan 2019 00:41:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:references:cc:from:openpgp :autocrypt:message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=85lpMngeIyilpN/Xmkgw8WtmhPfCpWcQ6HD4252sgbQ=; b=jc1wyrvzptE37wvLA4woDGwSiHl9vUKKLBSkfBSgx6afL29Gz8x9K83le4NAkp8vDi 1l4DFciesJDEKtpI7STAA79Ys/CYWRqAKTxtk7Ns9eNq/Jx9cNSgjd+6eBUA5pqdGPBN bQZx2RV7EXa7rVl4F0QkWVdoLymg4wVgd1uLw04sk5W7tPy2F+6FI70sPtVJcfSK3UJH DGsJn5PjQMy2FIbqYyn2KEXf8egJR77H2ZpJivg3l67Nc7d4I2UnwhqC0se4Z6vinO59 3TPnoOyd8WBEZDzZDwziuY9ve3bl3vSDs3VH4bNl0XkrJfiXYlLBl/hr/6L5roL010Tr a7ng== X-Gm-Message-State: AJcUukeqlQyG0sfZpjEFL64OqIsIZmT/lfdRiqE2GDQvmWOwVGmwbBSc djYTRF2KDm3i7jc/3NHSDqo= X-Received: by 2002:a19:2c44:: with SMTP id s65mr4827089lfs.41.1548319286697; Thu, 24 Jan 2019 00:41:26 -0800 (PST) Received: from [192.168.42.124] ([213.87.137.205]) by smtp.gmail.com with ESMTPSA id k21-v6sm879060ljc.15.2019.01.24.00.41.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 00:41:25 -0800 (PST) Reply-To: alex.popov@linux.com Subject: Re: [PATCH v2] KVM: x86: Fix single-step debugging To: Paolo Bonzini , Radim Krcmar , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Nadav Amit , Andy Lutomirski , Stefan Hajnoczi , H Peter Anvin , x86@kernel.org, kvm@vger.kernel.org, kernel-hardening@lists.openwall.com, linux-kernel@vger.kernel.org References: <1548074920-10651-1-git-send-email-alex.popov@linux.com> Cc: Greg KH From: Alexander Popov Openpgp: preference=signencrypt Autocrypt: addr=alex.popov@linux.com; prefer-encrypt=mutual; keydata= mQINBFX15q4BEADZartsIW3sQ9R+9TOuCFRIW+RDCoBWNHhqDLu+Tzf2mZevVSF0D5AMJW4f UB1QigxOuGIeSngfmgLspdYe2Kl8+P8qyfrnBcS4hLFyLGjaP7UVGtpUl7CUxz2Hct3yhsPz ID/rnCSd0Q+3thrJTq44b2kIKqM1swt/F2Er5Bl0B4o5WKx4J9k6Dz7bAMjKD8pHZJnScoP4 dzKPhrytN/iWM01eRZRc1TcIdVsRZC3hcVE6OtFoamaYmePDwWTRhmDtWYngbRDVGe3Tl8bT 7BYN7gv7Ikt7Nq2T2TOfXEQqr9CtidxBNsqFEaajbFvpLDpUPw692+4lUbQ7FL0B1WYLvWkG cVysClEyX3VBSMzIG5eTF0Dng9RqItUxpbD317ihKqYL95jk6eK6XyI8wVOCEa1V3MhtvzUo WGZVkwm9eMVZ05GbhzmT7KHBEBbCkihS+TpVxOgzvuV+heCEaaxIDWY/k8u4tgbrVVk+tIVG 99v1//kNLqd5KuwY1Y2/h2MhRrfxqGz+l/f/qghKh+1iptm6McN//1nNaIbzXQ2Ej34jeWDa xAN1C1OANOyV7mYuYPNDl5c9QrbcNGg3D6gOeGeGiMn11NjbjHae3ipH8MkX7/k8pH5q4Lhh Ra0vtJspeg77CS4b7+WC5jlK3UAKoUja3kGgkCrnfNkvKjrkEwARAQABtCZBbGV4YW5kZXIg UG9wb3YgPGFsZXgucG9wb3ZAbGludXguY29tPokCQAQTAQoAKgIbIwIeAQIXgAULCQgHAwUV CgkICwUWAgMBAAUJB8+UXAUCWgsUegIZAQAKCRCODp3rvH6PqqpOEACX+tXHOgMJ6fGxaNJZ HkKRFR/9AGP1bxp5QS528Sd6w17bMMQ87V5NSFUsTMPMcbIoO73DganKQ3nN6tW0ZvDTKpRt pBUCUP8KPqNvoSs3kkskaQgNQ3FXv46YqPZ7DoYj9HevY9NUyGLwCTEWD2ER5zKuNbI2ek82 j4rwdqXn9kqqBf1ExAoEsszeNHzTKRl2d+bXuGDcOdpnOi7avoQfwi/O0oapR+goxz49Oeov YFf1EVaogHjDBREaqiqJ0MSKexfVBt8RD9ev9SGSIMcwfhgUHhMTX2JY/+6BXnUbzVcHD6HR EgqVGn/0RXfJIYmFsjH0Z6cHy34Vn+aqcGa8faztPnmkA/vNfhw8k5fEE7VlBqdEY8YeOiza hHdpaUi4GofNy/GoHIqpz16UulMjGB5SBzgsYKgCO+faNBrCcBrscWTl1aJfSNJvImuS1JhB EQnl/MIegxyBBRsH68x5BCffERo4FjaG0NDCmZLjXPOgMvl3vRywHLdDZThjAea3pwdGUq+W C77i7tnnUqgK7P9i+nEKwNWZfLpfjYgH5JE/jOgMf4tpHvO6fu4AnOffdz3kOxDyi+zFLVcz rTP5b46aVjI7D0dIDTIaCKUT+PfsLnJmP18x7dU/gR/XDcUaSEbWU3D9u61AvxP47g7tN5+a 5pFIJhJ44JLk6I5H/bkCDQRV9eauARAArcUVf6RdT14hkm0zT5TPc/3BJc6PyAghV/iCoPm8 kbzjKBIK80NvGodDeUV0MnQbX40jjFdSI0m96HNt86FtifQ3nwuW/BtS8dk8+lakRVwuTgMb hJWmXqKMFdVRCbjdyLbZWpdPip0WGND6p5i801xgPRmI8P6e5e4jBO4Cx1ToIFyJOzD/jvtb UhH9t5/naKUGa5BD9gSkguooXVOFvPdvKQKca19S7bb9hzjySh63H4qlbhUrG/7JGhX+Lr3g DwuAGrrFIV0FaVyIPGZ8U2fjLKpcBC7/lZJv0jRFpZ9CjHefILxt7NGxPB9hk2iDt2tE6jSl GNeloDYJUVItFmG+/giza2KrXmDEFKl+/mwfjRI/+PHR8PscWiB7S1zhsVus3DxhbM2mAK4x mmH4k0wNfgClh0Srw9zCU2CKJ6YcuRLi/RAAiyoxBb9wnSuQS5KkxoT32LRNwfyMdwlEtQGp WtC/vBI13XJVabx0Oalx7NtvRCcX1FX9rnKVjSFHX5YJ48heAd0dwRVmzOGL/EGywb1b9Q3O IWe9EFF8tmWV/JHs2thMz492qTHA5pm5JUsHQuZGBhBU+GqdOkdkFvujcNu4w7WyuEITBFAh 5qDiGkvY9FU1OH0fWQqVU/5LHNizzIYN2KjU6529b0VTVGb4e/M0HglwtlWpkpfQzHMAEQEA AYkCJQQYAQIADwUCVfXmrgIbDAUJCWYBgAAKCRCODp3rvH6PqrZtEACKsd/UUtpKmy4mrZwl 053nWp7+WCE+S9ke7CFytmXoMWf1CIrcQTk5cmdBmB4E0l3sr/DgKlJ8UrHTdRLcZZnbVqur +fnmVeQy9lqGkaIZvx/iXVYUqhT3+DNj9Zkjrynbe5pLsrGyxYWfsPRVL6J4mQatChadjuLw 7/WC6PBmWkRA2SxUVpxFEZlirpbboYWLSXk9I3JmS5/iJ+P5kHYiB0YqYkd1twFXXxixv1GB Zi/idvWTK7x6/bUh0AAGTKc5zFhyR4DJRGROGlFTAYM3WDoa9XbrHXsggJDLNoPZJTj9DMww u28SzHLvR3t2pY1dT61jzKNDLoE3pjvzgLKF/Olif0t7+m0IPKY+8umZvUEhJ9CAUcoFPCfG tEbL6t1xrcsT7dsUhZpkIX0Qc77op8GHlfNd/N6wZUt19Vn9G8B6xrH+dinc0ylUc4+4yxt6 6BsiEzma6Ah5jexChYIwaB5Oi21yjc6bBb4l6z01WWJQ052OGaOBzi+tS5iGmc5DWH4/pFqX OIkgJVVgjPv2y41qV66QJJEi2wT4WUKLY1zA9s6KXbt8dVSzJsNFvsrAoFdtzc8v6uqCo0/W f0Id8MBKoqN5FniTHWNxYX6b2dFwq8i5Rh6Oxc6q75Kg8279+co3/tLCkU6pGga28K7tUP2z h9AUWENlnWJX/YhP8IkCJQQYAQoADwIbDAUCWgsSOgUJB9eShwAKCRCODp3rvH6PqtoND/41 ozCKAS4WWBBCU6AYLm2SoJ0EGhg1kIf9VMiqy5PKlSrAnW5yl4WJQcv5wER/7EzvZ49Gj8aG uRWfz3lyQU8dH2KG6KLilDFCZF0mViEo2C7O4QUx5xmbpMUq41fWjY947Xvd3QDisc1T1/7G uNBAALEZdqzwnKsT9G27e9Cd3AW3KsLAD4MhsALFARg6OuuwDCbLl6k5fu++26PEqORGtpJQ rRBWan9ZWb/Y57P126IVIylWiH6vt6iEPlaEHBU8H9+Z0WF6wJ5rNz9gR6GhZhmo1qsyNedD 1HzOsXQhvCinsErpZs99VdZSF3d54dac8ypH4hvbjSmXZjY3Sblhyc6RLYlru5UXJFh7Hy+E TMuCg3hIVbdyFSDkvxVlvhHgUSf8+Uk3Ya4MO4a5l9ElUqxpSqYH7CvuwkG+mH5mN8tK3CCd +aKPCxUFfil62DfTa7YgLovr7sHQB+VMQkNDPXleC+amNqJb423L8M2sfCi9gw/lA1ha6q80 ydgbcFEkNjqz4OtbrSwEHMy/ADsUWksYuzVbw7/pQTc6OAskESBr5igP7B/rIACUgiIjdOVB ktD1IQcezrDcuzVCIpuq8zC6LwLm7V1Tr6zfU9FWwnqzoQeQZH4QlP7MBuOeswCpxIl07mz9 jXz/74kjFsyRgZA+d6a1pGtOwITEBxtxxg== Message-ID: <845b834f-3529-056d-4373-312f7c6fc794@linux.com> Date: Thu, 24 Jan 2019 11:41:22 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <1548074920-10651-1-git-send-email-alex.popov@linux.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21.01.2019 15:48, Alexander Popov wrote: > The single-step debugging of KVM guests on x86 is broken: if we run > gdb 'stepi' command at the breakpoint when the guest interrupts are > enabled, RIP always jumps to native_apic_mem_write(). Then other > nasty effects follow. > > Long investigation showed that on Jun 7, 2017 the > commit c8401dda2f0a00cd25c0 ("KVM: x86: fix singlestepping over syscall") > introduced the kvm_run.debug corruption: kvm_vcpu_do_singlestep() can > be called without X86_EFLAGS_TF set. > > Let's fix it. Please consider that for -stable. Hello everyone! Just a friendly ping about this fix. Looking forward to the feedback. Best regards, Alexander