Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1906922imu; Thu, 24 Jan 2019 04:09:07 -0800 (PST) X-Google-Smtp-Source: ALg8bN7zJG2yui1D3i/fA44+8+LJNAaUgzqnNyoNE3JN/cFLcBcMSAz2rkhkDnUIspHF8l0iStUA X-Received: by 2002:a62:64d7:: with SMTP id y206mr6259738pfb.84.1548331747869; Thu, 24 Jan 2019 04:09:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548331747; cv=none; d=google.com; s=arc-20160816; b=Y6+9YHV8m1MND/bEBjr+HV2HdY7H7JNSrf4Uqjf+mnf6Mm8VNPUFFd0GjgqqkaKnxN g2jTFrqN/ApAhrRhSX0PEMzmN10hzSYpnjLudfUkzI0cr3UGdZ7ao3e7+Dnrsg4Gwdud L/h4uaFBOHwuvUDmoB9JTYB1QBiHYHGDhguB17pzUuIf0SdKscwRlaTv+gLvHye68jLq CysOI0xj6NtC7zZFa9gvEy1sY+aCWdIGShbN9DCY8gSlYzhifkzDdfWyaMATfsHiaRb6 UGZL/rfFHPAQCrkdcXiFw6UBMiaGNkJFCy6gTc6c3xIOh22fXJl4tw0q7CsS8mAQCUBk k2pQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dmarc-filter:dkim-signature:dkim-signature; bh=txlBovXZqSGlrOrqc6OwQV0FqwMZdDn0MpyiaxVqKwE=; b=eAD1ndfsPtXrwgu/ol0mMY9ndjsfWMLXQPcQ9rLQknUIawDfzTb6Y5KI75f0e52O6F ZOiCA43kdVPvEzP8YnbOJbJJTpSbbC/SBGggQKzuxcQpM25aPFKyK7NtMa/3BuR+lMfQ XqIy/Kz39zSZyLqCFhhSPLdTtwLliwbYJ2CKgA5qPUnYp0e6ORd4XS9+9AcgJYv3FGpR KwBiuAlhJBnK6XAtZOsV7H3di24NxS0eIHBaq2LolVcLWsM4yETEsDSHh/NDFojXGFtR 7F5QCXmLcHXtp0B86z7OwnnLzJi8ZsuEKAD3v6adG/0oluYNLxHy5zn8uYMET4jknL6v f4Nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=CRu8qWok; dkim=pass header.i=@codeaurora.org header.s=default header.b=A28sGMaV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f38si21606746pgf.206.2019.01.24.04.08.42; Thu, 24 Jan 2019 04:09:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=CRu8qWok; dkim=pass header.i=@codeaurora.org header.s=default header.b=A28sGMaV; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727775AbfAXMI1 (ORCPT + 99 others); Thu, 24 Jan 2019 07:08:27 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:42588 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726080AbfAXMI0 (ORCPT ); Thu, 24 Jan 2019 07:08:26 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5FF0060878; Thu, 24 Jan 2019 12:08:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548331705; bh=newUXrcIH9XN3+LQivCpwgP5rhRyVS0vkGi8MM9fbQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CRu8qWokTlNT5uf+90sWfU6+cjj+XRgPgm11urqlYly/Vbqs8TA2OuluwmvcWW73A Ec6xjhHiSU+PYL6LxXbH7aXkTn14ezkYDUi8y46JA/5MFHZ7XjnlGqj+80qsd4t4d9 zYdCICfbVeuASWhqA7VshBXnOVob8V1JPOGwcFN8= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED autolearn=no autolearn_force=no version=3.4.0 Received: from bgodavar-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: bgodavar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id E9E316085C; Thu, 24 Jan 2019 12:08:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1548331704; bh=newUXrcIH9XN3+LQivCpwgP5rhRyVS0vkGi8MM9fbQo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=A28sGMaVeWct0VhcKwpG8i9pyYbAJB4+Y47iJ19nC2/+8sJ5ubJYuy41elDrVeF64 fQqYM/JqaWrqcoUFxTXlUA3SAOBN7SPzN5yfMHG1YmohOjFW4YHensSJ9vjRADLkMZ fsdJWs48EEWReo4U5tky5lBWMGDz7i7+t0LjfMAE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E9E316085C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=bgodavar@codeaurora.org From: Balakrishna Godavarthi To: marcel@holtmann.org, johan.hedberg@gmail.com Cc: mka@chromium.org, johan@kernel.org, linux-kernel@vger.kernel.org, linux-bluetooth@vger.kernel.org, hemantg@codeaurora.org, linux-arm-msm@vger.kernel.org, Balakrishna Godavarthi Subject: [PATCH v9 1/3] Bluetooth: hci_qca: use wait_until_sent() for power pulses Date: Thu, 24 Jan 2019 17:38:06 +0530 Message-Id: <20190124120808.8275-2-bgodavar@codeaurora.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20190124120808.8275-1-bgodavar@codeaurora.org> References: <20190124120808.8275-1-bgodavar@codeaurora.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org wcn3990 requires a power pulse to turn ON/OFF along with regulators. Sometimes we are observing the power pulses are sent out with some time delay, due to queuing these commands. This is causing synchronization issues with chip, which intern delay the chip setup or may end up with communication issues. Signed-off-by: Balakrishna Godavarthi --- Changes in v9: * Reverted to 100us sleep. * used inline call msecs_to_jiffies() Changes in v8: * Updated 1 second timeout instead of indefinite wait. Changes in v7: * updated the wait time to 5 ms after sending power pulses. Changes in v6: * added serdev_device_write_flush() in qca_send_power_pulse instead during the power off pulse. Changes in v5: * added serdev_device_write_flush() in qca_power_off(). --- drivers/bluetooth/hci_qca.c | 40 +++++++++++++++---------------------- 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c index f036c8f98ea3..c08f4d105e73 100644 --- a/drivers/bluetooth/hci_qca.c +++ b/drivers/bluetooth/hci_qca.c @@ -60,6 +60,7 @@ #define IBS_WAKE_RETRANS_TIMEOUT_MS 100 #define IBS_TX_IDLE_TIMEOUT_MS 2000 #define BAUDRATE_SETTLE_TIMEOUT_MS 300 +#define POWER_PULSE_TRANS_TIMEOUT_MS 1000 /* susclk rate */ #define SUSCLK_RATE_32KHZ 32768 @@ -1013,11 +1014,10 @@ static inline void host_set_baudrate(struct hci_uart *hu, unsigned int speed) hci_uart_set_baudrate(hu, speed); } -static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd) +static int qca_send_power_pulse(struct hci_uart *hu, u8 cmd) { - struct hci_uart *hu = hci_get_drvdata(hdev); - struct qca_data *qca = hu->priv; - struct sk_buff *skb; + int ret; + int timeout = msecs_to_jiffies(POWER_PULSE_TRANS_TIMEOUT_MS); /* These power pulses are single byte command which are sent * at required baudrate to wcn3990. On wcn3990, we have an external @@ -1029,21 +1029,19 @@ static int qca_send_power_pulse(struct hci_dev *hdev, u8 cmd) * save power. Disabling hardware flow control is mandatory while * sending power pulses to SoC. */ - bt_dev_dbg(hdev, "sending power pulse %02x to SoC", cmd); - - skb = bt_skb_alloc(sizeof(cmd), GFP_KERNEL); - if (!skb) - return -ENOMEM; + bt_dev_dbg(hu->hdev, "sending power pulse %02x to controller", cmd); + serdev_device_write_flush(hu->serdev); hci_uart_set_flow_control(hu, true); + ret = serdev_device_write_buf(hu->serdev, &cmd, sizeof(cmd)); + if (ret < 0) { + bt_dev_err(hu->hdev, "failed to send power pulse %02x", cmd); + return ret; + } - skb_put_u8(skb, cmd); - hci_skb_pkt_type(skb) = HCI_COMMAND_PKT; - - skb_queue_tail(&qca->txq, skb); - hci_uart_tx_wakeup(hu); + serdev_device_wait_until_sent(hu->serdev, timeout); - /* Wait for 100 uS for SoC to settle down */ + /* Wait for 100 uS for SoC to settle down for the received byte. */ usleep_range(100, 200); hci_uart_set_flow_control(hu, false); @@ -1116,7 +1114,6 @@ static int qca_set_speed(struct hci_uart *hu, enum qca_speed_type speed_type) static int qca_wcn3990_init(struct hci_uart *hu) { - struct hci_dev *hdev = hu->hdev; struct qca_serdev *qcadev; int ret; @@ -1139,12 +1136,12 @@ static int qca_wcn3990_init(struct hci_uart *hu) /* Forcefully enable wcn3990 to enter in to boot mode. */ host_set_baudrate(hu, 2400); - ret = qca_send_power_pulse(hdev, QCA_WCN3990_POWEROFF_PULSE); + ret = qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE); if (ret) return ret; qca_set_speed(hu, QCA_INIT_SPEED); - ret = qca_send_power_pulse(hdev, QCA_WCN3990_POWERON_PULSE); + ret = qca_send_power_pulse(hu, QCA_WCN3990_POWERON_PULSE); if (ret) return ret; @@ -1274,13 +1271,8 @@ static const struct qca_vreg_data qca_soc_data = { static void qca_power_shutdown(struct hci_uart *hu) { - struct serdev_device *serdev = hu->serdev; - unsigned char cmd = QCA_WCN3990_POWEROFF_PULSE; - host_set_baudrate(hu, 2400); - hci_uart_set_flow_control(hu, true); - serdev_device_write_buf(serdev, &cmd, sizeof(cmd)); - hci_uart_set_flow_control(hu, false); + qca_send_power_pulse(hu, QCA_WCN3990_POWEROFF_PULSE); qca_power_setup(hu, false); } -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project