Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1953903imu; Thu, 24 Jan 2019 05:00:24 -0800 (PST) X-Google-Smtp-Source: ALg8bN7qqpqiVsfQ339NcQ+iEzyhttkvUUZigo3fyT2jgwiyWjfcCFb4WPsjzr1m/8pKrS8Y/hnT X-Received: by 2002:a65:5c4b:: with SMTP id v11mr5813123pgr.333.1548334824829; Thu, 24 Jan 2019 05:00:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548334824; cv=none; d=google.com; s=arc-20160816; b=BdB5RriE93iuVJd9mPoThunRT3MVsd4EluJCwGbkx3OKx7aDWxpp8Lqdn7B+FI7Ptt HivzniS4fYzu/XEiK8yBE1aLrgutbYwv2jqJP3lGYA9hNHfs/IyXKbHJwKUbCXBCotSj N7zDeLSICSConkwGUoLzsa5d8VkOwssen9QN70z09kstdX36C3KfiTRD8XmN4GMW/9Yg nDCol+xqFba1vAPnGgiA4/COQmsHHwm9QPmaF4hxHYDPexfhVaGQ9UM15S8tLnta3mB+ PU5r0O/Pi0pQ7y0BWbhxBZgwOEG7Maau/xMmPh4z8B5P65CjuQayxpA2H0UotE9muckt lznQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from; bh=OX062AZk1j67pRL93KhFvMsHwZtg9ccAezLj+4xEjUQ=; b=DqKjRdtx4mC4Bky2JWdrtvLYO+gsUahetQ5BOLLN5VRz68/S6a3z610vutFpLr1lE2 zQ6BZxuN8q+pRDvKRAWaQ7Iulk+IL0sSx6IR8rGJseMICFKO5M1mN/5qZYJhOkJK5pwA oAN1CmifueZHWbYc409lVXTUHvLuTPkLOzXP5r3NhjKy9Dlx4hqSvMjllP6KDFGefXpR t6ReWTvaY/hQpuNVCvRtPO5MGKByzh4CSEcWBLp67EJCMsNcbJZNOQ6T7DsjF9LP54dE reXPXIt7kiRfJWn0/np2QjKZDzs41upldHa/FiZGrHwb4Fz5CRkCncQJYKP4BY1Ygxsk l9UA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b61si22882606plb.70.2019.01.24.05.00.09; Thu, 24 Jan 2019 05:00:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727943AbfAXNAD (ORCPT + 99 others); Thu, 24 Jan 2019 08:00:03 -0500 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:44118 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727596AbfAXNAC (ORCPT ); Thu, 24 Jan 2019 08:00:02 -0500 Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0OCsZI0000996 for ; Thu, 24 Jan 2019 08:00:01 -0500 Received: from e06smtp02.uk.ibm.com (e06smtp02.uk.ibm.com [195.75.94.98]) by mx0b-001b2d01.pphosted.com with ESMTP id 2q7bh5fsyc-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 24 Jan 2019 08:00:01 -0500 Received: from localhost by e06smtp02.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 24 Jan 2019 13:00:00 -0000 Received: from b06cxnps3075.portsmouth.uk.ibm.com (9.149.109.195) by e06smtp02.uk.ibm.com (192.168.101.132) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 24 Jan 2019 12:59:57 -0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps3075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0OCxtRs47513654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 24 Jan 2019 12:59:56 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D01EE52050; Thu, 24 Jan 2019 12:59:55 +0000 (GMT) Received: from s38lp84.lnxne.boe (unknown [9.152.108.100]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id 743845204F; Thu, 24 Jan 2019 12:59:55 +0000 (GMT) From: Michael Mueller To: KVM Mailing List Cc: Linux-S390 Mailing List , linux-kernel@vger.kernel.org, Martin Schwidefsky , Heiko Carstens , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Halil Pasic , Pierre Morel , Michael Mueller Subject: [PATCH v6 01/13] KVM: s390: drop obsolete else path Date: Thu, 24 Jan 2019 13:59:27 +0100 X-Mailer: git-send-email 2.13.4 In-Reply-To: <20190124125939.130763-1-mimu@linux.ibm.com> References: <20190124125939.130763-1-mimu@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 19012412-0008-0000-0000-000002B565AC X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19012412-0009-0000-0000-0000222199F6 Message-Id: <20190124125939.130763-2-mimu@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-24_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=813 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901240095 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The explicit else path specified in set_intercept_indicators_io is not required as the function returns in case the first branch is taken anyway. Signed-off-by: Michael Mueller --- arch/s390/kvm/interrupt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c index fcb55b02990e..19d556512452 100644 --- a/arch/s390/kvm/interrupt.c +++ b/arch/s390/kvm/interrupt.c @@ -345,7 +345,7 @@ static void set_intercept_indicators_io(struct kvm_vcpu *vcpu) { if (!(pending_irqs_no_gisa(vcpu) & IRQ_PEND_IO_MASK)) return; - else if (psw_ioint_disabled(vcpu)) + if (psw_ioint_disabled(vcpu)) kvm_s390_set_cpuflags(vcpu, CPUSTAT_IO_INT); else vcpu->arch.sie_block->lctl |= LCTL_CR6; -- 2.13.4