Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1970875imu; Thu, 24 Jan 2019 05:14:55 -0800 (PST) X-Google-Smtp-Source: ALg8bN5dv40GMZbykqbIwJnId8dRSZrCW5okVRz7vzMdYlvinAZKKzg5G2qrLifYpt0FDsiZTRaY X-Received: by 2002:a63:9041:: with SMTP id a62mr5753180pge.163.1548335695809; Thu, 24 Jan 2019 05:14:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548335695; cv=none; d=google.com; s=arc-20160816; b=CXMxC8teJY49Aw8nfOsydQkGfp5DNgmNdIUBLiR6RnKwJUiisqLc4blq0uyNA3nL3/ i7Bs914PyMY8s2XOwoY89PBs6xWrFoX82c+fBkOeN8E0atrcgZHcM1TmAtSgLBgkAjmu +wfdrLUuVd2c+NtUA2vgX0RivkxioK6/0iPeAJFQ1BHKJESXg9cl1K9wbnloxMCe35pa 9ehwk5hyIDm84sxV+koS6Ubx128Np5eTm+8IZand7fZ01uD9uLW0oSQUt0MlYYv2mzle VfsZakj6mwfeySQPSdVJ1zWsVuY9cQVn9eyQZwPvhBMnowtRZknBBBiKhzaQ2iYTN4Kh Vn0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=y/lW7+JZxD/baTt1N3aYvrtz4O/3BooocSajeiT6/vk=; b=uLDmBqF1M39mDTrAs5Nu/81pdKmINhotHZbSIa6L7aVibP3EYmNDMkzpimR1nCw0YV ucHFqPIJe6WiQ72Xtr5uhdm9pgkBhDep5W3Z6pkc3nsfc3rgi0FmEv2uCll0ZSaPamut lNfp19m4eXh9dFZAxauQNziM4BcXkQ8wXYIkd37bd6d+rLkfGIK6Gr1C4CDvVsjjUy4m CpXUQejzMf6PvrtT/myVzkOW2ceJzGUlOWUhimJFRUtpqUI4rXOtGJIlTx+4B35Js0nE rrnxUn+9WHJd+5WUSfLcPcBO0+7TSFmGRSg+a+qlhsuutNgghA/14JXJOMO83bWOCIq1 1IRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vCy7CqwG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u72si6969898pgc.360.2019.01.24.05.14.39; Thu, 24 Jan 2019 05:14:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=vCy7CqwG; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727902AbfAXNOT (ORCPT + 99 others); Thu, 24 Jan 2019 08:14:19 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42244 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727455AbfAXNOS (ORCPT ); Thu, 24 Jan 2019 08:14:18 -0500 Received: by mail-wr1-f66.google.com with SMTP id q18so6400136wrx.9; Thu, 24 Jan 2019 05:14:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=y/lW7+JZxD/baTt1N3aYvrtz4O/3BooocSajeiT6/vk=; b=vCy7CqwGW9x35ONepOc0p6ILh0WFw5zqJGkHDQ014Ok023o2nRXPYR3QuTo0TZkbAg UHJHOJm9kvgUrBGPC3SkRNYf3wzcEkYskRId6Kf83RcKCGDCqbjvu09SsAWNOqDpfN/9 y6bM4Zvlw6KlC41UGawHyOBJeG2TnjFLAGE+Bh8NJaEAelJ5qECUW8bUcZzJwUFymee7 EJihOae97LQrTIiwq5uqA1vWIRvx5FCYbBKt4GBYBKehx3ACEM8zpNBzUTCtnTvogqgB 5CkryeOYkhFpaGI64/bxZTg7hM2K2oGW6YnHPtzcFGyhoc7jldSFLojXhGFCn+GbbqH6 fVyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=y/lW7+JZxD/baTt1N3aYvrtz4O/3BooocSajeiT6/vk=; b=XTjpYJpvJtOJYXv01jUxNN4AHz4vBu/RO0lCwmps8x5tJALEcITrXeI6hk2gZ3WXui 20MIS86p0dBORXlyTADbFlyaFqH8jAr/jFSFuVKznEmALk2i1KeZ6vTRlTeSdeoGxmPF A5RN+zHrzErFDjfnj2319TVla/KGgQGFVqC8l5MBPiiVp1Ztp3wKoj1jXS7RaX7wm7sk NUMQrkoFjs+lHSx9iHcSqqUhH+wzPJcodlvII50PnJfI07YrAAZ3pVaApqwJOsdQoxxq juYHly62jwTcSRduK5g0lTpBFPpONWa0IzZqcH26JwVViBPLd8VLdwG5Kvpi3DLZUIBv WN6g== X-Gm-Message-State: AJcUukeZk2yG5/rPPXv8YaeTaKHdDVwo/i6+Ue6DUZbDeqFpfZHE4B5K UAG6vjD/9lUX9UM6pKT5W0fdegT5 X-Received: by 2002:adf:ee46:: with SMTP id w6mr7327037wro.261.1548335656891; Thu, 24 Jan 2019 05:14:16 -0800 (PST) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id l6sm97552451wrv.70.2019.01.24.05.14.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 05:14:16 -0800 (PST) Date: Thu, 24 Jan 2019 14:14:14 +0100 From: Corentin Labbe To: Ard Biesheuvel Cc: Eric Biggers , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Herbert Xu , Linux Kernel Mailing List , "Jason A . Donenfeld" Subject: Re: [RFC/RFT PATCH 11/15] crypto: testmgr - convert skcipher testing to use testvec_configs Message-ID: <20190124131414.GA13624@Red> References: <20190123224926.250525-1-ebiggers@kernel.org> <20190123224926.250525-12-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 24, 2019 at 01:36:23PM +0100, Ard Biesheuvel wrote: > On Wed, 23 Jan 2019 at 23:53, Eric Biggers wrote: > > > > From: Eric Biggers > > > > Convert alg_test_skcipher() to use the new test framework, adding a list > > of testvec_configs to test by default. When the extra self-tests are > > enabled, randomly generated testvec_configs are tested as well. > > > > This improves skcipher test coverage mainly because now all algorithms > > have a variety of data layouts tested, whereas before each algorithm was > > responsible for declaring its own chunked test cases which were often > > missing or provided poor test coverage. The new code also tests both > > the MAY_SLEEP and !MAY_SLEEP cases, different IV alignments, and buffers > > that cross pages. > > > > This has already found a bug in the arm64 ctr-aes-neonbs algorithm. > > It would have easily found many past bugs. > > > > I removed the skcipher chunked test vectors that were the same as > > non-chunked ones, but left the ones that were unique. > > > > Signed-off-by: Eric Biggers > > This patch does not apply after applying 1..10 onto cryptodev/master > > Do you have a tree somewhere? Hello I got the same with next. You need to apply "crypto: clarify name of WEAK_KEY request flag" from his repo: https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git branch testmgr-improvements Regards