Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1975152imu; Thu, 24 Jan 2019 05:18:45 -0800 (PST) X-Google-Smtp-Source: ALg8bN4Z6Coq2XI0F8J6GF5xOd/9+ZO24HKj0aq8Lsgi0Zk4WDbRMXXzQzLgJQeMPggNBMkEKjar X-Received: by 2002:a17:902:8b88:: with SMTP id ay8mr6640383plb.55.1548335925391; Thu, 24 Jan 2019 05:18:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548335925; cv=none; d=google.com; s=arc-20160816; b=K6AH0omiuCJ1HyfA8z/8S7o7E1Oj4t4olcozu5TBbZFzjuyXTz9RKPRQHuRRHb+LTk ptxUIKuGkIu0ONm45NOVrwxXXjOgzIne/ptE3GBKQFc832FmC21uQAGMsCv800iFfFYI 0qgHv0elymE64lVLk1q4dhtAHwyVcIAl6+kLgi45DK7/DHOYwpXTKQfSQPaHE1woayI2 RvFq2MC1tF+LsMMioy/QDOH0zaylnFlAkpMLFq/jh3ePDI6M0Jvw2tsaZEF5M47Eftcz CQnjgPtS43fR3RGSUFvM42Nm15Ezxbn1VJVrwrdQVnC8w8VsBmoukfZiuPRw+qZQOEpO ySHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:to:from; bh=mQ+2AN5ISLUyyuSZNYfYleK8RFVnKaYtI8/RMFoBrQY=; b=EAb7Zjz+uwWRjwcPFzzMzwx1WM2WYkeH3/stFL1mGv48EEeHJENqg2qvxDs29tZGTD 642enLlEv8bQPi8isWcldvcfs5W2JAUMyilGT3IYHKmtXEFCFMOKbuVDqW7xgWf7GtxF aK/3EmYoVIxomHIwLveIAr95ARtZlp3UFSBG8G9CnQvJFrg9UR5xvOS9/MdEsdkzl0XO wJRBHw862UOnBO3P3ILfZme2v/HTg1ikAfY8TLViyZo3d6LoYaTMxJcQ/CZa1BZQSpz+ N724VYggBBnmIR74bP7oNTCci2Q47igBMc3OodPz1Ip2PP3DjErPmOJudTPQJBQnU53K pHkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a1si24494909pld.249.2019.01.24.05.18.29; Thu, 24 Jan 2019 05:18:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728049AbfAXNSM (ORCPT + 99 others); Thu, 24 Jan 2019 08:18:12 -0500 Received: from mx2.suse.de ([195.135.220.15]:57484 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728016AbfAXNSM (ORCPT ); Thu, 24 Jan 2019 08:18:12 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 6636CB058; Thu, 24 Jan 2019 13:18:11 +0000 (UTC) From: Thomas Bogendoerfer To: "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net] net: mvpp2: fix condition for setting up link interrupt Date: Thu, 24 Jan 2019 14:18:03 +0100 Message-Id: <20190124131803.14038-1-tbogendoerfer@suse.de> X-Mailer: git-send-email 2.13.7 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Set up link interrupt if connection is handled by phylink otherwise link state change detection for in-band-status doesn't work. Fixes: 4bb043262878 ("net: mvpp2: phylink support") Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index 16066c2d5b3a..0fbfe1945a69 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -3405,7 +3405,7 @@ static int mvpp2_open(struct net_device *dev) valid = true; } - if (priv->hw_version == MVPP22 && port->link_irq && !port->phylink) { + if (priv->hw_version == MVPP22 && port->link_irq && port->phylink) { err = request_irq(port->link_irq, mvpp2_link_status_isr, 0, dev->name, port); if (err) { -- 2.16.4