Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190123165533.29645-1-k.konieczny@partner.samsung.com>
 <CGME20190123165551eucas1p1cd99462e3767dbb4feb88b996225ed21@eucas1p1.samsung.com>
 <20190123165533.29645-4-k.konieczny@partner.samsung.com> <20190124133729.GB13624@Red>
 <75f3be00-8035-0586-1611-99e5da53a8e7@partner.samsung.com>
In-Reply-To: <75f3be00-8035-0586-1611-99e5da53a8e7@partner.samsung.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Thu, 24 Jan 2019 15:39:01 +0100
Message-ID: <CAJKOXPdPM_PpVPjJUTdg2_nJ1R2o2Rt1-XA8rPi=bLMrXeQeqw@mail.gmail.com>
Subject: Re: [PATCH v2 3/3] crypto: s5p: add AES support for Exynos5433
To:     Kamil Konieczny <k.konieczny@partner.samsung.com>
Cc:     Corentin Labbe <clabbe.montjoie@gmail.com>,
        Vladimir Zapolskiy <vz@mleia.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        linux-crypto@vger.kernel.org,
        "linux-samsung-soc@vger.kernel.org" 
        <linux-samsung-soc@vger.kernel.org>, linux-kernel@vger.kernel.org,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 24 Jan 2019 at 15:34, Kamil Konieczny
<k.konieczny@partner.samsung.com> wrote:
>
>
>
> On 24.01.2019 14:37, Corentin Labbe wrote:
> > On Wed, Jan 23, 2019 at 05:55:33PM +0100, Kamil Konieczny wrote:
> >> Add AES crypto HW acceleration for Exynos5433, with the help of SlimSSS IP.
> >>
> >> Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>
> >> ---
> >>  drivers/crypto/s5p-sss.c | 50 ++++++++++++++++++++++++++++++++++++----
> >>  1 file changed, 46 insertions(+), 4 deletions(-)
> >>
> >> diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
> >> index 0064be0e3941..e2d247f59254 100644
> >> [...]
> >> @@ -240,6 +241,7 @@
> >>  struct samsung_aes_variant {
> >>      unsigned int                    aes_offset;
> >>      unsigned int                    hash_offset;
> >> +    char                            *clk_names[];
> >
> > Hello
> >
> > this could be set as const
>
> Definitions sets const:
>
> grep "static const" drivers/crypto/s5p-sss.c
>
> static const struct samsung_aes_variant s5p_aes_data = {
> static const struct samsung_aes_variant exynos_aes_data = {
> static const struct samsung_aes_variant exynos5433_slim_aes_data = {
>
> so it is not needed at struct declaration, or am I missing something ?

The struct contains the pointer, so the pointer will be const. However
the pointer can point to either const string or non-const string.
That's the Corentin's comment about. So in fact as he says - this
should be a pointer to a const string.

Best regards,
Krzysztof