Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Reply-To: mimu@linux.ibm.com
Subject: Re: [PATCH v6 07/13] KVM: s390: introduce struct
 kvm_s390_gisa_interrupt
To:     Cornelia Huck <cohuck@redhat.com>
Cc:     KVM Mailing List <kvm@vger.kernel.org>,
        Linux-S390 Mailing List <linux-s390@vger.kernel.org>,
        linux-kernel@vger.kernel.org,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Christian Borntraeger <borntraeger@de.ibm.com>,
        Janosch Frank <frankja@linux.ibm.com>,
        David Hildenbrand <david@redhat.com>,
        Halil Pasic <pasic@linux.ibm.com>,
        Pierre Morel <pmorel@linux.ibm.com>
References: <20190124125939.130763-1-mimu@linux.ibm.com>
 <20190124125939.130763-8-mimu@linux.ibm.com>
 <20190124160637.0f8b47a7.cohuck@redhat.com>
From:   Michael Mueller <mimu@linux.ibm.com>
Organization: IBM
Date:   Thu, 24 Jan 2019 16:24:28 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0)
 Gecko/20100101 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20190124160637.0f8b47a7.cohuck@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Message-Id: <a9f57ea6-4f87-3af0-46c9-695708f98649@linux.ibm.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 24.01.19 16:06, Cornelia Huck wrote:
> On Thu, 24 Jan 2019 13:59:33 +0100
> Michael Mueller <mimu@linux.ibm.com> wrote:
> 
>> Use this struct analog to the kvm interruption structs
>> for kvm emulated floating and local interruptions.
> 
> I guess that makes sense.
> 
>> Further fields will be added with this series as
>> required.
> 
> A reference to "this series" will look a bit strange if you look at the
> committed patch later. What about:
> 
> "GIB handling will add further fields to this structure as required."

Yes, that reads pretty well. I will replace the sentence.

> 
> ?
> 
>>
>> Signed-off-by: Michael Mueller <mimu@linux.ibm.com>
>> ---
>>   arch/s390/include/asm/kvm_host.h |  6 ++++-
>>   arch/s390/kvm/interrupt.c        | 52 +++++++++++++++++++++++-----------------
>>   arch/s390/kvm/kvm-s390.c         |  2 +-
>>   3 files changed, 36 insertions(+), 24 deletions(-)
> 
> Reviewed-by: Cornelia Huck <cohuck@redhat.com>
>