Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262431AbUCCK7t (ORCPT ); Wed, 3 Mar 2004 05:59:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S262434AbUCCK6z (ORCPT ); Wed, 3 Mar 2004 05:58:55 -0500 Received: from fw.osdl.org ([65.172.181.6]:20890 "EHLO mail.osdl.org") by vger.kernel.org with ESMTP id S262431AbUCCK6Z (ORCPT ); Wed, 3 Mar 2004 05:58:25 -0500 Date: Wed, 3 Mar 2004 02:58:20 -0800 From: Andrew Morton To: Andrea Arcangeli Cc: linux-kernel@vger.kernel.org, mbligh@aracnet.com, hugh@veritas.com, wli@holomorphy.com Subject: Re: 230-objrmap fixes for 2.6.3-mjb2 Message-Id: <20040303025820.2cf6078a.akpm@osdl.org> In-Reply-To: <20040303070933.GB4922@dualathlon.random> References: <20040303070933.GB4922@dualathlon.random> X-Mailer: Sylpheed version 0.9.4 (GTK+ 1.2.10; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 832 Lines: 23 Andrea Arcangeli wrote: > > --- sles-objrmap/mm/rmap.c.~1~ 2004-03-03 06:45:38.995594456 +0100 > +++ sles-objrmap/mm/rmap.c 2004-03-03 07:01:39.200621104 +0100 > @@ -470,7 +470,7 @@ try_to_unmap_obj_one(struct vm_area_stru > if (!pte) > goto out; > > - if (vma->vm_flags & VM_LOCKED) { > + if (vma->vm_flags & (VM_LOCKED|VM_RESERVED)) { > ret = SWAP_FAIL; > goto out_unmap; I keep on wanting to put that in there too. But pages in a VM_RESERVED vma should not find their way onto the LRU. Maybe we should be checking for that in do_no_page(). - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/