Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] blk-mq: fix the cmd_flag_name array
To:     Jeff Moyer <jmoyer@redhat.com>,
        Jianchao Wang <jianchao.w.wang@oracle.com>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1548325735-1760-1-git-send-email-jianchao.w.wang@oracle.com>
 <x49h8dygkih.fsf@segfault.boston.devel.redhat.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <c3bde1b4-73ea-9120-0e6c-f9f57c0bbb24@kernel.dk>
Date:   Thu, 24 Jan 2019 09:22:04 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <x49h8dygkih.fsf@segfault.boston.devel.redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/24/19 8:09 AM, Jeff Moyer wrote:
> Jianchao Wang <jianchao.w.wang@oracle.com> writes:
> 
>> Swap REQ_NOWAIT and REQ_NOUNMAP and add REQ_HIPRI.
>>
>> Signed-off-by: Jianchao Wang <jianchao.w.wang@oracle.com>
>> ---
>>  block/blk-mq-debugfs.c | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
>> index 90d6876..f812083 100644
>> --- a/block/blk-mq-debugfs.c
>> +++ b/block/blk-mq-debugfs.c
>> @@ -308,8 +308,9 @@ static const char *const cmd_flag_name[] = {
>>  	CMD_FLAG_NAME(PREFLUSH),
>>  	CMD_FLAG_NAME(RAHEAD),
>>  	CMD_FLAG_NAME(BACKGROUND),
>> -	CMD_FLAG_NAME(NOUNMAP),
>>  	CMD_FLAG_NAME(NOWAIT),
>> +	CMD_FLAG_NAME(NOUNMAP),
>> +	CMD_FLAG_NAME(HIPRI),
>>  };
>>  #undef CMD_FLAG_NAME
> 
> Acked-by: Jeff Moyer <jmoyer@redhat.com>
> 
> You might consider also adding a comment above the req_flag_bits enum
> noting that modifications also need to be propagated to cmd_flag_name.

Agree... These things are notoriously difficult to keep in sync, this
isn't the first time we've had a fixup. Not sure if that situation
is improvable, but at least a comment might help.

-- 
Jens Axboe