Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1548347312.9266.98.camel@acm.org>
Subject: Re: [PATCH] blk-mq: fix the cmd_flag_name array
From:   Bart Van Assche <bvanassche@acm.org>
To:     Jens Axboe <axboe@kernel.dk>, Jeff Moyer <jmoyer@redhat.com>,
        Jianchao Wang <jianchao.w.wang@oracle.com>
Cc:     linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Thu, 24 Jan 2019 08:28:32 -0800
In-Reply-To: <c3bde1b4-73ea-9120-0e6c-f9f57c0bbb24@kernel.dk>
References: <1548325735-1760-1-git-send-email-jianchao.w.wang@oracle.com>
         <x49h8dygkih.fsf@segfault.boston.devel.redhat.com>
         <c3bde1b4-73ea-9120-0e6c-f9f57c0bbb24@kernel.dk>
Content-Type: text/plain; charset="UTF-7"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 2019-01-24 at 09:22 -0700, Jens Axboe wrote:
+AD4 On 1/24/19 8:09 AM, Jeff Moyer wrote:
+AD4 +AD4 Jianchao Wang +ADw-jianchao.w.wang+AEA-oracle.com+AD4 writes:
+AD4 +AD4 
+AD4 +AD4 +AD4 Swap REQ+AF8-NOWAIT and REQ+AF8-NOUNMAP and add REQ+AF8-HIPRI.
+AD4 +AD4 +AD4 
+AD4 +AD4 +AD4 Signed-off-by: Jianchao Wang +ADw-jianchao.w.wang+AEA-oracle.com+AD4
+AD4 +AD4 +AD4 ---
+AD4 +AD4 +AD4  block/blk-mq-debugfs.c +AHw 3 +-+--
+AD4 +AD4 +AD4  1 file changed, 2 insertions(+-), 1 deletion(-)
+AD4 +AD4 +AD4 
+AD4 +AD4 +AD4 diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
+AD4 +AD4 +AD4 index 90d6876..f812083 100644
+AD4 +AD4 +AD4 --- a/block/blk-mq-debugfs.c
+AD4 +AD4 +AD4 +-+-+- b/block/blk-mq-debugfs.c
+AD4 +AD4 +AD4 +AEAAQA -308,8 +-308,9 +AEAAQA static const char +ACo-const cmd+AF8-flag+AF8-name+AFsAXQ +AD0 +AHs
+AD4 +AD4 +AD4  	CMD+AF8-FLAG+AF8-NAME(PREFLUSH),
+AD4 +AD4 +AD4  	CMD+AF8-FLAG+AF8-NAME(RAHEAD),
+AD4 +AD4 +AD4  	CMD+AF8-FLAG+AF8-NAME(BACKGROUND),
+AD4 +AD4 +AD4 -	CMD+AF8-FLAG+AF8-NAME(NOUNMAP),
+AD4 +AD4 +AD4  	CMD+AF8-FLAG+AF8-NAME(NOWAIT),
+AD4 +AD4 +AD4 +-	CMD+AF8-FLAG+AF8-NAME(NOUNMAP),
+AD4 +AD4 +AD4 +-	CMD+AF8-FLAG+AF8-NAME(HIPRI),
+AD4 +AD4 +AD4  +AH0AOw
+AD4 +AD4 +AD4  +ACM-undef CMD+AF8-FLAG+AF8-NAME
+AD4 +AD4 
+AD4 +AD4 Acked-by: Jeff Moyer +ADw-jmoyer+AEA-redhat.com+AD4
+AD4 +AD4 
+AD4 +AD4 You might consider also adding a comment above the req+AF8-flag+AF8-bits enum
+AD4 +AD4 noting that modifications also need to be propagated to cmd+AF8-flag+AF8-name.
+AD4 
+AD4 Agree... These things are notoriously difficult to keep in sync, this
+AD4 isn't the first time we've had a fixup. Not sure if that situation
+AD4 is improvable, but at least a comment might help.

How about making the build system derive the CMD+AF8-FLAG+AF8-NAME() declarations
from the include/linux/blk+ACo header files? It's not that hard to do that e.g.
with the help of sed. The output of sed could be written into a .h file and
that file could be +ACM-included from blk-mq-debugfs.c.

Bart.