Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2219547imu; Thu, 24 Jan 2019 09:06:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN4W8J/blbs/EznEx/6Z4SXBYoLBG6nVmSrbomqvyvnHMn9/h6S5aszz4ORZxTQ4uE6A4IQ+ X-Received: by 2002:a62:ea09:: with SMTP id t9mr7639751pfh.228.1548349589319; Thu, 24 Jan 2019 09:06:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548349589; cv=none; d=google.com; s=arc-20160816; b=vVi7TssTJymIvU4PvFUMm7Vc5OL8iIsIZwPsb9DQnDLWeWm7bpr7gc4ZCMv7T++Yps 8bLY0x4aR08v2Q/jX+87MdZo5BYGGHLVASW5g2X7rSr37pCqW9tdphLDeDTfs4dU6Gqm eGifksZJxCytwwJffAjuazSVJ592J1cZBpYRZKe2NXryJZHrpuFRwFvjvPVqt+BcCKaX G7xwdw7B3YCmVIMYQjhV8oWYHLI8Sm8aQpWtxNhaV07uQvoccj0ez87BYdO/AIjZjAHg hwzccUJxFW7NNkIE/O1VlcOJ4VkABMwXCn3tW9VlalQ83XNOFLyjTOJKheT8Wr7a/HJ7 bLUA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=as9u/5yc5OPBX7IDGNFFXrjO+S13UWlbWRAmZt+h0Vk=; b=nh48mRJuFHiSS1CbRRFgiAn22xMvjmWn/ynsjeWOAl+GMTjjyqX6KBEYrvaJfcmTNS VTgvGI8ORSUiRubqTwyGGRNI0GgPt+FSfhcUBDfMLEHx88dPfWMPOFVxVwRjC1blWtdd VDpdtLhj89Xo/ZqhqGQyW2ycR86zVkkpiof20A4bVA7XrRd6oY8DonVFhpOVbfYulFwJ OLNyQM730PthatFOHAknpWC5efiLLCxzrA1LDemyEzCWi4xm8Ddf12uFg28ATuSimwFf 3p/rjSVwlf6qy8cutv038L28XOxXgOVZhCs7rGH74s8inZMip+63YetZhTO4WdNjON1B RarA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 27si22316807pgu.421.2019.01.24.09.06.11; Thu, 24 Jan 2019 09:06:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728563AbfAXRBU (ORCPT + 99 others); Thu, 24 Jan 2019 12:01:20 -0500 Received: from mx2.suse.de ([195.135.220.15]:43436 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727443AbfAXRBU (ORCPT ); Thu, 24 Jan 2019 12:01:20 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 12A1EAFCC; Thu, 24 Jan 2019 17:01:19 +0000 (UTC) Date: Thu, 24 Jan 2019 18:01:17 +0100 From: Michal Hocko To: Johannes Weiner Cc: Chris Down , Andrew Morton , Tejun Heo , Roman Gushchin , Dennis Zhou , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH 2/2] mm: Consider subtrees in memory.events Message-ID: <20190124170117.GS4087@dhcp22.suse.cz> References: <20190123223144.GA10798@chrisdown.name> <20190124082252.GD4087@dhcp22.suse.cz> <20190124160009.GA12436@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190124160009.GA12436@cmpxchg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 24-01-19 11:00:10, Johannes Weiner wrote: [...] > We cannot fully eliminate a risk for regression, but it strikes me as > highly unlikely, given the extremely young age of cgroup2-based system > management and surrounding tooling. I am not really sure what you consider young but this interface is 4.0+ IIRC and the cgroup v2 is considered stable since 4.5 unless I missrememeber and that is not a short time period in my book. Changing interfaces now represents a non-trivial risk and so far I haven't heard any actual usecase where the current semantic is actually wrong. Inconsistency on its own is not a sufficient justification IMO. -- Michal Hocko SUSE Labs