Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2288384imu; Thu, 24 Jan 2019 10:10:23 -0800 (PST) X-Google-Smtp-Source: ALg8bN5IdmvPYf2FR4aifSbvoKGLEUY4rwwZytOyQHnlfSg0Byu/MK6AX750Tjt8Y1HI1CMGPG3L X-Received: by 2002:a62:e30d:: with SMTP id g13mr7438785pfh.151.1548353423519; Thu, 24 Jan 2019 10:10:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548353423; cv=none; d=google.com; s=arc-20160816; b=HBYsC64WsW7PApv7QK1AFOZ+a0j7yXQVKq5jwTn3ByyG6G4k7Z4dMdr0cv3eY9c06F v3ix4sdmJwmpgzY8yid0MHY0dAuRrr9ohcdsvteeq7OgRhDG+v49GyI2yTZgXzfDsA/x emyBKJ5cZ/gHN5e+2VJFJDo8rBru3NZvy5Bv4IkU4Os0rJTgpPM1iS7zAo8ojlO+wRrp 1sUzWh7IbohA6N3S3kuEN/rjPEnxZrE8z3ll4ICuyKSJeGEgFkx4Q7DCL7Y8iQt5UpRs TsT8GWMOggq9jNNKBOs/OFdP9qVSSMfBEdZC8YQ+ehmoZeu+LUI4TR4oDyQRKKhf8BT1 9oqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=ennrxO2+TA9zkaPve5mAjE5oq7jQGv//a4Sb+IfsDFc=; b=w3vBd9w4ITcJbdqBjDaavCBmEVHOdx4xIIJU5D9mK5URA9ttwujfwq7xuR+xOEV1N6 LwbDMhXhzZ3YQJsardstBS8k4BLpT+Vem9zpjjXE7MM9OYxo98YHWHuEo6yoKlUufil0 dl9QNoJpvJUav9m6rwhCf0bHz22QL2HrOUCPiO/Z8OMM65CapnfUCdQrJYB5HFf+plcT 8oojf1OgtKXNMbOVIw/DWC8rMotDpMMXizCnLuTiR2878hutJXVJ/nVoPr9dSFb4ZLkr 5d3pwgdnWMD6XwwQ49kE9NU+Bejrc3bPXeDQW9UFEPgsJFKXzClnoqdpCcuqDM3RK4ZC h5vQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=BgngmbiN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i20si22614945pgh.187.2019.01.24.10.10.08; Thu, 24 Jan 2019 10:10:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=BgngmbiN; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729352AbfAXSIS (ORCPT + 99 others); Thu, 24 Jan 2019 13:08:18 -0500 Received: from mail-it1-f193.google.com ([209.85.166.193]:39693 "EHLO mail-it1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728394AbfAXSIQ (ORCPT ); Thu, 24 Jan 2019 13:08:16 -0500 Received: by mail-it1-f193.google.com with SMTP id a6so5799529itl.4 for ; Thu, 24 Jan 2019 10:08:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ennrxO2+TA9zkaPve5mAjE5oq7jQGv//a4Sb+IfsDFc=; b=BgngmbiN/4VsdwAnYPRQpIcT8uwPTLPvVjKvVq3uoh8oOOmfKoFcH6Wsxb0lgBCUL4 OtjtD8Xo6G3CTiWkXXySA7SaNDHmuJnYUrGspv0gH+98ktlBO9pmfOumRE3jmN65nMcZ 6kg9oS5+csEsYastPC1I+US/h0X5X3qN6Wx1ooJP0xJAX/OLPmf6x+L7CjY5NJBW9UCI j7nU0FNy3gFR8Q84VtpU1lFX6ec8AZchlxntIp9rDvhWfKfPgysQneYPpNnCl7/o60jY tmYWTPypyiFfMWturP9ciA0lcHfW2/L7WkKXy2pFTYLKexQtwIs9UUTQVl8RSKV95mUp nrTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ennrxO2+TA9zkaPve5mAjE5oq7jQGv//a4Sb+IfsDFc=; b=InU/yXOklLhGlTWVJFTQS2o6johXhuMcLMJTIkQ1a/zQlPdhl4v6Pe8vJUMTZdNYaw DfGtYTWTyLaEkRBwBcOTWbWv0xx2UDxvPJ85ZuKR1KL+m71HieQqGjjlNsPQHhp1gnNq mw0T859JC93UXTrVjS4NCBY2HUz0BUk+8WK7R8b+ANn07M8dOSWVHVrZ/bQAfkZMLhL2 AcNIJNkV5/qXrZTNPgSEhJ/ESvBO+Ta7S+7UhtU85zG1+GKJI7BvuSJl95Qg0oVji9X0 jFlDzSOGyjP4TQu3tDRIQ5W5NJEeC5OY9484xogFT5+1zcBIrffO70vq0nYKLcVwy8Cq rR+g== X-Gm-Message-State: AJcUukdK5tBeBapY5WHGqwRbKnGkrXuwMzmUfLa64VqOJO/+IDzJ8wlw gezyhh8+layH/CX7H9g7q20SIuYZ3LE= X-Received: by 2002:a24:9e87:: with SMTP id p129mr2017686itd.148.1548353294725; Thu, 24 Jan 2019 10:08:14 -0800 (PST) Received: from [192.168.1.158] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id x99sm11438742ita.23.2019.01.24.10.08.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 10:08:13 -0800 (PST) Subject: Re: [PATCH 0/2] small optimization for accessing queue map To: Jianchao Wang Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org References: <1548325533-1695-1-git-send-email-jianchao.w.wang@oracle.com> From: Jens Axboe Message-ID: <531e1343-a941-0137-e21c-036ca8dfbd5a@kernel.dk> Date: Thu, 24 Jan 2019 11:08:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1548325533-1695-1-git-send-email-jianchao.w.wang@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/24/19 3:25 AM, Jianchao Wang wrote: > Hi Jens > > These two patches are small optimization for accessing the queue mapping > in hot path. It saves the queue mapping results into blk_mq_ctx directly, > then we needn't do the complicated bounce on queue_hw_ctx[] map[] and > mq_map[]. I like this a lot, the current double indirect does suck, and it does show up in profiles as well. I'll run some testing with this, thanks! -- Jens Axboe