Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2324260imu; Thu, 24 Jan 2019 10:45:21 -0800 (PST) X-Google-Smtp-Source: ALg8bN7zCgOfbsNO9CinwcJHNBUk+/s6658tvxOG4wISGOCayigURQnOYAQY5e5fsMiPAyMX5PZ3 X-Received: by 2002:a17:902:fa2:: with SMTP id 31mr7736875plz.75.1548355521025; Thu, 24 Jan 2019 10:45:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548355520; cv=none; d=google.com; s=arc-20160816; b=dzg1w+clQeWPMAgQw241RkUaQd9KGJNTwmTJ+nvc3Kskfe4s76kqTLpMpxXtVZGCyl 6m26QS7dpuu2D/zo15JWgdZL0VdK0HMm+7k5v2T5zmadDU2yhNwmZuuY9akNyqqpDSqS LEYEafQ5hDOhy/42QYqWVcs+YeK3oDb/DGURzqUAeTmOyq4hz5TziHpHkbl+xVokTQC4 4Fl6txiup6esUB+/7WNzLfvj9ITN7tOuPw0tMi3XfTA7bGJffjAfhMaeuTxwP1JTc2NK u4qynan4Iy7b8c6zrNARYb+BqHIVjEKy1uHy8QooBj7dUmiT4PShiLyDE51fVgCfnYjU lwzA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=0+BsLDD8/YOaQq8MqSu0f5Z51J2TJE3PFkt3g7sgQT0=; b=EP9KvOEoMhSY8SQkV030N80nSZQxr9lA0KNrLnW1+VTAwOpp3UxalnArxtU/s3EyVz VYdxAAqMSimvBlTpvk6zm7ebtTdp5pOXhbRz9u2feF51UwoK3iaj5JKQm/Tri+dW8ouI XrWquTcGiAs2bpnDn9Zz4RnZAuj0c93NcKq0aSbYpAOBRhOBugI/BEBqFbfK272gWA6a 78tktV7glboqRzLj7lcnpbiqlzcCTYrvHxhCx5w37itE6KkSUjCc+xp2XFtMl33f9Wq8 uCcEdaGoenUjOixFY2icZNoNqia1MmNqFIKSReD4hjaWvu+M3YS5dmO++vZoBWTfhW6B TmgA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="v9fHLfP/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z22si22164949plo.202.2019.01.24.10.45.06; Thu, 24 Jan 2019 10:45:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="v9fHLfP/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728490AbfAXSoY (ORCPT + 99 others); Thu, 24 Jan 2019 13:44:24 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:56852 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725936AbfAXSoY (ORCPT ); Thu, 24 Jan 2019 13:44:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0+BsLDD8/YOaQq8MqSu0f5Z51J2TJE3PFkt3g7sgQT0=; b=v9fHLfP/rlkaDBq1qWL8npIlx +Yo13i3raaOxzFwkx317QpHYTfLzfs3PicYwKmYODoCFueaH/cCUlWIIw31JBEJN13LA6TneNHBOI J5za2v/fwjn3X7ghpsHdcNulNFam9xBOgM1U9eNJ7G5sPTxElLCC7t8Qd5a3IWZPZCJ+Q=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gmjz3-0006bM-EY; Thu, 24 Jan 2019 18:44:13 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id E1EBF1121B6F; Thu, 24 Jan 2019 18:44:12 +0000 (GMT) Date: Thu, 24 Jan 2019 18:44:12 +0000 From: Mark Brown To: Pierre-Louis Bossart Cc: Curtis Malainey , rohkumar@qti.qualcomm.com, alsa-devel@alsa-project.org, bgoswami@codeaurora.org, vinod.koul@linaro.org, linux-kernel@vger.kernel.org, plai@codeaurora.org, tiwai@suse.com, lgirdwood@gmail.com, Liam Girdwood , Matthias Reichl , Rohit kumar , srinivas.kandagatla@linaro.org, asishb@codeaurora.org, Ajit Pandey , Curtis Malainey , Dylan Reid Subject: Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component Message-ID: <20190124184412.GH5641@sirena.org.uk> References: <20190115000610.GM11073@sirena.org.uk> <796a856c-a9a6-022d-da63-947279090198@linux.intel.com> <20190115211137.rhdyjadu7fppp3p4@lenny.lan> <044d59ba-094e-727d-14a9-6ebfc54cbbf4@linux.intel.com> <44029078-2749-5a3b-7b03-f38461bf268f@linux.intel.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="Zi0sgQQBxRFxMTsj" Content-Disposition: inline In-Reply-To: <44029078-2749-5a3b-7b03-f38461bf268f@linux.intel.com> X-Cookie: Love America -- or give it back. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Zi0sgQQBxRFxMTsj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 22, 2019 at 08:01:15PM -0600, Pierre-Louis Bossart wrote: > changes are legitimate. To move forward, maybe it's not worth spending too > much time on a grand unification of string theory, there are simpler > solutions: the Intel machine drivers already do get the platform driver name > as an platform_data argument, so we could modify the dailinks platform names > before even registering the card. I tested with the attached Yes, that would be much better - it's vastly more idiomatic. The general idea is that a machine driver should know what it's expecting to find before it starts probing. --Zi0sgQQBxRFxMTsj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlxKB3wACgkQJNaLcl1U h9DWzAf+NtlimN/EneqIJgAU2m4qsSGsS9Mz520HmFrDdz20VvslFLxGcyQylwnY dytQj5u6mMW5FjRr1ZtxO/ILOPpuYU23IfhLmNkBdnCcPKNVZwO5YfoBA4tCnLS9 fh4A7gAXXxxPvwv22dQUzoj2O78yRGtNwmPl4r2Fz8cgUqqklLxpG1D/crEg3e0Y P6ghAMtQh0w72+9Op3rf9Cjhwuj7bXnvS+l4g9B9SkhAvUQX+9KCB3M/+bkSDuf6 m/ke2DVbmvi/w3VB2nscnAYt7XdnlzhG2siJl8Mj1CEIclBUte7s3qneDIPeSHvQ ojflN99K6KhrRzn6L0mH3ntAPU5h4w== =MyTR -----END PGP SIGNATURE----- --Zi0sgQQBxRFxMTsj--