Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190123175142.12604-1-matwey@sai.msu.ru>
In-Reply-To: <20190123175142.12604-1-matwey@sai.msu.ru>
From:   "Matwey V. Kornilov" <matwey.kornilov@gmail.com>
Date:   Thu, 24 Jan 2019 21:47:02 +0300
Message-ID: <CAJs94EaFU+9stV5CW138eLvxnERR9VRaoLDci86gDMRW63LNfA@mail.gmail.com>
Subject: Re: [PATCH] usb: musb: Fix potential NULL dereference
To:     Bin Liu <b-liu@ti.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     "open list:MUSB MULTIPOINT HIGH SPEED DUAL-ROLE CONTROLLER" 
        <linux-usb@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

By the way, why do we need to store the qh in urb->hcpriv?
qh can always be accessible through urb->ep->hcpriv
Wouldn't it be better to drop entire urb->hcpriv usage?

=D1=81=D1=80, 23 =D1=8F=D0=BD=D0=B2. 2019 =D0=B3. =D0=B2 20:52, Matwey V. K=
ornilov <matwey@sai.msu.ru>:
>
> We assign "urb->hcpriv =3D qh;" a few lines down. The valid qh for the ur=
b is
> hep->hcpriv in this code path.
>
> Fixes: 714bc5ef3eda ("musb: potential use after free")
> Signed-off-by: Matwey V. Kornilov <matwey@sai.msu.ru>
> ---
>  drivers/usb/musb/musb_host.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index c6118a962d37..6f267716768e 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -2336,7 +2336,7 @@ static int musb_urb_enqueue(
>                  * odd, rare, error prone, but legal.
>                  */
>                 kfree(qh);
> -               qh =3D NULL;
> +               qh =3D hep->hcpriv;
>                 ret =3D 0;
>         } else
>                 ret =3D musb_schedule(musb, qh,
> --
> 2.16.4
>


--=20
With best regards,
Matwey V. Kornilov