Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2406553imu; Thu, 24 Jan 2019 12:12:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN6qE7FDda1T/5npCz5FbytMM2GbHNi9LGfALuW23szTRl8TZOtDklwGQmLon9wW8EJn3cjG X-Received: by 2002:a17:902:e28e:: with SMTP id cf14mr8064413plb.311.1548360772631; Thu, 24 Jan 2019 12:12:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548360772; cv=none; d=google.com; s=arc-20160816; b=pzQH1dmla3/r0ToKE6DB2qG1+CXGqC11x3rNjAZoD+z5QiHkY2O3PY3qn+Nwja6OwP Bii0V9EIS2Jvh98n0mE+XzWky5/+yOaE8vrkueICpG/SRS/J+BbJe3qEpxp3o3UoP1XK UiP6OGGzK1nifDT7noFKM0QO1Qdrm//9oSwqiShPbaYI1gd6bZ8Na8YrftOMRQmmFGZ1 Rik/DuC7V89Kquvut7Xp4Ogjp8ySb2yXZu/yHD9XNqjTYZpHTZGWT1poZO7fsFnrPQT8 MEZWyLROQsYKeAD0H2GibnZ2jy4Jw8WkytrTzuyAu3q8dxWSSjcVJEXapE43dapOvimK Hosg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ghgBouyMlgr0hppUprLH+laQ2Q5C3qhKtj/1pgdB4Pk=; b=VRVsQR8AFRPFgqFv9ZadE8g+aLBycBm/3KFxpODYU/X2pl0U0tjSIZtbhBkUIVvJ7t I9rD1bYhvnCvNOAYwEIUQ4ZYsAuI50wFihcT4WIle2F/309j18u8hJgcYuWmOi1t84BA 0090mlst6GT95v4n5UENArToXY877qLZHuorZyFAiUas5gBuXvLyVJl+kvuaGcMXHF/B HuKRSHYk+uuIYNy10s2ER8D/gHcjZO5YiKoNJLyEFUvXWV/QqJDmmru7mOxXYfWxZTfB sR+1ytjOgBpQIuC8CXT8zQrEvoiyDhFJr+JLALMuhR8N7vSH1WFKF2HhXLtrmDgXIWiN DZOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=kXE5I3qa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id bd12si22703639plb.193.2019.01.24.12.12.37; Thu, 24 Jan 2019 12:12:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chrisdown.name header.s=google header.b=kXE5I3qa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chrisdown.name Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730331AbfAXUMa (ORCPT + 99 others); Thu, 24 Jan 2019 15:12:30 -0500 Received: from mail-yw1-f65.google.com ([209.85.161.65]:39920 "EHLO mail-yw1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729366AbfAXTZz (ORCPT ); Thu, 24 Jan 2019 14:25:55 -0500 Received: by mail-yw1-f65.google.com with SMTP id k188so2899685ywa.6 for ; Thu, 24 Jan 2019 11:25:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ghgBouyMlgr0hppUprLH+laQ2Q5C3qhKtj/1pgdB4Pk=; b=kXE5I3qaDTEG+JhQtUbG3LO27nMj4ayuUHaSuiitGKn3SJt8rI8Wq+4L/hlYG7wUAP jz1785z219Sj/gJwtJ6K3IzdfFYvYsu6E5xDUHLKCmAsuVPhNvX7FLE8amdVA5xh20Zu HN0fa/uED5Jtig1m8f5GPnKQ6jFmyewcoOTNU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ghgBouyMlgr0hppUprLH+laQ2Q5C3qhKtj/1pgdB4Pk=; b=elV2dF+bNsTmkjTnHJnvTJSzh+XbKBbuJ4gb2azFLkc2v/uWp2JLOSBN1IrD4IA9L9 gioqBw+eSLG4fOJSQU3mlbq2luSFlHRsabNke+4TxaHS+zGsTfBo/K9NV2EWGrygBQEr O+qNhOXVUllsvZna6lka6WTMvKEc78iFcJkJcaZxSEV67KFnZMDtocmiSCrn0M5mHkzc mE8QseYskWCjqJUK8xqwutC588QFzs29mUiptxiGA3U8vOBZmF/AnflecF/K6TXReEBi dHit9L4+bOm/z5sgFa+ecQiafyPhR7b4kJkudH1ttOvefIsdbq5zvuMrreNk2IvE3bv5 xOOw== X-Gm-Message-State: AJcUukdvxEoto6J+dWO8wSw8RAkeutyBzboIBOcZIrUISspU2bt3XIhl 93CF65ELwA+laJBpIlw8eStCRg== X-Received: by 2002:a81:b603:: with SMTP id u3mr7835793ywh.181.1548357953906; Thu, 24 Jan 2019 11:25:53 -0800 (PST) Received: from localhost ([2620:10d:c091:200::7:d7cc]) by smtp.gmail.com with ESMTPSA id p71sm14998747ywg.98.2019.01.24.11.25.53 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Thu, 24 Jan 2019 11:25:53 -0800 (PST) Date: Thu, 24 Jan 2019 14:25:52 -0500 From: Chris Down To: Johannes Weiner Cc: Andrew Morton , Tejun Heo , Roman Gushchin , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH] mm: Move maxable seq_file logic into a single place Message-ID: <20190124192552.GA27084@chrisdown.name> References: <20190124061718.GA15486@chrisdown.name> <20190124160935.GB12436@cmpxchg.org> <20190124165634.GA13549@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20190124165634.GA13549@chrisdown.name> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm going to abandon this patch in favour of a patch series which does it without macros, but still reduces code duplication fairly significantly. I'll send it out shortly.