Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2410368imu; Thu, 24 Jan 2019 12:16:35 -0800 (PST) X-Google-Smtp-Source: ALg8bN6JLXIv1K9omNaunBX4b6Ua2NNQni/9a8JN4omWguh3tAIBW1DcAGzG4GMKGZoEdUdCKBBB X-Received: by 2002:a17:902:48:: with SMTP id 66mr7724722pla.68.1548360995649; Thu, 24 Jan 2019 12:16:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548360995; cv=none; d=google.com; s=arc-20160816; b=PXjZ2UC05pYdy8ZB3YAXjQocH3f/trbTFX2zdsAFHdJJI5owPBXkY6hJOt/bMq4QoP uawpBHhlUKjnpzyDGXN7q0VKFaCa9Z0bA+Tge9xrmtPxxVahBPPqEDOkHKu+ylV6A5n8 dGOR1804ObjUB1QGc1pFl7+C8k09Eunl21TFdxvEMBGJmPVxNd498m7Jg/FUaxbZOSVJ ymihttfgVs7Q8P605nPFMPtEH4L5H2yVjmEJEQafomSUDEBoDOZQqSwhGjmHvXqcGFk0 KYEhXiNlo4RQHNxhXBnmQ2pdUmTHzhtJQYJLMLepVV8jcjJwWz3dtvuHLcXpPrhdObEv 1exA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=J0cO/69QxCvLfadCpmWlNKoQSKyO3NbjKUlbBGraGYE=; b=fgZ87CFuP3ipjhSfnlI/h7J6QzJYoxTcSMHITaflIZR/Ti/xVj78LLGD4XLvsWoRRT 6z9uIlgDI3JLF6gu4LJ6vBexkmUlp8JmuJMRsTYkIy4LAdQJLSg5R5UbsrMsVFAj+XxU BwOKqph0dxbtP0cPoFmvVoJ827s+yfXlKUzog/96OvtWLZ4R1gJeXzkXvjhiE4bh3ojj sJfOa52rqGMvMYEbA7iPbQkqF9npmF899KBy6hLs2TGqvlP3+XTaQvHcGv42J2SqPx6Y IHMC3bUIr/c7NTudLf3YZpl7SP7Mlb9o6RgF2LTelfnzjmnbSBenA0XPreZXVECJLCmC JS/A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bQcgcueu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p3si25032515pgi.0.2019.01.24.12.16.20; Thu, 24 Jan 2019 12:16:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=bQcgcueu; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730796AbfAXUPo (ORCPT + 99 others); Thu, 24 Jan 2019 15:15:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:49414 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729619AbfAXTYO (ORCPT ); Thu, 24 Jan 2019 14:24:14 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 818D2218EA; Thu, 24 Jan 2019 19:24:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548357854; bh=36NiZoxiQVL/d181ujMqa3FgplCu5TKdganrEwkC1dw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bQcgcueum4UK0Nb+SKMDBB2y7KOUO40XZv4NzuoCwEDrdVktCnuzKLwi5cM9U8Mbp c4MI86Wesmae6xCliZ5uMIfhTHTPIrC/WKn2HCv6L+v1uMjoW8JcNrh2wSL3i6y97P NnAmMbxylmRUZbCG9DMDB+b4FvvmUs0ET/sqgAG4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yunlei He , Jaegeuk Kim , Ben Hutchings Subject: [PATCH 4.4 012/104] f2fs: not allow to write illegal blkaddr Date: Thu, 24 Jan 2019 20:19:01 +0100 Message-Id: <20190124190156.240200220@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124190154.968308875@linuxfoundation.org> References: <20190124190154.968308875@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.4-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yunlei He commit bb413d6acd4e1c361daebf8486efc3923f429792 upstream. we came across an error as below: [build_nat_area_bitmap:1710] nid[0x 1718] addr[0x 1c18ddc] ino[0x 1718] [build_nat_area_bitmap:1710] nid[0x 1719] addr[0x 1c193d5] ino[0x 1719] [build_nat_area_bitmap:1710] nid[0x 171a] addr[0x 1c1736e] ino[0x 171a] [build_nat_area_bitmap:1710] nid[0x 171b] addr[0x 58b3ee8f] ino[0x815f92ed] [build_nat_area_bitmap:1710] nid[0x 171c] addr[0x fcdc94b] ino[0x49366377] [build_nat_area_bitmap:1710] nid[0x 171d] addr[0x 7cd2facf] ino[0xb3c55300] [build_nat_area_bitmap:1710] nid[0x 171e] addr[0x bd4e25d0] ino[0x77c34c09] ... ... [build_nat_area_bitmap:1710] nid[0x 1718] addr[0x 1c18ddc] ino[0x 1718] [build_nat_area_bitmap:1710] nid[0x 1719] addr[0x 1c193d5] ino[0x 1719] [build_nat_area_bitmap:1710] nid[0x 171a] addr[0x 1c1736e] ino[0x 171a] [build_nat_area_bitmap:1710] nid[0x 171b] addr[0x 58b3ee8f] ino[0x815f92ed] [build_nat_area_bitmap:1710] nid[0x 171c] addr[0x fcdc94b] ino[0x49366377] [build_nat_area_bitmap:1710] nid[0x 171d] addr[0x 7cd2facf] ino[0xb3c55300] [build_nat_area_bitmap:1710] nid[0x 171e] addr[0x bd4e25d0] ino[0x77c34c09] One nat block may be stepped by a data block, so this patch forbid to write if the blkaddr is illegal Signed-off-by: Yunlei He Signed-off-by: Jaegeuk Kim Signed-off-by: Ben Hutchings Signed-off-by: Greg Kroah-Hartman --- fs/f2fs/segment.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/fs/f2fs/segment.h +++ b/fs/f2fs/segment.h @@ -576,8 +576,8 @@ static inline void check_seg_range(struc static inline void verify_block_addr(struct f2fs_sb_info *sbi, block_t blk_addr) { - f2fs_bug_on(sbi, blk_addr < SEG0_BLKADDR(sbi) - || blk_addr >= MAX_BLKADDR(sbi)); + BUG_ON(blk_addr < SEG0_BLKADDR(sbi) + || blk_addr >= MAX_BLKADDR(sbi)); } /*