Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2456751imu; Thu, 24 Jan 2019 13:08:25 -0800 (PST) X-Google-Smtp-Source: ALg8bN59FCfsz+tBDRkyDvMh2QEvT9qEYzHLnVL3SFN7rnimw4vgWfc0IlfPUuKtJOq7zADcQDCR X-Received: by 2002:a63:a30a:: with SMTP id s10mr806070pge.234.1548364105728; Thu, 24 Jan 2019 13:08:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548364105; cv=none; d=google.com; s=arc-20160816; b=YiTlU0D6OhPsKG2u4uOEWEcyfT7ZVOCCAmAFS3TSi3+O/guxfjx0w2f/f8EDhAxEpP tXbimUn6Z8cF76iOTLmAD05TgcUrFFiekRq7OBP1HfzfdDAWddyN1LQATui8gR3tXX7v 781dR40EuOil2u8xlTwxJGc2pWDTh1peLn5vtzIWYDOrB34YjOSnQaCbm1Q7i6dYH+eH bHttdpetw2m1SikvEhp8otE3sHQFL7/1lPK2QjwxxNCF/c4fyi3WHw/HK4pVaQeGBzIq wUdnfZl3PfWrtnic96gcyr9taCs0mhF92syPxvsdHPLZtEVRdFUqnEIdbX3ayQke3jcu UgcQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=OqGHVdPHhqlnaUTKgdp/mUrDEf8sAnSVJHoqZehhWXs=; b=0LQ2VsBSMsN6N1bn8pRFAW/A0rzuu7nxCE6cWQUsgMJySaE/UQXkFzvc9qsM+lZrR0 F8c/Q6nU4Mf8gLmyfedEgzni3s8MEKidyca/PS/tgg1TjmftTdpr65FJHGB6PEYVY/nS 9+2SJvkxyd7hgsuvWXv0LCcKkyebXzaNAoEByVRXPr6itFHwLRPtHmKvdSNPrQBlKifH jXJ0BvHTQjpvvbUTB+yRjJ/stK0Tb5S6HePH60egjhvE3ER7pMB5ca5i1BhC37rBQL/l Y+PNeTFoZLBTTZmIadWPQ8YTBRlOTHunoI59pRXUD1vfLnFjJtn9cf36Yf1T25k6FJLy aZ0g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u69si23173139pfj.219.2019.01.24.13.08.09; Thu, 24 Jan 2019 13:08:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727719AbfAXVIE (ORCPT + 99 others); Thu, 24 Jan 2019 16:08:04 -0500 Received: from mga11.intel.com ([192.55.52.93]:26608 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbfAXVIE (ORCPT ); Thu, 24 Jan 2019 16:08:04 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Jan 2019 13:08:03 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,518,1539673200"; d="scan'208";a="141073644" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by fmsmga001.fm.intel.com with ESMTP; 24 Jan 2019 13:08:01 -0800 Received: from andy by smile with local (Exim 4.92-RC4) (envelope-from ) id 1gmmEB-0005QQ-S1; Thu, 24 Jan 2019 23:07:59 +0200 Date: Thu, 24 Jan 2019 23:07:59 +0200 From: Andy Shevchenko To: Phil Edworthy Cc: Michael Turquette , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Stephen Boyd , Russell King , Geert Uytterhoeven , "linux-clk@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v9 1/2] clk: Add comment about __of_clk_get_by_name() error values Message-ID: <20190124210759.GM9224@smile.fi.intel.com> References: <20181203111309.3709-1-phil.edworthy@renesas.com> <20181203111309.3709-2-phil.edworthy@renesas.com> <20181203133040.GN10650@smile.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 16, 2019 at 03:18:42PM +0000, Phil Edworthy wrote: > Hi, > > Any other comments on this patch and patch 2/2 (https://lkml.org/lkml/2018/12/3/326)? Was on vacations, sorry. > > > I would start new sentence from new line (this will emphasize the > > > possible > > > variants) > > > > > > * This is ... > > I disagree, the explanation is specifically related to the case where the > > function returns -EINVAL. Though this is a nit, so I'm not really bothered > > either way. Ah, okay. You may bear my tags on. -- With Best Regards, Andy Shevchenko