Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [PATCH] Bluetooth: hci_ldisc: Fix for pty driver
From:   Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <20190125035510.GA21654@myunghoj-Precision-5530>
Date:   Fri, 25 Jan 2019 08:42:02 +0100
Cc:     Johan Hedberg <johan.hedberg@gmail.com>,
        linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 7bit
Message-Id: <51535426-2591-4246-8425-65B3B1770955@holtmann.org>
References: <20190125035510.GA21654@myunghoj-Precision-5530>
To:     Myungho Jung <mhjungk@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Myungho,

> tty_set_termios() should be called with slave side of pty driver. So, If
> tty driver is pty master, it needs to be switched to ->link. Also,
> tiocmget() and tiocmset() operations are optional so we need NULL check
> for some drivers missing the operations like pty.

these are two independent fixes. Please turn them into two patches.

Regards

Marcel