Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] lightnvm: pblk: fix TRACE_INCLUDE_PATH
To:     Hans Holmberg <hans.ml.holmberg@owltronix.com>,
        Masahiro Yamada <yamada.masahiro@socionext.com>
Cc:     linux-block@vger.kernel.org, Jens Axboe <axboe@kernel.dk>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
References: <1548401030-28860-1-git-send-email-yamada.masahiro@socionext.com>
 <CANr-nt0=gw90vBLA_FMjmD7duNVYJcGmcqfk9HiQpdKxHV-A+g@mail.gmail.com>
From:   =?UTF-8?Q?Matias_Bj=c3=b8rling?= <mb@lightnvm.io>
Message-ID: <17453c37-72ee-11e1-979d-e60a034d94e3@lightnvm.io>
Date:   Fri, 25 Jan 2019 09:17:54 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <CANr-nt0=gw90vBLA_FMjmD7duNVYJcGmcqfk9HiQpdKxHV-A+g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/25/19 9:01 AM, Hans Holmberg wrote:
> On Fri, Jan 25, 2019 at 8:35 AM Masahiro Yamada
> <yamada.masahiro@socionext.com> wrote:
>>
>> As the comment block in include/trace/define_trace.h says,
>> TRACE_INCLUDE_PATH should be a relative path to the define_trace.h
>>
>> ../../drivers/lightnvm is the correct relative path.
>>
>> ../../../drivers/lightnvm is working by coincidence because the top
>> Makefile adds -I$(srctree)/arch/$(SRCARCH)/include as a header
>> search path, but we should not rely on it.
> 
> Nice catch, thanks!
> 
> Reviewed-by: Hans Holmberg <hans.holmberg@cnexlabs.com>
> 
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> ---
>>
>>   drivers/lightnvm/pblk-trace.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/lightnvm/pblk-trace.h b/drivers/lightnvm/pblk-trace.h
>> index 679e5c45..9534503 100644
>> --- a/drivers/lightnvm/pblk-trace.h
>> +++ b/drivers/lightnvm/pblk-trace.h
>> @@ -139,7 +139,7 @@ TRACE_EVENT(pblk_state,
>>   /* This part must be outside protection */
>>
>>   #undef TRACE_INCLUDE_PATH
>> -#define TRACE_INCLUDE_PATH ../../../drivers/lightnvm
>> +#define TRACE_INCLUDE_PATH ../../drivers/lightnvm
>>   #undef TRACE_INCLUDE_FILE
>>   #define TRACE_INCLUDE_FILE pblk-trace
>>   #include <trace/define_trace.h>
>> --
>> 2.7.4
>>

Thanks Masahiro-san. Applied for 5.1.