Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp412790imu; Fri, 25 Jan 2019 04:38:13 -0800 (PST) X-Google-Smtp-Source: ALg8bN5EarTJueALJY+tRBrDgIPQoYa9Re1GMgiT5gRJr+mafnBSidpQ5W8Dy/8caAldb2MAf76Y X-Received: by 2002:a63:7d06:: with SMTP id y6mr9759474pgc.171.1548419893905; Fri, 25 Jan 2019 04:38:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548419893; cv=none; d=google.com; s=arc-20160816; b=hVh8xB0HSQQctbqC68prw5dvyT4TVvSErlTwvBTpDebHqZKwqsT28yjVmkJbYGXtyY zDgJsJOFUrjSelh93Vvrx7t4ja2RMk0ETWMqMPGBZjsETICP2eiv1bbVsR6NAe3tLY3a 7pJkHCsvYbrTTUWvdapxK/YKwKYvsIQqvC9C9conEpb5OxxbEXJXfbNpUetGwWiNUx9T 1Xy6xpCrMpXe/EfC2ViGn7hzwAO+V2e3HVmmZYW+MNMVbfYiIKNUHSiw8W9Sz286JU40 vWTHlylxjJ497YCLSLWW2rK7c7AU9gkRWa+Yxtd9Nu8GCeNn1YSCeoh2nTXkOXJxLAU8 y7ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=/siabg5cv9OPKbEJrm6DglYv+O02BKsmmxPC0duiDpQ=; b=v4mWFZ8qO3VRbxrFMMccml6Qa7eI8X49I8SdD4PL8BB5wH4GtZF52bmeQKWDrZ7iJU +PluFKIt5GXQ6e9odypGHEmlaydYTHHPAfH4eG7w1kLeYgIMmQNW76mj53+CTrUXGHyJ YINM1agS+2XCP7MUNr386uSTcvPqG+Cd6MlnaZJKhzrzgD3AVQk3ZXdKaCDC/LNkWqTK b3KaMHwmOTFn/ydIeWBbGpAcEm3YslRpvhMIuNUkQjTmqF4icIexQ0OoJQHtu0Kw04k8 DYKZPmbCuLvh1Rbi0bnsLDsVYrwvFr5dkAhecVMDAzwHt/HKJajaEPutCv0LNL2n1R1d v/rQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m3si8375477pgs.8.2019.01.25.04.37.58; Fri, 25 Jan 2019 04:38:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728780AbfAYMhl convert rfc822-to-8bit (ORCPT + 99 others); Fri, 25 Jan 2019 07:37:41 -0500 Received: from mail.bootlin.com ([62.4.15.54]:49293 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfAYMhk (ORCPT ); Fri, 25 Jan 2019 07:37:40 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 55474209BE; Fri, 25 Jan 2019 13:37:38 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT, URIBL_BLOCKED shortcircuit=ham autolearn=disabled version=3.4.2 Received: from xps13 (aaubervilliers-681-1-87-206.w90-88.abo.wanadoo.fr [90.88.29.206]) by mail.bootlin.com (Postfix) with ESMTPSA id 13225207AD; Fri, 25 Jan 2019 13:37:28 +0100 (CET) Date: Fri, 25 Jan 2019 13:37:28 +0100 From: Miquel Raynal To: Masahiro Yamada Cc: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , linux-kernel@vger.kernel.org, Marek Vasut , Richard Weinberger , David Woodhouse , Boris Brezillon Subject: Re: [PATCH v2] mtd: rawnand: remove ->legacy.erase and single_erase() Message-ID: <20190125133728.07ad39a7@xps13> In-Reply-To: <1548052327-26483-1-git-send-email-yamada.masahiro@socionext.com> References: <1548052327-26483-1-git-send-email-yamada.masahiro@socionext.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, Masahiro Yamada wrote on Mon, 21 Jan 2019 15:32:07 +0900: > Now that the last user of this hook, denali.c, stopped using it, > we can remove the erase hook from nand_legacy. > > I squashed single_erase() because only the difference between > single_erase() and nand_erase_op() is the number of bit shifts. > > The status/ret conversion in nand_erase_nand() is unneeded since > commit eb94555e9e97 ("mtd: nand: use usual return values for the > ->erase() hook"). Cleaned it up now. > > Signed-off-by: Masahiro Yamada > --- Applied to nand/next. Thanks, Miquèl