Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp413149imu; Fri, 25 Jan 2019 04:38:38 -0800 (PST) X-Google-Smtp-Source: ALg8bN7sSBfYJB8VvZDPP59vA8PB0E18GOt2hZxNh/mFODI2rWEMc/Vy9yF0tQdVgZAJZiSb4111 X-Received: by 2002:a62:61c3:: with SMTP id v186mr10924239pfb.55.1548419918122; Fri, 25 Jan 2019 04:38:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548419918; cv=none; d=google.com; s=arc-20160816; b=Wrfx+d00T3qt6nrMQktSxahhmtk2KK1xDMpz0hsPf0QhNCQ0xc3by16OtjnlH929K6 n2Owq04U4SUiU7wGSDokN8WUawdyITgHLrxs3jrmq+kxr2EK2BFvCrD7glEvwWa06nz8 NVFxLZuXTkotFu/ihdMCHOncyOkFqy6M1kyRVmNutfS9jAwMFzPpwg0ympmCIRVCGiTA qTIFdxqlRouKD/wAhwQjM7wBCW76AqCijdAWdak4F2dUwikfnuLeYoOhoa+Q57Pl8ej2 lSl8wWMSirPWw9sQWmmntko7p9JaBFgerTvi1jk+XxLMdRML6W1PWrCM22bbpxbaJ5Oo EUTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=HYdQUntSbylDwGx09u7RdqTodwig1KJ6O5xVNQlPIa4=; b=ED+7NA9Pk3fFxqwTUrDo/SMfQRcUor1Co6JhP/+dVj/KFinqvjRtHMLT41bQ5bHmtz VeklAn0j3NUKzBBt/ZhNF2udYMIdEWIdEoe6ofhjo3DV4UpYyBo2/ZID8yFa1oXL1EDN xcf0TQTrtMuXbzcOvrj8X2wxxe5ruJnUvORamJ2PqAI/a0x+6s8KCL9jCX0C5vdokFti 5fLoMBSdz26j4MGCn1cL4kaLt6AyacLfwP8mX2WEnq1kGdp8bRCpSO8YZgICzJwkwZ62 BUjP1+8KTN6d7FMxbzk4d54w6jWj2HzE5SI0MRFHMD6dr9jLtDzo6dSTBmOovw6DyEvX aVMQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n20si4932416plp.294.2019.01.25.04.38.23; Fri, 25 Jan 2019 04:38:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727959AbfAYMhK convert rfc822-to-8bit (ORCPT + 99 others); Fri, 25 Jan 2019 07:37:10 -0500 Received: from mail.bootlin.com ([62.4.15.54]:49254 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726095AbfAYMhK (ORCPT ); Fri, 25 Jan 2019 07:37:10 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 542BD209BF; Fri, 25 Jan 2019 13:37:08 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail.bootlin.com X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,SHORTCIRCUIT shortcircuit=ham autolearn=disabled version=3.4.2 Received: from xps13 (aaubervilliers-681-1-87-206.w90-88.abo.wanadoo.fr [90.88.29.206]) by mail.bootlin.com (Postfix) with ESMTPSA id 15B4A207B0; Fri, 25 Jan 2019 13:36:58 +0100 (CET) Date: Fri, 25 Jan 2019 13:36:58 +0100 From: Miquel Raynal To: Masahiro Yamada Cc: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , linux-kernel@vger.kernel.org, Marek Vasut , Richard Weinberger , David Woodhouse , Boris Brezillon Subject: Re: [PATCH] mtd: rawnand: denali: remove ->erase hook Message-ID: <20190125133658.540b19fa@xps13> In-Reply-To: <1548046326-26776-1-git-send-email-yamada.masahiro@socionext.com> References: <1548046326-26776-1-git-send-email-yamada.masahiro@socionext.com> Organization: Bootlin X-Mailer: Claws Mail 3.17.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, Masahiro Yamada wrote on Mon, 21 Jan 2019 13:52:06 +0900: > Commit f9ebd1bb4103 ("mtd: rawnand: Deprecate ->erase()") discouraged > the use of this hook, so I am happy to follow the suggestion. > > Although the Denali IP provides a special MAP10 command for erasing, > using it would not buy us much. The Denali IP actually works with the > generic erasing by single_erase() + ->cmdfunc hook (nand_command_lp) > + ->cmd_ctrl hook (denali_cmd_ctrl). > > This method is also deprecated, but denali_erase() can go away > irrespective of ->exec_op conversion. > > Signed-off-by: Masahiro Yamada Applied to nand/next. Thanks! Miquèl