Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1547765160-15502-1-git-send-email-eugene.loh@oracle.com>
In-Reply-To: <1547765160-15502-1-git-send-email-eugene.loh@oracle.com>
From:   Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date:   Fri, 25 Jan 2019 14:28:48 +0100
Message-ID: <CAKv+Gu8BeYsq-_7KiANOjSN2fp25BP=71uLqKnkkYYJdhD2Bfw@mail.gmail.com>
Subject: Re: [PATCH] Kbuild: Handle too long symbols in kallsyms.c
To:     eugene.loh@oracle.com
Cc:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andi Kleen <ak@linux.intel.com>, andi@firstfloor.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 17 Jan 2019 at 23:46, <eugene.loh@oracle.com> wrote:
>
> From: Eugene Loh <eugene.loh@oracle.com>
>
> When checking for symbols with excessively long names,
> account for null terminating character.
>
> Fixes: f3462aa952cf ("Kbuild: Handle longer symbols in kallsyms.c")
> Signed-off-by: Eugene Loh <eugene.loh@oracle.com>

Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  scripts/kallsyms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 77cebad..f75e7bd 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -118,8 +118,8 @@ static int read_symbol(FILE *in, struct sym_entry *s)
>                         fprintf(stderr, "Read error or end of file.\n");
>                 return -1;
>         }
> -       if (strlen(sym) > KSYM_NAME_LEN) {
> -               fprintf(stderr, "Symbol %s too long for kallsyms (%zu vs %d).\n"
> +       if (strlen(sym) >= KSYM_NAME_LEN) {
> +               fprintf(stderr, "Symbol %s too long for kallsyms (%zu >= %d).\n"
>                                 "Please increase KSYM_NAME_LEN both in kernel and kallsyms.c\n",
>                         sym, strlen(sym), KSYM_NAME_LEN);
>                 return -1;
> --
> 1.8.3.1
>