Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp479171imu; Fri, 25 Jan 2019 05:46:42 -0800 (PST) X-Google-Smtp-Source: ALg8bN63dUTUAtwjvFTHexLh41QJ5uGwmO1bmcfoncvSPXvF8CCIkxP++zXyAup2pgjETe12Xc/i X-Received: by 2002:a62:5910:: with SMTP id n16mr10889391pfb.128.1548424002078; Fri, 25 Jan 2019 05:46:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548424002; cv=none; d=google.com; s=arc-20160816; b=0SD+++mvx/nNwkr5RiVORr2xXYYTtUc0XLj4QfcKMxKSMpHKFDd02TZ22jri7mRqIg CNbtiHELK4X+aH6okr6WvawDvNsmgkmzeJY73P/xaLKtxmfTymapxDRXpd95mynWgKul jbKtVGLMMop7ppa3SCzB1FYv4hZhUDZkHZ6PpWdAdglYNGmzhxIFXf8G2JgKPhPySXIC IvuhZDxTv0ZUzp8lHsFV/k1xcin5P2WwnsxS0BTznnWhfAGZOvl6ofYvUOHKtjwjXiD7 2qvuEuYguiFKQUd9UrC2fukcNx4vVxVFXvPkSk3t/nxkw5PxLYGsbJY/32+lmNQ3tYPW Ebhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=1XhtPK0wxtOKVcos4M93aHjiRJbmgiUIP656VkwGQsk=; b=SN5Sr/j0m7eBeP/r8mwKaLpnpAXRjyJDiLlBDxccaM9rskjJjSlLGRTNzdKUEu1oHx 1JaSHWZN6IPbln1p15bfrOVo6J0rMiMyIHOa4E3gNa+kEyiSliuy5Px+I5Y4nBoXgeg8 DP+z1Q5ZuDk3NJXYIyvSGfCNFZzcg4DDNqYMKPRZU7vd00AAH4KHPmvfGVeBI2se76Z6 Upp/YU4q4AIeknxfWCj7ej5p5V2zaoWJhKqvqwkLUi2UJpR3uR9Rg7TVCAtAa+3umLbg ysO8CtXBNPymcDIwPWuoTcQk/uG8MTBZG4BPyobHp63CQzVqhjxiZaVet0x0S6RvEKJ5 eUew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l7si24868801pfb.31.2019.01.25.05.46.27; Fri, 25 Jan 2019 05:46:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728550AbfAYNqD (ORCPT + 99 others); Fri, 25 Jan 2019 08:46:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53320 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726252AbfAYNqC (ORCPT ); Fri, 25 Jan 2019 08:46:02 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A285A37EEA; Fri, 25 Jan 2019 13:46:02 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.163]) by smtp.corp.redhat.com (Postfix) with SMTP id 3C68D177CE; Fri, 25 Jan 2019 13:46:01 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Fri, 25 Jan 2019 14:46:01 +0100 (CET) Date: Fri, 25 Jan 2019 14:46:00 +0100 From: Oleg Nesterov To: Roman Gushchin Cc: Tejun Heo , kernel-team@fb.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Roman Gushchin Subject: Re: [PATCH v6 4/7] cgroup: cgroup v2 freezer Message-ID: <20190125134600.GB18991@redhat.com> References: <20181222000307.28231-1-guro@fb.com> <20181222000307.28231-5-guro@fb.com> <20190125122713.GA18218@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190125122713.GA18218@redhat.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 25 Jan 2019 13:46:02 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25, Oleg Nesterov wrote: > > One of the task is killed, it calls leave_frozen(). If I read this code path > correctly, only ->nr_frozen_tasks will be decremented, so "frozen" will be > "false" when cgroup_update_frozen() is called. forgot to mention... and I do not think cgroup_exit() can "fix" this, see another email I sent a minute ago... Oleg.