Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp748375imu; Fri, 25 Jan 2019 10:14:14 -0800 (PST) X-Google-Smtp-Source: ALg8bN7gmD2tgpPqAjuD/Xlz+L61opRV5Z9jSLht5rJ2Rv14Ay4cbPmWciN0df/LWRDd59WcDx5S X-Received: by 2002:a17:902:ab84:: with SMTP id f4mr11741813plr.207.1548440053986; Fri, 25 Jan 2019 10:14:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548440053; cv=none; d=google.com; s=arc-20160816; b=yXLAYAz0uSLX44J1Tly4cnUKN8grz2mj+OfKB85YUtO95oGmlDyvCJ47U20JkST04H FWxpWwoDeGXWKjryaO5UJpr/A7+ZExNPqyMS1RvNwn34VNN7G/lhhEJpMwY46gfaM7Gp FWW3FAh4tTqCdoLAhdf5zsXV4JlAcVAuCrMcQPn6Qo4WT3fx3hbHH2tQ4FPEHDjJXpNb qzgJ9Fw3I2LMe/nA3I+p2zLUyoC2FRquQ/PcIaavo+WoiI1khvOzCDPWOy1adlEJMtnd FqUIVtAAGPoVvrqBrnUVOisVcmoHbBGO/vaIyEhERGk5nxQGF5b1MwkGvqbl3Mqnzc+w bKmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=FhNby6SX27fh2UU58LUmmCuuZS0pQdOgU0orLlToT7E=; b=IcotTQ0mCJONkNsPn5/x0TNy2l0ho6NsbbT0eujkV/t2Kr1yLVQxcLtdmmIITW65nX kMO/OzsiHGXMRh5yVLaJuiT0HTzwUrZbC4hrvpHglXn92lO4hK0/817LXJZbMIs5B9Rk mNHr2mlirUfLEAQDdXIAVmzYvdBuTAZoVBRLfKduNEZM8LtVc604PUs5Ep1DW51aJPo5 EElbhcnKsA/DVxT7NV2ViwTBSNTB/b0P3ne1WlOt3D7ZXsV7DStCUy59h0QUf0ljQLWb ALpdcP0fzF3/5Xi4r38xtQyeHBFj+BV4lMnQCcDq8/jHZ//T4KI/JkQZHUmCEZRQsNJT smbw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 44si17927plc.110.2019.01.25.10.13.58; Fri, 25 Jan 2019 10:14:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729361AbfAYSNG (ORCPT + 99 others); Fri, 25 Jan 2019 13:13:06 -0500 Received: from foss.arm.com ([217.140.101.70]:52260 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726273AbfAYSNF (ORCPT ); Fri, 25 Jan 2019 13:13:05 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A46A7EBD; Fri, 25 Jan 2019 10:13:04 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.196.113]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2AD4F3F5C1; Fri, 25 Jan 2019 10:13:03 -0800 (PST) Date: Fri, 25 Jan 2019 18:13:00 +0000 From: Catalin Marinas To: Greg Kroah-Hartman Cc: Kevin Hilman , Russell King , Will Deacon , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Peng Donglin Subject: Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions Message-ID: <20190125181300.GN25901@arrakis.emea.arm.com> References: <20190122144114.9816-1-gregkh@linuxfoundation.org> <20190122144114.9816-2-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190122144114.9816-2-gregkh@linuxfoundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Catalin Marinas > Cc: Will Deacon > Cc: Marc Zyngier > Cc: Peng Donglin > Cc: > Signed-off-by: Greg Kroah-Hartman Acked-by: Catalin Marinas