Message-ID: <99F2150714F93F448942F9A9F112634C109A3935@txexmtae.amd.com>
From: paul.devriendt@amd.com
To: pavel@suse.cz, davej@redhat.com, cpufreq@www.linux.org.uk,
       linux-kernel@vger.kernel.org, davej@codemonkey.ork.uk
Subject: RE: powernow-k8-acpi driver
Date: Wed, 3 Mar 2004 17:57:35 -0600
MIME-Version: 1.0
Content-Type: text/plain
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 817
Lines: 27

> One more thing: is there any reason for "use-array-as-struct"?
> 
> static int query_current_values_with_pending_wait(u8 *perproc) { ...
>         perproc[PP_OFF_CVID] = hi & MSR_S_HI_CURRENT_VID;
>         perproc[PP_OFF_CFID] = lo & MSR_S_LO_CURRENT_FID; }
> 
> having 
> 
> struct cpu_power {
> 	int numps, share, cvid, cfid;
> 	char pstates[0];
> }
> 
> should do the trick...
> 							Pavel

Yes, I could get rid off the PP_OFF_crud using something like you
suggest. I'll do that while I am also doing the back port and get
them both out next week sometime.

Paul.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/