Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1548358316-8062-1-git-send-email-rodrigorsdc@gmail.com>
 <CA+U=DsqG6PKs1Off9QP_3_q+c5=uzRypHCs+O6iur=NC5QdDdQ@mail.gmail.com> <CAOeBkLogWyxbB3ZNwZh9=6xVUKxmT1YGZQseAx4uo7a4u+M+gw@mail.gmail.com>
In-Reply-To: <CAOeBkLogWyxbB3ZNwZh9=6xVUKxmT1YGZQseAx4uo7a4u+M+gw@mail.gmail.com>
From:   Rodrigo Ribeiro <rodrigorsdc@gmail.com>
Date:   Fri, 25 Jan 2019 22:14:32 -0200
Message-ID: <CAOeBkLq18nP6xsOCNNE2Bew=u37MsLCgH=W-8ofnFSAi6dYx=Q@mail.gmail.com>
Subject: Re: [PATCH] staging:iio:ad7152: Rename misspelled RESEVERD -> RESERVED
To:     Alexandru Ardelean <ardeleanalex@gmail.com>
Cc:     lars@metafoo.de, Michael.Hennerich@analog.com,
        Jonathan Cameron <jic23@kernel.org>, knaack.h@gmx.de,
        Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
        gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
        kernel-usp@googlegroups.com, Rafael Tsuha <rafael.tsuha@usp.br>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em sex, 25 de jan de 2019 =C3=A0s 21:46, Rodrigo Ribeiro
<rodrigorsdc@gmail.com> escreveu:
>
> Em sex, 25 de jan de 2019 =C3=A0s 06:20, Alexandru Ardelean
> <ardeleanalex@gmail.com> escreveu:
> >
> > On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro <rodrigorsdc@gmail.com>=
 wrote:
> > >
> > > Remove the checkpatch.pl check:
> > >
> > > CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'?
> >
> > Hey,
>
> Hi,
>
> Thanks for answering.
>
> > A bit curios about this one.
> > Are you using this chip/driver ?
>
> No, I am just a student at USP (University of S=C3=A3o Paulo) starting in=
 Linux
> Kernel and a new member of the USP Linux Kernel group that has contribute=
d
> for a few months.
>
> > Thing is: the part is nearing EOL, and it could be an idea to be
> > marked for removal (since it's still in staging).
> > But if there are users for this driver, it could be left around for a w=
hile.
>
> This is my first patch in Linux Kernel, but if the driver will be removed=
, I
> can send a patch for another driver. Is there any driver that I can
> fix a style warning?

Maybe, one checkstyle patch is enough, right? Which drivers can I truly
contribute to?

> Thanks
>
>
> Em sex, 25 de jan de 2019 =C3=A0s 06:20, Alexandru Ardelean
> <ardeleanalex@gmail.com> escreveu:
> >
> > On Thu, Jan 24, 2019 at 9:35 PM Rodrigo Ribeiro <rodrigorsdc@gmail.com>=
 wrote:
> > >
> > > Remove the checkpatch.pl check:
> > >
> > > CHECK: 'RESEVERD' may be misspelled - perhaps 'RESERVED'?
> >
> > Hey,
> >
> > A bit curios about this one.
> > Are you using this chip/driver ?
> >
> > Thing is: the part is nearing EOL, and it could be an idea to be
> > marked for removal (since it's still in staging).
> > But if there are users for this driver, it could be left around for a w=
hile.
> >
> > Thanks
> > Alex
> >
> > >
> > > Signed-off-by: Rodrigo Ribeiro <rodrigorsdc@gmail.com>
> > > Signed-off-by: Rafael Tsuha <rafael.tsuha@usp.br>
> > > ---
> > > This macro is not used anywhere. Should we just correct the
> > > spelling or remove the macro?
> > >
> > >  drivers/staging/iio/cdc/ad7152.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/staging/iio/cdc/ad7152.c b/drivers/staging/iio/c=
dc/ad7152.c
> > > index 25f51db..c9da6d4 100644
> > > --- a/drivers/staging/iio/cdc/ad7152.c
> > > +++ b/drivers/staging/iio/cdc/ad7152.c
> > > @@ -35,7 +35,7 @@
> > >  #define AD7152_REG_CH2_GAIN_HIGH       12
> > >  #define AD7152_REG_CH2_SETUP           14
> > >  #define AD7152_REG_CFG                 15
> > > -#define AD7152_REG_RESEVERD            16
> > > +#define AD7152_REG_RESERVED            16
> > >  #define AD7152_REG_CAPDAC_POS          17
> > >  #define AD7152_REG_CAPDAC_NEG          18
> > >  #define AD7152_REG_CFG2                        26
> > > --
> > > 2.7.4
> > >