Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Marek Vasut <marek.vasut@gmail.com>
Subject: Re: [PATCH v7 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller
 driver
To:     masonccyang@mxic.com.tw
Cc:     bbrezillon@kernel.org, broonie@kernel.org,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Simon Horman <horms@verge.net.au>, juliensu@mxic.com.tw,
        linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
        linux-spi@vger.kernel.org, sergei.shtylyov@cogentembedded.com,
        zhengxunli@mxic.com.tw
References: <1548227352-14910-1-git-send-email-masonccyang@mxic.com.tw>
 <1548227352-14910-2-git-send-email-masonccyang@mxic.com.tw>
 <bb63b646-b549-dc3b-a604-17ba156e735c@gmail.com>
 <OF767ACC95.EECC73BE-ON4825838C.000BD6A3-4825838C.000D23A6@mxic.com.tw>
 <67fa5f94-886b-f09c-c93d-832e427ffec8@gmail.com>
 <OF891E176A.614DBEEF-ON4825838C.0022D454-4825838C.002396ED@mxic.com.tw>
Openpgp: preference=signencrypt
Message-ID: <0b3ea94f-a4f3-0780-301b-f88ff2ad2fb1@gmail.com>
Date:   Sat, 26 Jan 2019 10:41:07 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <OF891E176A.614DBEEF-ON4825838C.0022D454-4825838C.002396ED@mxic.com.tw>
Content-Type: text/plain; charset=big5
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/24/19 7:28 AM, masonccyang@mxic.com.tw wrote:
> Hi Marek,

Hi,

>> "Marek Vasut" <marek.vasut@gmail.com>
>> 2019/01/24 ?W?? 11:14
>> >>
>> >> > +module_platform_driver(rpc_spi_driver);
>> >>
>> >> RPC is not a SPI controller, it's a SPI and HF controller.
>> >>
>> >> Also, how difficult will it be to add the HF support ?
>> >
>> > One of my customers needs RPC SPI driver for our company's
>> > Octal-Flash,MX25UW51245G.
>> > We don't have HF product and hope you could understanding.
>>
>> I am worried that when we need to add RPC HF support (which is what all
>> boards but the D3 Draak use), we will have to rewrite the entire driver
>> and/or convert it to MFD and that would be a tremendous undertaking. I'd
>> prefer to have the driver ready for the HF addition before it's accepted
>> upstream.
>>
> 
> I think maybe your concerned would be happened only if HF driver goes with
> spi-mem layer.
> 
> A comment for HF from Daniel Fishman. FYR.
> 
> https://www.quora.com/What-is-a-hyper-flash-memory-and-how-is-it-different-from-normal-flash-memory

I have a decent idea what HF and SPI NOR are, since I wrote the RPC
driver for both HF and SPI mode for U-Boot (as I mentioned earlier).

The HF in Linux would use the CFI NOR part of MTD framework. My concern
is that when we need to add HF support into this driver, this driver
will have to be basically rewritten, since the architecture won't allow
for that. I'd like to avoid that, since the majority of Gen3 boards,
expect for the D3 Draak, use RPC in HF mode.

-- 
Best regards,
Marek Vasut