Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190124185852.19423-1-Florian.LaRoche@googlemail.com>
In-Reply-To: <20190124185852.19423-1-Florian.LaRoche@googlemail.com>
From:   Florian La Roche <florian.laroche@googlemail.com>
Date:   Sat, 26 Jan 2019 17:18:22 +0100
Message-ID: <CANZrA2YcgKq3N5LM6__djG1it3D1ATjHeaTMtoeZD3KLhHVZMg@mail.gmail.com>
Subject: Re: int_sqrt() adjustments
To:     linux-kernel@vger.kernel.org
Cc:     Crt Mori <cmo@melexis.com>, Joe Perches <joe@perches.com>,
        Davidlohr Bueso <dave@stgolabs.net>,
        Will Deacon <will.deacon@arm.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello all,

The first part of this patch is wrong: it changes from an unsigned long
param to __fls() to an unsigned int param in fls(). One option would be
to add another implementation of flsl() or given the minimalistic usage
of int_sqrt() in the kernel to keep the current code with __fls() and only
change masking the lowest bit.

The only other nitpick I have come up with: Adding __attribute_const__
could be possible.

best regards,

Florian La Roche