Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\))
Subject: Re: [v2 PATCH] rhashtable: Still do rehash when we get EEXIST
From:   Josh Elsasser <jelsasser@appneta.com>
In-Reply-To: <D5A6C2E7-2AB1-46D0-8876-2D6AAAA3937F@appneta.com>
Date:   Sat, 26 Jan 2019 14:02:48 -0800
Cc:     Thomas Graf <tgraf@suug.ch>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Josh Elsasser <jelsasser@appneta.com>
Content-Transfer-Encoding: quoted-printable
Message-Id: <A247F887-832E-44AD-AC41-C22E124E44EE@appneta.com>
References: <20190123211758.104275-1-jelsasser@appneta.com>
 <20190124030841.n4jtsqka5zji3e62@gondor.apana.org.au>
 <D5A6C2E7-2AB1-46D0-8876-2D6AAAA3937F@appneta.com>
To:     Herbert Xu <herbert@gondor.apana.org.au>,
        "David S . Miller" <davem@davemloft.net>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Jan 23, 2019, at 7:40 PM, Josh Elsasser <jelsasser@appneta.com> =
wrote:
> On Jan 23, 2019, at 7:08 PM, Herbert Xu <herbert@gondor.apana.org.au> =
wrote:
>=20
>> Thanks for catching this!
>>=20
>> Although I think we should fix this in a different way.  The problem
>> here is that the shrink cannot proceed because there was a previous
>> rehash that is still incomplete.  We should wait for its completion
>> and then reattempt a shrinnk should it still be necessary.
>=20
> I can't test this right now because our VM server's down=20

Got one of the poor little reproducer VM's back up and running and =
loaded
up this patch. Works like a charm. For the v2 PATCH, can add my:

Tested-by: Josh Elsasser <jelsasser@appneta.com>=