Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3A/naN9RHoBM/4W6rOW5pg1p1GYnF86YWxBRYc798d?=
 =?us-ascii?q?s5kLTJ78r86wAkXT6L1XgUPTWs2DsrQY07qQ6/iocFdDyK7JiGoFfp1IWk1Nou?=
 =?us-ascii?q?QttCtkPvS4D1bmJuXhdS0wEZcKflZk+3amLRodQ56mNBXdrXKo8DEdBAj0OxZr?=
 =?us-ascii?q?KeTpAI7SiNm82/yv95HJbAhEmDmwbaluIBmqsA7cqtQYjYx+J6gr1xDHuGFIe+?=
 =?us-ascii?q?NYxWNpIVKcgRPx7dqu8ZBg7ipdpesv+9ZPXqvmcas4S6dYDCk9PGAu+MLrrxjD?=
 =?us-ascii?q?QhCR6XYaT24bjwBHAwnB7BH9Q5fxri73vfdz1SWGIcH7S60/VC+85Kl3VhDnlC?=
 =?us-ascii?q?YHNyY48G7JjMxwkLlbqw+lqxBm3oLYfJ2ZOP94c6PYfNMaXnFBXsdXVyxOH4iy?=
 =?us-ascii?q?cZIBBPcPPeZZsYb9o0YBpga6CQSiGO/jzzlFjWL006InyeQsCQHI0hI9EdwAs3?=
 =?us-ascii?q?raq874OLsOXe2v0KXF1ynPY+9Q1Dzg6IbIaBchofSUUL1ycMrQyEkvFx7Cjl6N?=
 =?us-ascii?q?roHkPzKU1uQXvGia8+ZsSeyihnU6qw5tuDij3NkjhZTUho8MzF3P6CZ3wJ4tKN?=
 =?us-ascii?q?GmVEJ2ZcSoHZhQui2AKYd6X8wvT3t1tCs+yLAKoYO3cSkOxZg92RLSZfyKf5KW?=
 =?us-ascii?q?7h/iTuqcIzh1iXR4c7ylnRmy61KvyujkW8mx11ZFszRKn8HXtnAIyxzT8s+HSu?=
 =?us-ascii?q?Zh/ku52TaAyQTT6uZcLEAxj6XbKpohzqcolpoXrEjPByH2lFjygaKUbEkk9e+o?=
 =?us-ascii?q?6+PoYrXiuJCQLZN7igb7Mqg2m8y/B/o3MhQWUmSF5eix0Kfv8E75TblQkPE6j6?=
 =?us-ascii?q?bUvIrHKckfpKO1GwpV3Zwi6xa7ATemytMYnXwfIVNFeROHj5LmO1DSLPzkA/qy?=
 =?us-ascii?q?mEmsnytxx/zcILLuH4jNImDZkLj9ZbZ991JcyA0rwNBb5pJUDKwBIf3qVk/yqt?=
 =?us-ascii?q?PYFBk5PBKww+v8FtV92Z0RWXiVDq+aLqzSq1mI6fwrI+WWY48Vojn9eLAL/fnr?=
 =?us-ascii?q?2E44i18AeuH9zIkXYXHgRq9OPk6DJ3fgn4FSQi8xogMiQbmy2xW5WjlJaiP3AP?=
 =?us-ascii?q?ox?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@codeaurora.org>, linux-clk@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] clk: gemini: Variable "val" in function gemini_clk_probe() could be uninitialized
Date:   Sat, 26 Jan 2019 21:10:12 -0800
Message-Id: <20190127051012.5928-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function gemini_clk_probe(), local variable "val" could
be uninitialized if function regmap_read() returns -EINVAL.
However, it will be used as index in the later context, which
could potentially be unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/clk/clk-gemini.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/clk-gemini.c b/drivers/clk/clk-gemini.c
index 5e66e6c0205e..07e1b551d1d9 100644
--- a/drivers/clk/clk-gemini.c
+++ b/drivers/clk/clk-gemini.c
@@ -314,7 +314,10 @@ static int gemini_clk_probe(struct platform_device *pdev)
 	gemini_clk_data->hws[GEMINI_CLK_RTC] = hw;
 
 	/* CPU clock derived as a fixed ratio from the AHB clock */
-	regmap_read(map, GEMINI_GLOBAL_STATUS, &val);
+	ret = regmap_read(map, GEMINI_GLOBAL_STATUS, &val);
+	if (ret)
+		return ret;
+
 	val >>= CPU_AHB_RATIO_SHIFT;
 	val &= CPU_AHB_RATIO_MASK;
 	hw = clk_hw_register_fixed_factor(NULL, "cpu", "ahb", 0,
@@ -323,7 +326,10 @@ static int gemini_clk_probe(struct platform_device *pdev)
 	gemini_clk_data->hws[GEMINI_CLK_CPU] = hw;
 
 	/* Security clock is 1:1 or 0.75 of APB */
-	regmap_read(map, GEMINI_GLOBAL_CLOCK_CONTROL, &val);
+	ret = regmap_read(map, GEMINI_GLOBAL_CLOCK_CONTROL, &val);
+	if (ret)
+		return ret;
+
 	if (val & SECURITY_CLK_SEL) {
 		mult = 1;
 		div = 1;
-- 
2.17.1